From: "Rafał Miłecki" <rafal@milecki.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Ming Lei" <ming.lei@canonical.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 2/2] brcmfmac: don't warn user if loading firmware file with NVRAM fails
Date: Thu, 16 Feb 2017 08:25:42 +0100 [thread overview]
Message-ID: <de837236542d5b762d97e4d5a55cd589@milecki.pl> (raw)
In-Reply-To: <CAHp75Vee+f5eH7DFWNcWFPcdoBf_63yQh7L71dLpNSmC5fXDww@mail.gmail.com>
On 2017-02-16 02:19, Andy Shevchenko wrote:
> On Thu, Feb 16, 2017 at 12:29 AM, Rafał Miłecki <zajec5@gmail.com>
> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This isn't critical as we use platform NVRAM as fallback and it's very
>> common case of all Broadcom home routers. Thanks for the new firmware
>> loading function we can achieve this by simply passing FW_OPT_NO_WARN.
>>
>
> What kind of warning you are talking about?
>
> On Intel Edison brcmfmac isn't backed up by NVRAM (there no such) and
> the platform is not ACPI-based. The warning might be crucial for
> debugging Wi-Fi issues on such platforms.
Sorry, I should have tried better with that commit message. V2 in a
second.
next prev parent reply other threads:[~2017-02-16 7:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 22:29 [PATCH 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-02-15 22:29 ` [PATCH 2/2] brcmfmac: don't warn user if loading firmware file with NVRAM fails Rafał Miłecki
2017-02-16 1:19 ` Andy Shevchenko
2017-02-16 7:25 ` Rafał Miłecki [this message]
2017-02-16 7:26 ` [PATCH V2 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-02-16 7:26 ` [PATCH V2 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds Rafał Miłecki
2017-02-16 8:38 ` Arend Van Spriel
2017-02-16 9:04 ` Rafał Miłecki
2017-02-16 9:18 ` Arend Van Spriel
2017-02-16 9:32 ` Rafał Miłecki
2017-02-16 10:17 ` Arend Van Spriel
2017-02-21 9:47 ` [PATCH V3 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-02-21 9:47 ` [PATCH V3 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds Rafał Miłecki
2017-02-21 9:57 ` Arend Van Spriel
2017-02-21 11:46 ` Kalle Valo
2017-02-21 18:04 ` [PATCH V3 1/2] firmware: add more flexible request_firmware_async function Luis R. Rodriguez
2017-02-23 18:30 ` [PATCH V4 " Rafał Miłecki
2017-02-23 18:30 ` [PATCH V4 2/2] brcmfmac: don't warn user about NVRAM if fallback to platform one succeeds Rafał Miłecki
2017-03-16 9:57 ` [PATCH V4 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-03-16 13:31 ` Greg KH
2017-03-16 13:55 ` Rafał Miłecki
2017-03-16 14:03 ` Greg KH
2017-03-17 17:29 ` Luis R. Rodriguez
2017-03-27 19:28 ` Luis R. Rodriguez
2017-02-21 18:02 ` [PATCH V2 " Luis R. Rodriguez
2017-02-21 17:59 ` [PATCH " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de837236542d5b762d97e4d5a55cd589@milecki.pl \
--to=rafal@milecki.pl \
--cc=andy.shevchenko@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@canonical.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®