mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
	linux-bcache@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: remove redundant variables i and n
Date: Thu, 2 Apr 2020 19:34:09 +0800	[thread overview]
Message-ID: <de88ae08-1200-285b-cd1b-cfd723d2da56@suse.de> (raw)
In-Reply-To: <20200402111903.514146-1-colin.king@canonical.com>

On 2020/4/2 7:19 下午, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variables i and n are being assigned but are never used. They are
> redundant and can be removed.
> 

Hi Colin,

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, I will submit this patch in Linux 5.7-rc series.

> ---
>  drivers/md/bcache/btree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 72856e5f23a3..114d0d73d909 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1907,10 +1907,8 @@ static int bch_btree_check_thread(void *arg)
>  	struct btree_iter iter;
>  	struct bkey *k, *p;
>  	int cur_idx, prev_idx, skip_nr;
> -	int i, n;
>  
>  	k = p = NULL;
> -	i = n = 0;
>  	cur_idx = prev_idx = 0;
>  	ret = 0;
>  
> 


-- 

Coly Li

      reply	other threads:[~2020-04-02 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 11:19 Colin King
2020-04-02 11:34 ` Coly Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de88ae08-1200-285b-cd1b-cfd723d2da56@suse.de \
    --to=colyli@suse.de \
    --cc=colin.king@canonical.com \
    --cc=kent.overstreet@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®