From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Nicolai Buchwitz <nb@tipi-net.de>,
Doug Berger <opendmb@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Justin Chen <justin.chen@broadcom.com>,
Petri Gynther <pgynther@google.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/5] net: bcmgenet: keep DIM from getting stuck after close or suspend
Date: Fri, 20 Nov 2026 16:19:35 -0800 [thread overview]
Message-ID: <de8e6289-9c2d-4c99-8f20-680e05397929@broadcom.com> (raw)
In-Reply-To: <20261120-nb-genet-dim-stats-net-v2-1-1a7cece7dd1a@tipi-net.de>
On 11/20/26 14:42, Nicolai Buchwitz wrote:
> A close or WoL suspend cancels the pending profile work and can leave
> DIM in DIM_APPLY_NEW_PROFILE, where net_dim() does nothing. Adaptive
> coalescing then stays stuck after the next open or resume, and the
> profile index no longer matches the hardware. The poll also calls
> net_dim() after napi_complete_done(), so it can queue new work after
> napi_disable() has returned.
>
> Run net_dim() before completing NAPI and flush the work instead of
> cancelling it, so the pending profile gets applied. Also reset the DIM
> state on ring init and start from the default profile, which is what
> bcmgenet_init_rx_coalesce() programs.
>
> Fixes: 9f4ca05827a2 ("net: bcmgenet: Add support for adaptive RX coalescing")
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-11-21 0:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 22:42 [PATCH net v2 0/5] net: bcmgenet, systemport: DIM and Rx discard fixes Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 1/5] net: bcmgenet: keep DIM from getting stuck after close or suspend Nicolai Buchwitz
2026-11-21 0:19 ` Florian Fainelli [this message]
2026-11-20 22:42 ` [PATCH net v2 2/5] net: bcmgenet: accumulate the DIM packet and byte counters Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 3/5] net: bcmgenet: reset the Rx discard count with the ring Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 4/5] net: systemport: restart DIM from the default profile on start Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 5/5] net: systemport: accumulate the DIM packet and byte counters Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8e6289-9c2d-4c99-8f20-680e05397929@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®