mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <treding@nvidia.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] regulator: core: Add stubs for driver API
Date: Mon, 21 Jun 2021 18:33:46 +0300	[thread overview]
Message-ID: <de8fe5dd-30d3-1ba1-66cd-1bb8b88f984c@gmail.com> (raw)
In-Reply-To: <20210621123447.GH4094@sirena.org.uk>

21.06.2021 15:34, Mark Brown пишет:
> On Mon, Jun 21, 2021 at 03:04:30PM +0300, Dmitry Osipenko wrote:
>> 21.06.2021 14:46, Mark Brown пишет:
> 
>>> Why would something be registering a regulator device without a
>>> dependency on the regulator API?
> 
>> For example if regulator device registration is optional in the code. We
>> don't have such cases in the kernel today, but I decided that it will be
>> cleaner to add stubs for the whole API.
> 
> It doesn't strike me as the sort of thing that should be optional TBH.
> It seems much more likely that not having the stub will catch silly
> errors than that the stubs will make something work that should.
> 
>> If you think that it will be better to add the dependency to the coupler
>> drivers, then let's do it.
> 
> For coupler drivers it's not clear what function they serve without the
> regulator API being enabled.
> 

I'll prepare patch to fix the Kconfig entry of the coupler drivers,
thank you.

      reply	other threads:[~2021-06-21 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 12:40 Dmitry Osipenko
2021-06-21 11:46 ` Mark Brown
2021-06-21 12:04   ` Dmitry Osipenko
2021-06-21 12:34     ` Mark Brown
2021-06-21 15:33       ` Dmitry Osipenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8fe5dd-30d3-1ba1-66cd-1bb8b88f984c@gmail.com \
    --to=digetx@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®