From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdEQRPl (ORCPT ); Wed, 17 May 2017 13:15:41 -0400 Received: from mout.web.de ([212.227.15.14]:53724 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdEQRO2 (ORCPT ); Wed, 17 May 2017 13:14:28 -0400 To: devel@driverdev.osuosl.org, Bhumika Goyal , "David S. Miller" , Greg Kroah-Hartman , Jay Vosburgh , Julia Lawall , Mihaela Muraru , Mike Kofron , Philippe Reynes , Stephen Hemminger , Tobias Klauser From: SF Markus Elfring Subject: [PATCH] staging: netlogic: Delete an error message for a failed memory allocation in xlr_config_spill() Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang Message-ID: Date: Wed, 17 May 2017 19:14:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:BLJs2V1ikgHHxv0VOoCVsjFvQlPNqLdMiBeq81sGwa50fGAMbIv JU0Bx7GgfhMNoq6+IepI0fFHXHqnobDfHBvXCq9tlQ8ZCLXC9xzmVt/Y21KQZDanrDqxmvJ F8Mur0fyBTKkLjzK0ggmuuT4CzAKIoDuT7ioX8/GQINKInJXj4cZoq2Zftdnck/1QlAxWhZ 0mmNCEX9DxRly6IJGtWUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:UpuvyhKHzbM=:SntKaGrdjks1TexJyZzUCw 7RCh6XzDLUfC1/Lpc2LKcmev6661iAh/s6VIxRdfCP7ROtoivmuMrXKHfLv3hA9tyOA/FY6eE 11aq6bnTNREmtyyuRnJdBJWOGynhC718GRZ8M6trwx2YKIAPmwQ57C9PNGKJDRL6zcTweE0TV tOR+mQWL2AGRoIAOv8t2y8hL+L4GOpkqrFd4nKSytYylSm0lsSUMlQ/gB2d484YbtjE1AKHQ7 pBizrTJDaOatpswMStx7tE2/nQM0nR6tn3unIAI9dOp2Rbwe74CtXNxl28V+QCmpuXtfIB3+e 6pLw+JTY6InoJpy6ntc+N60q+b8J/usl7+zyivt/T7lQAQK8rxSW1MGVjMnPPTgpBxRwclkKs Z2UCivfR6KEV+zyJub7yZSwcbwbP6wRAgbbXTCw97uv9ZwXUp74jaZxR6dKc0AjtPy7Kp8j5m 2wAz2FYQdXRhSGJ8LFTwEeowTzD8iwaAjMJF6+He6YM33s4rThbbR3udT1XCxuxQHbIiYd2Wi z3tjrAuDYcSVPj3h2QsofG5sOzufbEyBtaJIQo6IQ0LdWj1jHjOicxRObXBzKZWyqqmvnDfma 3VAX1oflTY3+XQRtZ2U80i4xCDm8v08dZpuSTKxRMe2sgD2tC+M3NpWdrYkPH91y7I62dZHD1 lJgsoouLvOtCTw32rlfMAZRAwPbSXM3WWziZbnLZc5fWEtai36quQDLS6zPN7nu3ovHqzw5VL mqSogvDBy38AmSjJbgNUJwYqIKrScdz8WFl3I6yjf3QyAym2RIj8qlGQ5AnUmXn8q3KNyX3Vb K4w+ZRL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 17 May 2017 19:01:10 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/staging/netlogic/xlr_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index 781ef623233e..864304eb5f36 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -420,10 +420,8 @@ static void *xlr_config_spill(struct xlr_net_priv *priv, int reg_start_0, base = priv->base_addr; spill_size = size; spill = kmalloc(spill_size + SMP_CACHE_BYTES, GFP_ATOMIC); - if (!spill) { - pr_err("Unable to allocate memory for spill area!\n"); + if (!spill) return ZERO_SIZE_PTR; - } spill = PTR_ALIGN(spill, SMP_CACHE_BYTES); phys_addr = virt_to_phys(spill); -- 2.13.0