From: Andrew Lunn <andrew@lunn.ch>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3] soc: qcom: aoss: Add debugfs interface for sending messages
Date: Fri, 19 Jan 2024 14:43:08 +0100 [thread overview]
Message-ID: <de9ca78f-0d4c-4793-a21e-5d5f8dc6eacc@lunn.ch> (raw)
In-Reply-To: <20240117-qcom-aoss-debugfs-v2-v3-1-1aa779124822@quicinc.com>
> +static void qmp_debugfs_create(struct qmp *qmp)
> +{
> + const struct qmp_debugfs_entry *entry;
> + int i;
> +
> + qmp->debugfs_root = debugfs_create_dir("qcom_aoss", NULL);
> +
> + for (i = 0; i < ARRAY_SIZE(qmp->debugfs_files); i++) {
> + entry = &qmp_debugfs_entries[i];
> +
> + qmp->debugfs_files[i] = debugfs_create_file(entry->name, 0220,
group write? Generally you only want root able to do writes.
However, thanks for reworking this to just support some well defined
commands, rather than binary blobs from user space.
Andrew
next prev parent reply other threads:[~2024-01-19 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 2:31 Bjorn Andersson
2024-01-19 13:43 ` Andrew Lunn [this message]
2024-01-22 10:44 ` Konrad Dybcio
2024-01-23 0:29 ` Bjorn Andersson
2024-01-23 18:37 ` Konrad Dybcio
2024-01-27 1:35 ` Chris Lew
2024-01-28 17:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de9ca78f-0d4c-4793-a21e-5d5f8dc6eacc@lunn.ch \
--to=andrew@lunn.ch \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®