From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Anson Huang <anson.huang@nxp.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak
Date: Mon, 5 Nov 2018 14:34:42 +0100 [thread overview]
Message-ID: <dea51d27-0957-f762-773f-e0e0e001045c@linaro.org> (raw)
In-Reply-To: <1541379930-14538-2-git-send-email-Anson.Huang@nxp.com>
Hi Anson,
On 05/11/2018 02:10, Anson Huang wrote:
> kfree should be called to free resource in error path
> before return.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/clocksource/timer-imx-gpt.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
> index a3d6ccb..0f78b30 100644
> --- a/drivers/clocksource/timer-imx-gpt.c
> +++ b/drivers/clocksource/timer-imx-gpt.c
> @@ -477,12 +477,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t
> return -ENOMEM;
>
> imxtm->base = of_iomap(np, 0);
> - if (!imxtm->base)
> + if (!imxtm->base) {
> + kfree(imxtm);
> return -ENXIO;
> + }
>
> imxtm->irq = irq_of_parse_and_map(np, 0);
> - if (imxtm->irq <= 0)
> + if (imxtm->irq <= 0) {
> + kfree(imxtm);
> return -EINVAL;
> + }
>
> imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
Please convert to timer-of API.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-11-05 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 1:10 [PATCH V2 1/2] clocksource: imx-gpt: add support for ARM64 Anson Huang
2018-11-05 1:10 ` [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak Anson Huang
2018-11-05 13:34 ` Daniel Lezcano [this message]
2018-11-06 1:38 ` Anson Huang
2018-11-06 9:06 ` Daniel Lezcano
2018-11-06 9:12 ` Anson Huang
2018-11-18 1:52 ` Daniel Lezcano
2018-11-18 1:54 ` [PATCH V2 1/2] clocksource: imx-gpt: add support for ARM64 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dea51d27-0957-f762-773f-e0e0e001045c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=anson.huang@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®