From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B944328B72; Thu, 8 Jan 2026 19:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767901409; cv=none; b=unUZMj2zjR2GgSTqkfYSj5G9GUhZbU3fIwvjeC/Ra8eCA17FNlEqa6wfTIHFlDmf9BqVR2WLNBcpuDjtTB+hEqhqDMhkjYxx5WEYDFreKcWmKSpmBIYVYcaP7vNuVSC4W9jfav92NiTCWnMwCgZUnK9Wh/1nM+ar+4ISk9H8Tew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767901409; c=relaxed/simple; bh=PARMCHULN39OqJTkCrAKqCeTaF3GhUp7Z51iV+p+ep0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rOPIYrJhsytrwkPLe20NQXCanochAKsqdRlm2gJ4u5qCjs2YxNgHAQ7MYEO1Tl1ZsQ2OnvdNPXa/UgL62pqPBbaEi0jQmTH6U0hDilcjmJnX6qyEbmW/QG2A7u1hAixB2mwVJ1i9ij35eKnYzrBjzYPN3ktEIv4ChWtlP4CPlss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=E0aQTZ/+; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="E0aQTZ/+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767901403; bh=PARMCHULN39OqJTkCrAKqCeTaF3GhUp7Z51iV+p+ep0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=E0aQTZ/+FajpyaTH1Lx7woECPN7VD8iDKQxuKjCbthrqZTTNF8piFMdeYGBA2eNY2 nwBJAWu6sCWdxvY63LB/0wIqaeFwqyug6IPEsNmdgGjPe4bvTv7h3E72jUjOcuCuEu O0tfOA0Mdrir/NOxx/4LnQVXN3G7S45ewmJJx+xMnpg/yHwC0kBpesd3QP/MijLyuq 0kI+jt31FgYHvsWrgUSwLLBpelwqLKth2lj3AIsOXhbI2jAi7Kd7cxah0BZ9I8AVAj cIvghqoF6KiFXgA7MEW7WG/Rj+wtinrujRONbOv+pnNpbBEJjiB1bhe3Oa4P/o4xCK H1a4yau0ZmicQ== Received: from [192.168.42.140] (mtl.collabora.ca [66.171.169.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3DF4917E0023; Thu, 8 Jan 2026 20:43:22 +0100 (CET) Message-ID: Subject: Re: [PATCH] media: verisilicon: AV1: Set IDR flag for intra_only frame type From: Nicolas Dufresne To: Benjamin Gaignard , p.zabel@pengutronix.de, mchehab@kernel.org, heiko@sntech.de Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Jianfeng Liu Date: Thu, 08 Jan 2026 14:43:17 -0500 In-Reply-To: <20260108132946.74853-1-benjamin.gaignard@collabora.com> References: <20260108132946.74853-1-benjamin.gaignard@collabora.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-/7N/TlSYMxJmoXRb6zgA" User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-/7N/TlSYMxJmoXRb6zgA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 08 janvier 2026 =C3=A0 14:29 +0100, Benjamin Gaignard a =C3=A9crit= =C2=A0: > Intra_only frame could be considered as a key frame so Instantaneous > Decoding Refresh (IDR) flag must be set of the both case and not only > for key frames. >=20 > Signed-off-by: Benjamin Gaignard > Reported-by: Jianfeng Liu > Fixes: 727a400686a2c ("media: verisilicon: Add Rockchip AV1 decoder") Reviewed-by: Nicolas Dufresne > --- > =C2=A0drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c | 2= +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_de= c.c b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c > index 1605cfd55d36..3a8123bbe144 100644 > --- a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c > +++ b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c > @@ -2047,7 +2047,7 @@ static void rockchip_vpu981_av1_dec_set_parameters(= struct hantro_ctx *ctx) > =C2=A0 !!(ctrls->frame->quantization.flags > =C2=A0 =C2=A0=C2=A0=C2=A0 & V4L2_AV1_QUANTIZATION_FLAG_DELTA_Q_PRESENT)= ); > =C2=A0 > - hantro_reg_write(vpu, &av1_idr_pic_e, !ctrls->frame->frame_type); > + hantro_reg_write(vpu, &av1_idr_pic_e, IS_INTRA(ctrls->frame->frame_type= )); > =C2=A0 hantro_reg_write(vpu, &av1_quant_base_qindex, ctrls->frame->quanti= zation.base_q_idx); > =C2=A0 hantro_reg_write(vpu, &av1_bit_depth_y_minus8, ctx->bit_depth - 8)= ; > =C2=A0 hantro_reg_write(vpu, &av1_bit_depth_c_minus8, ctx->bit_depth - 8)= ; --=-/7N/TlSYMxJmoXRb6zgA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaWAI1gAKCRDZQZRRKWBy 9AaUAQDuIVVUilNFK7PyWBn48YCLBtitf9JFegmpMlAJewrHSQEA+ZlN2CHePiXx 37D0/89e+JMVXMhs5T4nPsfIemfrYQQ= =t8Mi -----END PGP SIGNATURE----- --=-/7N/TlSYMxJmoXRb6zgA--