From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755934AbdJJJYM (ORCPT ); Tue, 10 Oct 2017 05:24:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:56966 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbdJJJYJ (ORCPT ); Tue, 10 Oct 2017 05:24:09 -0400 X-Google-Smtp-Source: AOwi7QBBxC6mZBsg0XNpCYdq6V6O20SRFyNt85zegxBx5WG8gE2/Hcd/HsgYjdOGunxFmGsmn4efAw== Subject: Re: [PATCH v2 2/3] mtd: spi-nor: Altera ASMI Parallel II IP Core To: matthew.gerlach@linux.intel.com, vndao@altera.com, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, davem@davemloft.net, mchehab@kernel.org, linux-fpga@vger.kernel.org, tien.hock.loh@intel.com, hean.loong.ong@intel.com References: <1505932139-2905-1-git-send-email-matthew.gerlach@linux.intel.com> <1505932139-2905-3-git-send-email-matthew.gerlach@linux.intel.com> From: Marek Vasut Message-ID: Date: Tue, 10 Oct 2017 11:24:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505932139-2905-3-git-send-email-matthew.gerlach@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2017 08:28 PM, matthew.gerlach@linux.intel.com wrote: > From: Matthew Gerlach > > This patch adds support for a spi-nor, platform driver for the > Altera ASMI Parallel II IP Core. The intended use case is to be able > to update the flash used to load a FPGA at power up with mtd-utils. > > Signed-off-by: Matthew Gerlach > --- > v2: > minor checkpatch fixing by Wu Hao > Use read_dummy value as suggested by Cyrille Pitchen. > Don't assume 4 byte addressing (Cryille Pichecn and Marek Vasut). > Fixed #define indenting as suggested by Marek Vasut. > Added units to timer values as suggested by Marek Vasut. > Use io(read|write)8_rep() as suggested by Marek Vasut. > Renamed function prefixed with __ as suggested by Marek Vasut. [...] > +#define QSPI_ACTION_REG 0 > +#define QSPI_ACTION_RST BIT(0) > +#define QSPI_ACTION_EN BIT(1) > +#define QSPI_ACTION_SC BIT(2) > +#define QSPI_ACTION_CHIP_SEL_SFT 4 > +#define QSPI_ACTION_DUMMY_SFT 8 > +#define QSPI_ACTION_READ_BACK_SFT 16 > + > +#define QSPI_FIFO_CNT_REG 4 > +#define QSPI_FIFO_DEPTH 0x200 > +#define QSPI_FIFO_CNT_MSK 0x3ff > +#define QSPI_FIFO_CNT_RX_SFT 0 > +#define QSPI_FIFO_CNT_TX_SFT 12 > + > +#define QSPI_DATA_REG 0x8 > + > +#define QSPI_POLL_TIMEOUT_US 10000000 10 s poll timeout ? :) > +#define QSPI_POLL_INTERVAL_US 5 > + > +struct altera_asmip2 { [...] Otherwise looks good -- Best regards, Marek Vasut