From: ferar achkar <ferarachkar@gmail.com>
To: peterz@infradead.org
Cc: mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org
Subject: perf: arm64: libunwind patch
Date: Tue, 17 Mar 2020 18:29:05 -0400 [thread overview]
Message-ID: <deb0d490-e2ad-40d5-f804-c51a91edc4d5@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4029 bytes --]
hi,
please find attached a compile error fix.
regards,
ferar
------------------
ferar@barbarian:~/renegade_rk3328/perf_core$ make -j4 ARCH=arm64 ....
....
Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/kvm.h'
differs from latest version at 'arch/arm64/include/uapi/asm/kvm.h'
diff -u tools/arch/arm64/include/uapi/asm/kvm.h
arch/arm64/include/uapi/asm/kvm.h
Warning: Kernel ABI header at
'tools/include/uapi/asm-generic/mman-common.h' differs from latest
version at 'include/uapi/asm-generic/mman-common.h'
diff -u tools/include/uapi/asm-generic/mman-common.h
include/uapi/asm-generic/mman-common.h
Auto-detecting system features:
... dwarf: [ on ]
... dwarf_getlocations: [ on ]
... glibc: [ on ]
... gtk2: [ OFF ]
... libaudit: [ on ]
... libbfd: [ on ]
... libcap: [ on ]
... libelf: [ on ]
... libnuma: [ OFF ]
... numa_num_possible_cpus: [ OFF ]
... libperl: [ OFF ]
... libpython: [ OFF ]
... libcrypto: [ on ]
... libunwind: [ on ]
... libdw-dwarf-unwind: [ on ]
... zlib: [ on ]
... lzma: [ on ]
... get_cpuid: [ OFF ]
... bpf: [ on ]
... libaio: [ on ]
... libzstd: [ OFF ]
... disassembler-four-args: [ on ]
Makefile.config:497: No sys/sdt.h found, no SDT events are defined,
please install systemtap-sdt-devel or systemtap-sdt-dev
....
CC util/dwarf-regs.o
CC util/unwind-libunwind-local.o
CC util/unwind-libunwind.o
CC util/libunwind/arm64.o
util/libunwind/arm64.c:20:40: error: no previous prototype for
‘libunwind__arm64_reg_id’ [-Werror=missing-prototypes]
#define LIBUNWIND__ARCH_REG_ID(regnum) libunwind__arm64_reg_id(regnum)
^
util/libunwind/../../arch/arm64/util/unwind-libunwind.c:11:5: note: in
expansion of macro ‘LIBUNWIND__ARCH_REG_ID’
int LIBUNWIND__ARCH_REG_ID(int regnum)
^~~~~~~~~~~~~~~~~~~~~~
CC util/zlib.o
CC util/lzma.o
util/libunwind/arm64.c:20:40: error: redundant redeclaration of
‘libunwind__arm64_reg_id’ [-Werror=redundant-decls]
#define LIBUNWIND__ARCH_REG_ID(regnum) libunwind__arm64_reg_id(regnum)
^
/home/ferar/renegade_rk3328/linux-5.4.0-rc1/tools/perf/util/unwind.h:49:5:
note: in expansion of macro ‘LIBUNWIND__ARCH_REG_ID’
int LIBUNWIND__ARCH_REG_ID(int regnum);
^~~~~~~~~~~~~~~~~~~~~~
util/libunwind/arm64.c:20:40: note: previous definition of
‘libunwind__arm64_reg_id’ was here
#define LIBUNWIND__ARCH_REG_ID(regnum) libunwind__arm64_reg_id(regnum)
^
util/libunwind/../../arch/arm64/util/unwind-libunwind.c:11:5: note: in
expansion of macro ‘LIBUNWIND__ARCH_REG_ID’
int LIBUNWIND__ARCH_REG_ID(int regnum)
^~~~~~~~~~~~~~~~~~~~~~
CC util/cap.o
CC util/demangle-java.o
CC util/demangle-rust.o
....
----------------------------------------------------------------------
[-- Attachment #2: 0001-Fix-Arm64-libunwind-trivial-compile-error.patch --]
[-- Type: text/x-patch, Size: 1141 bytes --]
From 0c6bf617d5696dda28ecac776c09b3f5b3921526 Mon Sep 17 00:00:00 2001
From: ferar achkar <ferarachkar@gmail.com>
Date: Tue, 17 Mar 2020 18:15:37 -0400
Subject: [PATCH] Fix Arm64 libunwind trivial compile error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
fix trivial compile error 'no previous prototype for
‘libunwind__arm64_reg_id’' [-Werror=missing-prototypes], this error
related to including userspace bundled 'unwind.h' instead of using
perf's local version.
---
tools/perf/util/libunwind/arm64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
index 6b4e5a089..fd26e612d 100644
--- a/tools/perf/util/libunwind/arm64.c
+++ b/tools/perf/util/libunwind/arm64.c
@@ -21,7 +21,7 @@
#define LIBUNWIND__ARCH_REG_IP PERF_REG_ARM64_PC
#define LIBUNWIND__ARCH_REG_SP PERF_REG_ARM64_SP
-#include "unwind.h"
+#include "../../util/unwind.h"
#include "libunwind-aarch64.h"
#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
#include "../../arch/arm64/util/unwind-libunwind.c"
--
2.17.1
next reply other threads:[~2020-03-17 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 22:29 ferar achkar [this message]
2020-03-18 3:19 ` Leo Yan
2020-03-18 23:47 ` ferar achkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb0d490-e2ad-40d5-f804-c51a91edc4d5@gmail.com \
--to=ferarachkar@gmail.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®