From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932947AbeAKVYz (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 16:24:55 -0500
Received: from mga03.intel.com ([134.134.136.65]:18698 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754483AbeAKVYx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 16:24:53 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,346,1511856000"; 
   d="scan'208";a="20274251"
Subject: Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Peter Zijlstra <peterz@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-kernel@vger.kernel.org
References: <cover.1515542293.git.tim.c.chen@linux.intel.com>
 <3aab341725ee6a9aafd3141387453b45d788d61a.1515542293.git.tim.c.chen@linux.intel.com>
 <alpine.DEB.2.20.1801111639290.2091@nanos>
 <90242f1d-216d-2213-4bb2-5450f4cb07be@linux.intel.com>
Message-ID: <deb1ee64-443c-670a-d16f-b3c71b963934@linux.intel.com>
Date: Thu, 11 Jan 2018 13:24:52 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <90242f1d-216d-2213-4bb2-5450f4cb07be@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 01/11/2018 01:05 PM, Tim Chen wrote:
> On 01/11/2018 08:04 AM, Thomas Gleixner wrote:
>> On Tue, 9 Jan 2018, Tim Chen wrote:
>>> +
>>> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req
>>> +	movl	\msr_nr, %ecx
>>> +	movl	\edx_val, %edx
>>> +	movl	\eax_val, %eax
>>> +.endm
>>
>> This is the most brilliant piece of useless code I've seen in a long time.
>>
>>
>> 	 tglx
>>
> 
> Sorry that was a major brain fart on my part. 
> 

Our internal tester mixed in retpoline with IBRS so we've missed
this.  Will correct our test.

Tim