From: Li Ming <ming.li@zohomail.com>
To: xiaopeitux@foxmail.com, Pei Xiao <xiaopei01@kylinos.cn>
Cc: dave@stgolabs.net, jonathan.cameron@huawei.com,
dave.jiang@intel.com, alison.schofield@intel.com,
vishal.l.verma@intel.com, ira.weiny@intel.com,
dan.j.williams@intel.com, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl : fix cxlctl_validate_hw_command() warn: always true condition
Date: Mon, 7 Apr 2025 14:10:20 +0800 [thread overview]
Message-ID: <deb343df-39be-4bf9-9288-179a73154ad0@zohomail.com> (raw)
In-Reply-To: <tencent_30DA5E4827F37333AE881122DCE054DC9008@qq.com>
On 4/7/2025 11:41 AM, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> smatch warnings:
> drivers/cxl/core/features.c:441 cxlctl_validate_hw_command()
> warn: always true condition '(scope >= 0) => (0-u32max >= 0)'
>
> remove always true condition.
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
> drivers/cxl/core/features.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index f4daefe3180e..fdca93c984ce 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -616,9 +616,8 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,
> case CXL_MBOX_OP_GET_FEATURE:
> if (cxl_mbox->feat_cap < CXL_FEATURES_RO)
> return false;
> - if (scope >= FWCTL_RPC_CONFIGURATION)
> + else
> return true;
> - return false;
> case CXL_MBOX_OP_SET_FEATURE:
> if (cxl_mbox->feat_cap < CXL_FEATURES_RW)
> return false;
Already have a patch posted for this issue.
https://lore.kernel.org/linux-cxl/67f02de69d89c_9fe8529481@iweiny-mobl.notmuch/T/#m84c3093032b5eb167bbb1d0a787019d0387f4ae8
prev parent reply other threads:[~2025-04-07 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 3:41 xiaopeitux
2025-04-07 6:10 ` Li Ming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb343df-39be-4bf9-9288-179a73154ad0@zohomail.com \
--to=ming.li@zohomail.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®