From: Ping-Ke Shih <pkshih@realtek.com>
To: "martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] rtw88: Add packed attribute to the eFuse structs
Date: Thu, 29 Dec 2022 23:47:25 +0000 [thread overview]
Message-ID: <deb574a080e603e9dd5eee36c1a3fe7c88588d59.camel@realtek.com> (raw)
In-Reply-To: <20221229124845.1155429-2-martin.blumenstingl@googlemail.com>
On Thu, 2022-12-29 at 13:48 +0100, Martin Blumenstingl wrote:
> The eFuse definitions in the rtw88 are using structs to describe the
> eFuse contents. Add the packed attribute to all structs used for the
> eFuse description so the compiler doesn't add gaps or re-order
> attributes.
>
> Also split the res2 eFuse field (which for some reason has parts of it's
> data in two separate u8 fields) to avoid the following warning, now that
> their surrounding struct has the packed attribute:
> note: offset of packed bit-field 'res2' has changed in GCC 4.4
>
> Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
> Fixes: ab0a031ecf29 ("rtw88: 8723d: Add read_efuse to recognize efuse info from map")
> Fixes: 769a29ce2af4 ("rtw88: 8821c: add basic functions")
> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")
> Fixes: aff5ffd718de ("wifi: rtw88: Add rtw8821cu chipset support")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks for your work!
next prev parent reply other threads:[~2022-12-29 23:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 12:48 [PATCH 0/4] rtw88: Four fixes found while working on SDIO support Martin Blumenstingl
2022-12-29 12:48 ` [PATCH 1/4] rtw88: Add packed attribute to the eFuse structs Martin Blumenstingl
2022-12-29 23:47 ` Ping-Ke Shih [this message]
2022-12-29 12:48 ` [PATCH 2/4] rtw88: Configure the registers from rtw_bf_assoc() outside the RCU lock Martin Blumenstingl
2022-12-29 23:48 ` Ping-Ke Shih
2023-01-04 15:43 ` Martin Blumenstingl
2023-01-05 0:44 ` Ping-Ke Shih
2022-12-29 12:48 ` [PATCH 3/4] rtw88: Use rtw_iterate_vifs() for rtw_vif_watch_dog_iter() Martin Blumenstingl
2022-12-29 12:48 ` [PATCH 4/4] rtw88: Use non-atomic rtw_iterate_stas() in rtw_ra_mask_info_update() Martin Blumenstingl
2022-12-29 17:41 ` [PATCH 0/4] rtw88: Four fixes found while working on SDIO support Larry Finger
2022-12-29 20:11 ` Martin Blumenstingl
2023-01-04 13:22 ` Sascha Hauer
2023-01-07 18:23 ` gert erkelens
2023-01-08 19:26 ` Martin Blumenstingl
2023-01-09 0:55 ` Ping-Ke Shih
-- strict thread matches above, loose matches on Subject: below --
2022-12-28 13:35 Martin Blumenstingl
2022-12-28 13:35 ` [PATCH 1/4] rtw88: Add packed attribute to the eFuse structs Martin Blumenstingl
2022-12-29 9:24 ` Ping-Ke Shih
2022-12-29 10:37 ` Martin Blumenstingl
2022-12-29 11:35 ` Ping-Ke Shih
2022-12-31 16:57 ` David Laight
2023-01-01 11:42 ` Ping-Ke Shih
2023-01-01 11:54 ` David Laight
2023-01-01 13:08 ` Ping-Ke Shih
2023-01-04 15:30 ` Martin Blumenstingl
2023-01-04 15:53 ` David Laight
2023-01-04 16:07 ` Martin Blumenstingl
2023-01-04 16:31 ` David Laight
2023-01-04 17:49 ` Martin Blumenstingl
2023-01-05 0:56 ` Ping-Ke Shih
2023-01-05 8:34 ` David Laight
2023-01-10 12:02 ` Kalle Valo
2023-01-10 12:34 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb574a080e603e9dd5eee36c1a3fe7c88588d59.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®