From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 21982C5CFC0 for ; Fri, 15 Jun 2018 00:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7FE6208B5 for ; Fri, 15 Jun 2018 00:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7FE6208B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zytor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965220AbeFOASd (ORCPT ); Thu, 14 Jun 2018 20:18:33 -0400 Received: from terminus.zytor.com ([198.137.202.136]:54567 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965126AbeFOASb (ORCPT ); Thu, 14 Jun 2018 20:18:31 -0400 Received: from hanvin-mobl2.amr.corp.intel.com ([192.55.54.44]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id w5F0HRMo1076279 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 14 Jun 2018 17:17:27 -0700 Subject: Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to To: Nick Desaulniers Cc: Andrew Morton , mingo@redhat.com, Thomas Gleixner , linux-efi@vger.kernel.org, LKML , x86@kernel.org, virtualization@lists.linux-foundation.org, Alistair Strachan , Manoj Gupta , Greg Hackmann , sedat.dilek@gmail.com, tstellar@redhat.com, Kees Cook , Masahiro Yamada , Michal Marek , Linux Kbuild mailing list , geert@linux-m68k.org, Will Deacon , mawilcox@microsoft.com, Arnd Bergmann , David Rientjes , acme@redhat.com, Philippe Ombredanne , Andrey Ryabinin , Kate Stewart , boris.ostrovsky@oracle.com, "J. Kiszka" , rostedt@goodmis.org, kirill.shutemov@linux.intel.com, Ard Biesheuvel , akataria@vmware.com, brijesh.singh@amd.com, Cao jin , Greg KH , jarkko.sakkinen@linux.intel.com, jgross@suse.com, Josh Poimboeuf , Matthias Kaehlcke , thomas.lendacky@amd.com, Thiebaud Weksteen , mjg59@google.com, joe@perches.com, andrea.parri@amarulasolutions.com, "H. Peter Anvin" References: <20180613210518.113983-1-ndesaulniers@google.com> <20180613210518.113983-3-ndesaulniers@google.com> From: "H. Peter Anvin" Message-ID: Date: Thu, 14 Jun 2018 17:17:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/18 13:59, Nick Desaulniers wrote: > On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin wrote: >> >> On 06/13/18 14:05, Nick Desaulniers wrote: >>> From: "H. Peter Anvin" >>> >>> i386 and x86-64 uses different registers for arguments; make them >>> available so we don't have to #ifdef in the actual code. >>> >>> Native size and specified size (q, l, w, b) versions are provided. >>> >>> Suggested-by: Sedat Dilek >>> Signed-off-by: H. Peter Anvin >>> Signed-off-by: Nick Desaulniers >> >> I still object to Suggested-by: here. Sedat did a correction, which is >> a Reviewed-by:, but unless I'm completely out to sea, there was no >> suggestion on Sedat's part of this; and I had certainly not seen it when >> I wrote the code. > > I'm fine with changing it from a Suggested-by to a Reviewed-by. Can > you do that when you apply the set, or should I send a v6? > I'm not handling patch mechanics for x86 at the moment. -hpa