From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8507035A399 for ; Tue, 24 Mar 2026 09:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774345884; cv=none; b=tmvA7cvuZoCyAyPhRaHA65mCdSOxfg/Qkf4nZw/Np7RNiC41112plgHyjdF6jXMJ+Lje4qgXcTCuQDmKRhU2sfDLuAstkLteZWBKrK3NqG1BsUxGTYbqjM3zyqfdvHf8M/uL5mUO3w0HpoC5FstG+SGBCq6j8/ioL3x6w6NPCvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774345884; c=relaxed/simple; bh=PJdd//Wc6EbL+GSyX3BxvuXT8zmtsHUoR2IXE0iBvbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iagY8NidN9bL3j80WRtYRM9KEyHuuwj8j4T+LgL85FhG18mlarREi0GFupFq8SmoqUWXJBhejUfCJAlZ6uU+y3vsPP0JvMqECC5a6GHYUclFdr3pNx2W1LueMlHs7wa6IjWC344xXtjmo6Hzhohl8rakFys9YbHjYI/dHajHOIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HzCHoPH2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AMW/L91i; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HzCHoPH2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AMW/L91i" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O41cdK1762131 for ; Tue, 24 Mar 2026 09:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zuEm4InrR8PTYNcIHNHYlCNu11l1X/KZ8SAxL2hLrew=; b=HzCHoPH29VN2ts+u k8WjvaZLRS2ZtlkgtUapLSP2BXj7Dr/6hSsv8B5rY3PilRil0oj6FVaO9bAPoZMO sKSsytQGH35bbwnZrZ4o7qPQMcu3w9PVnemyQuBSIoP+Cm/mmjSQ0CoucFTUjbMI Tp6R6TDH/uF1ykEqoUQ/STfgWhiNki0xvsY42pIFH2Go3BNRLft2tKeQVnz3PuOC xI0tSpZiNwsN9qppMGEHO3ppiEb0VHBFFI71EY4h4Aev82nDGnKcYWJiCrFHTkB/ sHnOyfAcS8EBzMYqekhwPpx6+dUvxTpstlRz8VgCmWsEEE7AAWzVEv6FjQZ4I/WF MyB8aQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f0bw7v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 09:51:22 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8954b9b5da7so38799886d6.2 for ; Tue, 24 Mar 2026 02:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774345882; x=1774950682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zuEm4InrR8PTYNcIHNHYlCNu11l1X/KZ8SAxL2hLrew=; b=AMW/L91innh6b9o+187azJ1n7gTmLZpS7ZxLFvvPLANAGfjmg39lG28Fp1RGUgBs7F OyfTBZMk2RyTDtgm8Bq+u/QKZDQkIXcVmRLqA2nuCaK97K7xMcKNdM7gB6mwF5x6i6w/ MuhT3hJQ9Mkm5k15KGAScd1xpa80Z/eMVNlgs42ovnqJrctZtZGUWia+GxshJZKzTOv1 MmjMsGte5QxZvh7K97h6L5k0xZJ5jjqNwntZvTWx8zeJGE5Mo+AF2kWpwdngaqDI5eao CLqcCQ5o1PJzoac6fCsOVyp/lJbQsGfYe1OXZal8MHOUVQVmlS1q3s3hc7oi/Y2RN0P+ nsLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774345882; x=1774950682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zuEm4InrR8PTYNcIHNHYlCNu11l1X/KZ8SAxL2hLrew=; b=N65HARtsqkjz3eIfeZxj3KX5p5sUA0Sxn1vNnmvpPb2crAidDSgwFT1UfasMPw+FOJ v400oZQmhhqX6Z3h4xIpjCn27UQDPxjZQxkyF84H8dQTDvGfC+rZTf/Hl/0puUDcwNOI 1U2So81ssHDL/AyOH+b7wTPKAY61bLFthC9y21Bi6HO1jbr9cdR6b2ZdIT2c1YuCCSG2 FKRAMb3iMHTMTOX/N1BIr4Brdy4E1y/8Tg8w2aTZu3LYUNNk3XU+eMkHFKNiuDH4v5V2 C7oQw3LX9TVIb06r2b7m8nHQvNLn3ZP3lHIUWwdqn9/ZWkeKfQ3Nnhb/MBktB2ItlptN TTCg== X-Forwarded-Encrypted: i=1; AJvYcCUDpB+fsMoWrs6zimSPUbqKEMvvBUbEC7B0J3ud362xcy2H0m0d3JZkxMlsp32WMGEjvKJHPjGnnRoHT4s=@vger.kernel.org X-Gm-Message-State: AOJu0YwEOHQY7CWDeSi8yDSxEp6LRCmn1JQuZ7del8CcEQvZUEp+b8pF 0OKLAeawUDAs0yk3AbxWDUZHFFCFVe1a8OXx3EXk5nK+OYZ1CBegPDQ5uxzuoI8Slcs6zk2YhXS 69Qs83m/LMz8s/6zke5b+RZzb5zanKlp4cC+e3MYldtbVumX1pMHFcvCy8P1IEf4h8t0= X-Gm-Gg: ATEYQzxq1XQFIaFz90j++QbuUOzb0ZJam5z5LN+HIbABi7Vt94wMSAhnu6dvUp2wVz4 qzEsRat4/zJMOaVtf/KX6+muG6ke3r2EiblPwCQM2HAj9SgtmjpnWYmaU2l4VdP9KrD3V8KIS+/ y+C50XQTo7euuBwTyh6POZVWxGNBX6rmiyPogf1C9J425EANHXP6OTjZGs7pdLDgeKuSDG22wF8 pssGWWtx/kC07Uh9bKWICfXWP4YgbreMg+2sy3OsvilV44KYzAOJgTmtnjxI0IGmLPxWQwOoxcz MM3McJvp+DGmRPcZT4PcEKlOD9ntu7LL6/tv/6R9WNNXFCyvev5GmFPT+bU+L8iEJGzRffLyfdz ohmLee3rsEPzZCc5e/+cC+K/C1lGmhk6ZazJYLyZJxuQTjmuZYaBzq0q+woXjEob0kvm2PWKA4R I5WqU= X-Received: by 2002:a05:6214:5293:b0:89a:53f8:2df0 with SMTP id 6a1803df08f44-89c85a61351mr217672386d6.5.1774345881882; Tue, 24 Mar 2026 02:51:21 -0700 (PDT) X-Received: by 2002:a05:6214:5293:b0:89a:53f8:2df0 with SMTP id 6a1803df08f44-89c85a61351mr217672196d6.5.1774345881426; Tue, 24 Mar 2026 02:51:21 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f43bbbsm626014766b.8.2026.03.24.02.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 02:51:20 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 10:51:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] drm/msm/a6xx: Switch to preemption safe AO counter To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-2-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260324-a8xx-gpu-batch2-v1-2-fc95b8d9c017@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c25e9a cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=-1Y_YdnrJnI9lEGYafQA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: TNXENsP6KEW2ItzWV0euufjIPLOtvork X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA3OSBTYWx0ZWRfX7aRwLavi/+Yy eLPslsQ6rIz/VAdm+9wYGLLpw+KGDJOz/4pFFCxM+bAmTGB9yA+BOszR6q4Z4wIkVojjLTI5dKY e0+/5uB/Ak1pcW2frYfJKUt7C8ghEo3daL2c66RYdzT1xpi4b+2WIyp31o6J947uNnYTYYUyvIK q2/enxe8lowFT8VkRusxnejOWTH2nSW+yDq9bznTnLbDx5paINYDL2WkdWjKjHJbFeqqoRNTW67 um0y1Sd8k8toEOaGk3fiu8HHIrN11C/ZOJ4DjJF9X9IQL1WxnZRuWUGJAIrWLbla84pMeZnys8t bnE6Q5lWv55H7eBzqIXnNv4Gw+SqoQqX3fcVUkSbVGnY4+okfhPJ6eIpTnZmBlxAxtIMHNYyCd0 2FJVcV+3AECADQBPXH8jVouLLXZIS0o7CEjY5W/8SI/gyL/bbGA3aLWg62r3E9wedERsINvmf4y PSKLbbdNyc+3yXR2iOg== X-Proofpoint-GUID: TNXENsP6KEW2ItzWV0euufjIPLOtvork X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240079 On 3/23/26 9:12 PM, Akhil P Oommen wrote: > CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't > provide accurate data about the 'submit' when preemption is enabled. > Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. > > Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 14d5b5e266f7..93bf2c40bfb9 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -345,7 +345,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) > * GPU registers so we need to add 0x1a800 to the register value on A630 > * to get the right value from PM4. > */ > - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, > + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, > rbmemptr_stats(ring, index, alwayson_start)); > > /* Invalidate CCU depth and color */ > @@ -386,7 +386,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) > > get_stats_counter(ring, REG_A6XX_RBBM_PERFCTR_CP(0), > rbmemptr_stats(ring, index, cpcycles_end)); > - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, > + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, > rbmemptr_stats(ring, index, alwayson_end)); > > /* Write the fence to the scratch register */ > @@ -478,10 +478,10 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) > > if (adreno_is_a8xx(adreno_gpu)) { > rbbm_perfctr_cp0 = REG_A8XX_RBBM_PERFCTR_CP(0); > - cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_COUNTER; > + cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_CONTEXT; I'm a little worried about mixing the names here - KGSL uses both of these registers (A6XX_KERNEL_PROFILE vs A6XX_KERNEL_PROFILE_CONTEXT) to track different fields of the struct adreno_drawobj_profile_entry Konrad