From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754027AbdEJSB0 (ORCPT ); Wed, 10 May 2017 14:01:26 -0400 Received: from mout.web.de ([212.227.15.4]:53844 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335AbdEJSBZ (ORCPT ); Wed, 10 May 2017 14:01:25 -0400 Subject: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print() From: SF Markus Elfring To: linux-s390@vger.kernel.org, Heiko Carstens , =?UTF-8?Q?Jan_H=c3=b6ppner?= , Martin Schwidefsky , Stefan Haberland Cc: LKML , kernel-janitors@vger.kernel.org References: <4af00744-1c8a-6b33-22c8-d26d569f6c5f@users.sourceforge.net> Message-ID: Date: Wed, 10 May 2017 20:01:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <4af00744-1c8a-6b33-22c8-d26d569f6c5f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3RoFWjp4Kb+HIO6sjh4kesruB3yodi68mLheVBrzYIgjXrXVSpb wDJeiWjrZ8S1hJj9E+JbrdbJWGyfpRh35bVSnv3xQULiK2g9Exs6vPkXLuqyR1NcQqYvCyA 5xp4YqotJpoiFxPQoHp1vkfK3LcSXTE4m5kb5BrRoi5wGmdOqIRJBvPFRlf6DsVR+EcAzTw mgE7jMcQDRCD1tJQn5r7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:jg9XqeAPvQ8=:0vOMJXIKzUrm1KTkXhoDD7 9tUTATsfRd/Y+Q3TYUkZw5Xo/hzimFVM9wpQW8HNlObvZbEELPfKyfs6BA5CgDEeiSv8kVZAS w1cWAJsq7qTy4M8GOQXC+T///Xsb4NeyKLeJPGD2R7FQaohUVEG9A1OiQ9KWSmQLfvVGeUonK x6EgVRSB/Eb1u2XEh8Tdm6mqhH0N4ZnsontNBUr5vbEIK2TtgALSE0cUQulC+Vc0JKYrdjZNf 1DMSZ6XvDLt7RRx6NIeiHNbLcuR0CQ1idmp1m8mQL0SOu/8gm+RqQl1f/SttK0rldWrS19Hbm eaVWfULUD/DGHTGiLnUKywMnDk2Qh+7Gav2R9pooPzDWDXu4WVqJP/nD9wif6ekXYCCKwSaZk 5SwTmtdxuMsJtjGAgQIjjsCzEeOiHzD+Goy80mRc+qmIn6nTn+iPZg9no2jtOikVMUJM+MtS4 M3F6ApB/3AgDVZCZEW8PGu1kGl2z/ENv1+wyC/TeeDGaO1XUWJ77hgjWcwzidCw2IOPRlrra7 9aCaxu5PAH7k4PlLVGffqM4itAUYZs1YB/feORG36Lm+FJFBgd5rofvmWvqP6DZQdpDoxvwSK rsrThZvOrje6dx+9eosZeNitaGULhcKkAGFd+UafThW5THbbbD8FkRqI6gJwqhMvClVIdLFdX Fso+2YcxwY913rpms3mSFWSFmiCt96SPKc6YlQSasO7ndtMZEU85zdoU39zft44H4qCK3pL9V PI29/M6sJtRv1N29ID9rDEIfJPnhYZUmg5ap1COaau8zcDEAmODLEsSorhl8GdFyjzIU5mchC Ytz4XsY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 10 May 2017 18:52:28 +0200 * Use a special format string specification for the desired output of the array "pgid" into a sequence. This issue was detected by using the Coccinelle software. * Delete the local variable "j" and a call of the function "seq_puts" wich became unnecessary with this refactoring. Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support") Signed-off-by: Markus Elfring --- drivers/s390/block/dasd_eckd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c index 122456e4db89..b3709d3cba54 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -5288,7 +5288,7 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m) struct dasd_ckd_path_group_entry *entry; struct dasd_ckd_host_information *info; char sysplex[9] = ""; - int rc, i, j; + int rc, i; access = kzalloc(sizeof(*access), GFP_NOIO); if (!access) { @@ -5308,10 +5308,8 @@ static int dasd_hosts_print(struct dasd_device *device, struct seq_file *m) entry = (struct dasd_ckd_path_group_entry *) (info->entry + i * info->entry_size); /* PGID */ - seq_puts(m, "pgid "); - for (j = 0; j < 11; j++) - seq_printf(m, "%02x", entry->pgid[j]); - seq_putc(m, '\n'); + seq_printf(m, "pgid %*phN\n", + ARRAY_SIZE(entry->pgid), entry->pgid); /* FLAGS */ seq_printf(m, "status_flags %02x\n", entry->status_flags); /* SYSPLEX NAME */ -- 2.12.3