From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AC03B71B6 for ; Sat, 1 Aug 2026 22:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621691; cv=none; b=jqzFIXrVK82GmYtAkGvy/3FX1PX4RZ5C8GirhZwVSd9DSGMXwCIKC7Q519iARNqZ6I8IYCSNRyhhuKgrTBxUZ/ZcaW5uiotFLW3FEIsPH/JdbzUUMwudS1GSh7O/H8D+BKaoS00RDK33qF2kplzP+/CPXn2pmMoxXFg8zKn9Zyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621691; c=relaxed/simple; bh=B1aGoafSodbJHnZvQa4U88gzZAbdOk4anLe8al4k4+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s3C37cEMKSM9o9x/ur+S52iM4Tpva4xQ7EuWb6EGn2/fbpLarZbizx9hALD3jlTS8nxRd3zFJNx4DSsNSUAl4hDQkrYzkCvlVukzQ+rGxK5PqI7NxKSNYrIhGwg6qvjRR2Xg+prZwXF2yQxva/GJFOHER1a+RCqQ3I9HKlVWCIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PNVHRsXU; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNVHRsXU" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-8114a4542b2so33656787b3.1 for ; Sat, 01 Aug 2026 15:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785621684; x=1786226484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fFKjhKiLwW7000gY04FDp9HuhYK5pnv34+ERWpP83n8=; b=PNVHRsXUp0XCXnD8Q+OJb7MgdABLPwXgxvpcqQWg4VuxEPmBLymrH5x1rcy08o+/9t ZGNL91aWrTxK+/zmIESs8niMIAbrmnsJ8IdweXdnxfTINbPcwllz9HQzaDWZUf/lpUyG CG76ga41gnn4KB8Fp5Qfbb4MrLbyOft7dCNVuLy/jKpiqPKmywoBG3iJSi4pn0Ndk+MW Z9jHubiQBK9UUscfGZ5iX9eEoUMaASP7WwczxwGJyUQdAIZ7yErDlmdI7JpkNaFHzj0r gqJESLFvRnPXoH3zZPAy8K9Ue2PTHvhTBwBPpHDYQpMsDszYEefsqIvEQRkDBVRFKnVs Imdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785621684; x=1786226484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fFKjhKiLwW7000gY04FDp9HuhYK5pnv34+ERWpP83n8=; b=H/bVrGbl5sOHOXjG+SLoFCKp2GbAPFhQnU2pCDC71kxM0amQWHS2tCIUqwLs5wQOxG zSz4rHowRhCxke/zBeFV4XnwhxFFZYeQ1NYOkqqE2Vju+bIx2eIA8fAkTjwAbB+l3WiB BumKc5fIQE199fw6V/z5aO3ulw+/zR3hKK17W7tykAxV0zAr+foTSFezp5Dd/B7C6Imm zrOCX2Qzh0KbXC9BAADS4LzBXjwpt1lE+vzaymertkI/P+u4e05urh1jjrZLovN7Qnjq JS1tXmyWedSg7Ojcn9CiKv2EBMq9/WBxE67ctgxt8igkQ9s4dAL8fZ9wlptHNqm4cwJo ZnYQ== X-Forwarded-Encrypted: i=1; AHgh+RpjBnZgUAlNRB2xHxITXlVIiGpcIEvH0gCa3Dd32VbqR8bQBVV8805RZCZC9RCM9CkE6bJWZVjk7qcEgkw=@vger.kernel.org X-Gm-Message-State: AOJu0YxDUuR/bdXTq+igh9c8H98Uepai8uAJp1s+1Zmas5yJcTJ0LcXV bQC7wVwqBI34N3G+g6E6j/Efe6HPe01wdwpQSJlM8U5pqgYCKapZahrj X-Gm-Gg: AR+sD12+UXYrN3bk8S1ki116PNNAwdfJkwSaLvSj166x5jP6ngwGzybuyAqHTrwGIRP oMApYyb7tC2L2OiEHLwv+a3jdUTHW+war7acV3yDTy1PiEqxIX8erWUnfevsNZi0xO84+fLLF6+ v0lcdUq+zcxyjlPcKMSgjrJFk1n8v1xu7Fw7qVvT99m/gLCIkDWtjibsHVQL7O667et8UMyj4Ky bRzFEAXI6bi+lbQ9aP/4O6W5vhx8WqsTGRTwZn3Vwnh7H/rDIGbdqWZKUahFrqV1KhPduF/PZs7 e9QNe6+FTBrB3IaKjK1Nnc03qXdzexn+dTFSbPL3NTkgPYiYZ4+s155KBA6wnYCQh9Hbp+pZXwH /dkiwJGsPcNCBReoUYdzzUYUaZ4KFwAGouzWAvIsyPaHI8wiMT+PfLVns40Tz77suNkisTqj+KW pheyjg57M8OL++O1vzwJMQ1udXQCiWOxbBnbgLDoeaK+RKTQIuz3wT1CquukniAggPp+zL51hPB 7hNBdg= X-Received: by 2002:a05:690c:d8f:b0:80d:a249:4854 with SMTP id 00721157ae682-81fd4b59a06mr68933057b3.17.1785621683893; Sat, 01 Aug 2026 15:01:23 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd0d6fbbsm29903767b3.25.2026.08.01.15.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:01:23 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Shi Subject: [PATCH 10/19] exfat: check for a directory write error with buffer_write_io_error() Date: Sat, 1 Aug 2026 18:00:54 -0400 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit exfat_update_bhs() waits for the writes it issued and then tests !buffer_uptodate() to find the ones that failed. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. Test BH_Write_EIO, which is what the completion handler sets and what this code actually wants to know. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Signed-off-by: Chao Shi --- fs/exfat/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/exfat/misc.c b/fs/exfat/misc.c index 6f11a96a4ffa..dfd0bbf31c94 100644 --- a/fs/exfat/misc.c +++ b/fs/exfat/misc.c @@ -187,7 +187,7 @@ int exfat_update_bhs(struct buffer_head **bhs, int nr_bhs, int sync) for (i = 0; i < nr_bhs && sync; i++) { wait_on_buffer(bhs[i]); - if (!err && !buffer_uptodate(bhs[i])) + if (!err && buffer_write_io_error(bhs[i])) err = -EIO; } return err; -- 2.43.0