From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C5BC433FE for ; Thu, 10 Dec 2020 05:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F25D23B98 for ; Thu, 10 Dec 2020 05:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727934AbgLJF2T (ORCPT ); Thu, 10 Dec 2020 00:28:19 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:41592 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbgLJF2T (ORCPT ); Thu, 10 Dec 2020 00:28:19 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BA5RQkx028286; Wed, 9 Dec 2020 23:27:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607578046; bh=wcps/Y8Os9Y3CDLlV7380+d6JPtTFkhrHuzTjkXqp4g=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=W1eHfXk1KUIkxqUEpn+jEvPea408QOJAP9ADdWVun5Mz4Il8pU742OaGt3haaC8kR jBN5KyVlbghS9VhftLCwDC0XmPX852CXQnPSDD8OsYoBOVOsvqwRsJnCUEZ9T25pmm EH1pSzeqlwNRN+7ZMz8ej9Hzp4ejDmq4VYD1ALYo= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BA5RQ52061561 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Dec 2020 23:27:26 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 9 Dec 2020 23:27:26 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 9 Dec 2020 23:27:26 -0600 Received: from [10.250.232.169] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BA5RIn0094657; Wed, 9 Dec 2020 23:27:21 -0600 Subject: Re: [EXTERNAL] Re: [PATCH] dt-bindings: usb: Add new compatible string for AM64 SoC To: Rob Herring CC: Sekhar Nori , Greg Kroah-Hartman , Roger Quadros , , , References: <20201209165733.8204-1-a-govindraju@ti.com> <20201209165733.8204-2-a-govindraju@ti.com> <20201209193417.GB807821@robh.at.kernel.org> From: Aswath Govindraju Message-ID: Date: Thu, 10 Dec 2020 10:57:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201209193417.GB807821@robh.at.kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, On 10/12/20 1:04 am, Rob Herring wrote: > On Wed, Dec 09, 2020 at 10:27:32PM +0530, Aswath Govindraju wrote: >> Add compatible string in j721e-usb binding file as similar USB subsystem >> is present in AM64. >> >> Signed-off-by: Aswath Govindraju >> Acked-by: Roger Quadros >> --- >> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml >> index 388245b91a55..05d976bb06d0 100644 >> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml >> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml >> @@ -11,8 +11,11 @@ maintainers: >> >> properties: >> compatible: >> - items: >> - - const: ti,j721e-usb >> + anyOf: >> + - items: >> + - const: ti,j721e-usb >> + - items: >> + - const: ti,am64-usb > > Use 'enum'. > Thank you for the comments. I used anyOf to mention that the compatible strings can be either used separately or together in the DT files after referring [1]. Using enum brought in constraints such as if one compatible string is used the other cannot be used. The error that I made was use of '\t' at the start of the lines. I will correct it and send a respin. [1]https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml Thanks, Aswath >> >> reg: >> description: module registers >> -- >> 2.17.1 >>