From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACADFEDE9A4 for ; Thu, 14 Sep 2023 10:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233017AbjINKjk (ORCPT ); Thu, 14 Sep 2023 06:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjINKjh (ORCPT ); Thu, 14 Sep 2023 06:39:37 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A1A201BF0; Thu, 14 Sep 2023 03:39:32 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 80A351FB; Thu, 14 Sep 2023 03:40:09 -0700 (PDT) Received: from [10.1.29.46] (unknown [10.1.29.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73FD23F738; Thu, 14 Sep 2023 03:39:27 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 11:39:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 3/3] perf pmu: Remove unused function To: John Garry , linux-perf-users@vger.kernel.org, irogers@google.com, acme@kernel.org Cc: Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Haixin Yu , Jing Zhang , Eduard Zingerman , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230913153355.138331-1-james.clark@arm.com> <20230913153355.138331-4-james.clark@arm.com> <5976613f-8c7b-81a8-3200-9f0603f90743@oracle.com> Content-Language: en-US From: James Clark In-Reply-To: <5976613f-8c7b-81a8-3200-9f0603f90743@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/2023 07:41, John Garry wrote: > On 13/09/2023 16:33, James Clark wrote: >> pmu_events_table__find() is no longer used so remove it and its Arm >> specific version. >> >> Reviewed-by: Ian Rogers >> Signed-off-by: James Clark >> --- > > You really should put the name of the function in the subject. Apart > from that: > > Reviewed-by: John Garry > Noted, will do next time. Thanks for the reviews. >>   tools/perf/arch/arm64/util/pmu.c | 10 ---------- >>   tools/perf/util/pmu.c            |  5 ----- >>   tools/perf/util/pmu.h            |  1 - >>   3 files changed, 16 deletions(-) >> >> diff --git a/tools/perf/arch/arm64/util/pmu.c >> b/tools/perf/arch/arm64/util/pmu.c >> index 3099f5f448ba..2a4eab2d160e 100644 >> --- a/tools/perf/arch/arm64/util/pmu.c >> +++ b/tools/perf/arch/arm64/util/pmu.c >> @@ -24,16 +24,6 @@ const struct pmu_metrics_table >> *pmu_metrics_table__find(void) >>       return NULL; >>   } >>   -const struct pmu_events_table *pmu_events_table__find(void) >> -{ >> -    struct perf_pmu *pmu = perf_pmus__find_core_pmu(); >> - >> -    if (pmu) >> -        return perf_pmu__find_events_table(pmu); >> - >> -    return NULL; >> -} >> - >>   double perf_pmu__cpu_slots_per_cycle(void) >>   { >>       char path[PATH_MAX]; >> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c >> index f50a5636633f..0d81c059c91c 100644 >> --- a/tools/perf/util/pmu.c >> +++ b/tools/perf/util/pmu.c >> @@ -776,11 +776,6 @@ char *perf_pmu__getcpuid(struct perf_pmu *pmu) >>       return cpuid; >>   } >>   -__weak const struct pmu_events_table *pmu_events_table__find(void) >> -{ >> -    return perf_pmu__find_events_table(NULL); >> -} >> - >>   __weak const struct pmu_metrics_table *pmu_metrics_table__find(void) >>   { >>       return perf_pmu__find_metrics_table(NULL); >> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h >> index d7b46085642d..04b317b17d66 100644 >> --- a/tools/perf/util/pmu.h >> +++ b/tools/perf/util/pmu.h >> @@ -238,7 +238,6 @@ void pmu_add_cpu_aliases_table(struct perf_pmu *pmu, >>                      const struct pmu_events_table *table); >>     char *perf_pmu__getcpuid(struct perf_pmu *pmu); >> -const struct pmu_events_table *pmu_events_table__find(void); >>   const struct pmu_metrics_table *pmu_metrics_table__find(void); >>     int perf_pmu__convert_scale(const char *scale, char **end, double >> *sval); >