From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, NXP S32 Linux <s32@nxp.com>,
imx@lists.linux.dev, Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>,
Eric Chanudet <echanude@redhat.com>
Subject: Re: [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support
Date: Fri, 4 Apr 2025 09:15:13 +0200 [thread overview]
Message-ID: <dec769ad-5144-4503-9714-d9c83a4c242c@kernel.org> (raw)
In-Reply-To: <6ebb8c15-9ff1-4bf3-bbf3-c91aa387d873@oss.nxp.com>
On 04/04/2025 08:24, Ciprian Marian Costea wrote:
> On 4/4/2025 9:17 AM, Krzysztof Kozlowski wrote:
>> On 03/04/2025 12:33, Ciprian Costea wrote:
>>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>>
>>> The RTC hardware module present on S32G based SoCs tracks clock time
>>> during system suspend and it is used as a wakeup source on S32G2/S32G3
>>> architecture.
>> Which boards are using it? I don't see any DTS (nowhere), so I do not
>> see single reason for this patch.
>>
>> Best regards,
>> Krzysztof
>
> The RTC module is used by all the currently supported S32G2/S32G3
> boards, so currently they are: S32G274A-EVB, S32G274A-RDB2, S32G399A-RDB3.
I don't think so. I looked at these DTS and there is no RTC.
> I do see your point in the fact that this driver should be enabled as
> module only after platforms are actually using it.
No, post the user. I don't see the point of sending defconfig patch with
RTC patchset anyway. That's different subsystem.
>
> So, would it be better for me to send a V10 in this series with the DTS
> patch added ?
No, separate patchsets.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-04 7:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 10:33 [PATCH v9 0/4] add NXP RTC driver support for S32G2/S32G3 SoCs Ciprian Costea
2025-04-03 10:33 ` [PATCH v9 1/4] dt-bindings: rtc: add schema for NXP " Ciprian Costea
2025-04-03 10:33 ` [PATCH v9 2/4] rtc: s32g: add NXP S32G2/S32G3 SoC support Ciprian Costea
2025-04-09 14:14 ` Enric Balletbo i Serra
2025-04-09 14:26 ` Ciprian Marian Costea
2025-04-09 14:42 ` Enric Balletbo i Serra
2025-04-09 14:58 ` Ciprian Marian Costea
2025-04-10 7:08 ` Enric Balletbo i Serra
2025-04-11 8:09 ` Ciprian Marian Costea
2025-04-03 10:33 ` [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support Ciprian Costea
2025-04-04 6:17 ` Krzysztof Kozlowski
2025-04-04 6:24 ` Ciprian Marian Costea
2025-04-04 7:15 ` Krzysztof Kozlowski [this message]
2025-04-04 7:19 ` Ciprian Marian Costea
2025-04-04 8:53 ` Alexandre Belloni
2025-04-04 11:36 ` Ciprian Marian Costea
2025-05-20 9:01 ` Ciprian Marian Costea
2025-04-03 10:33 ` [PATCH v9 4/4] MAINTAINERS: add NXP S32G RTC driver Ciprian Costea
2025-05-25 21:33 ` (subset) [PATCH v9 0/4] add NXP RTC driver support for S32G2/S32G3 SoCs Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dec769ad-5144-4503-9714-d9c83a4c242c@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=aruizrui@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=ciprianmarian.costea@oss.nxp.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®