mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Almeida <dwlsalmeida@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.o,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: vidtv: add initial debugfs interface
Date: Wed, 27 Jan 2021 09:26:52 -0300	[thread overview]
Message-ID: <ded2b580-be92-e309-28ca-fc6635a3af4f@gmail.com> (raw)
In-Reply-To: <20210127120623.7f018471@coco.lan>

Hi Mauro! Thanks for the review.


Just one more thing though: what did you think about the way I chose to 
inject the errors? (e.g. drop packet, shift bytes, create 
discontinuity...etc etc)

I was just trying out a few ideas in this patch so if you also have any 
input on this please let me know.

As of now writing to any of these files will cause a myriad of errors on 
dvbinspector.


>> +
>> +#. dynamically inject errors at runtime by interacting with the files at /sys/kernel/debug/vidtv/*
>> +
>> +#. read some dvbv5 statistics from userspace more easily
>> +
>> +.. note::
>> +	This is entirely optional and the driver will work without this option selected.
> Please keep lines <= 80 columns, except when there's a strong reason to
> use longer lines. The same applies to other parts of this patch.
>
I was under the assumption that this had been bumped to 100 recently.


-- thanks

-- Daniel



      reply	other threads:[~2021-01-27 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 15:04 Daniel W. S. Almeida
2021-01-27 11:06 ` Mauro Carvalho Chehab
2021-01-27 12:26   ` Daniel Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ded2b580-be92-e309-28ca-fc6635a3af4f@gmail.com \
    --to=dwlsalmeida@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.o \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®