From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Connor Abbott <cwabbott0@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0
Date: Mon, 25 Nov 2024 18:17:50 -0800 [thread overview]
Message-ID: <ded82fed-3866-40ae-9970-53e238cab125@quicinc.com> (raw)
In-Reply-To: <20241123-msm-mdss-ubwc-v2-2-41344bc6ef9c@linaro.org>
On 11/22/2024 9:44 PM, Dmitry Baryshkov wrote:
> Follow other msm_mdss_setup_ubwc_dec_nn functions and use individual
> bits instead of just specifying the value to be programmed to the
> UBWC_STATIC register.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 17 +++++++++++++----
> drivers/gpu/drm/msm/msm_mdss.h | 1 -
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
Same comment as patch 1 but rest LGTM, will ack this one once we decide
on patch 1.
next prev parent reply other threads:[~2024-11-26 2:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 5:44 [PATCH v2 0/3] drm/msm/mdss: rework UBWC registers programming Dmitry Baryshkov
2024-11-23 5:44 ` [PATCH v2 1/3] drm/msm/mdss: define bitfields for the UBWC_STATIC register Dmitry Baryshkov
2024-11-26 2:03 ` Abhinav Kumar
2024-11-26 12:17 ` Dmitry Baryshkov
2024-11-23 5:44 ` [PATCH v2 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0 Dmitry Baryshkov
2024-11-26 2:17 ` Abhinav Kumar [this message]
2024-11-23 5:44 ` [PATCH v2 3/3] drm/msm/mdss: use boolean values for macrotile_mode Dmitry Baryshkov
2024-11-26 2:19 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded82fed-3866-40ae-9970-53e238cab125@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=cwabbott0@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®