From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA72940C5DD for ; Tue, 9 Jun 2026 12:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008762; cv=none; b=a67uyWCaHe79TV+J3b0lCb2OCkdGajdyjZzvv0vnV7YAs1BshebBRRJymbKBRBedp0ytYPVFU+5GOcBT5DHq12AQZTcY03YWaBjtGcDt1ZqVqwa94p737mTTa/0PgSdELUzxwOr5HkqxfE2alQUIaumv8eC9k24MMNYJpD1+T28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008762; c=relaxed/simple; bh=uzmarCe4XTY8E2ARGmW6Wi4BS5LtexkBsDruj0PTMj8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=quuV6rOLaZpumKD5wr8SZzAUb5FZ86UmBHUWOYXY70ofKFXx/IJLG/BAiYbFDrnM/V7fMYF/CQh9SOIgqrVv73pHy7FCjmTTKoiGF1XCxTY2A1lphKimflg+kZ0oxoJt9JmmuuG4BthkcyRLu50vLbeG8XkmH3VhQpHdfj6Aesc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KF6bMPg/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pb7YU/CJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KF6bMPg/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pb7YU/CJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781008761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8CMayqFcy6bn6oa/uOvParTwIAVjEw6ftY4OO10cCak=; b=KF6bMPg/MaK1wvPHP2iumrMSexAFFvl+wMf5LRB9HbZf3GLvgF2TjVOnW7SIDzx5vTj0KT JywQbZ21+F44pvBDSsL7ZxCgdHep2htM5M06yhSmQYSBDJnDxcHXt526brLl2sMPbjmKKl VgO4FdmD5XbHjjHP6DIRzKrbBfDh3P0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-iboGeXACPWqRrpo748lMmg-1; Tue, 09 Jun 2026 08:39:19 -0400 X-MC-Unique: iboGeXACPWqRrpo748lMmg-1 X-Mimecast-MFC-AGG-ID: iboGeXACPWqRrpo748lMmg_1781008758 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490bae3a39bso51953415e9.1 for ; Tue, 09 Jun 2026 05:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781008758; x=1781613558; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8CMayqFcy6bn6oa/uOvParTwIAVjEw6ftY4OO10cCak=; b=Pb7YU/CJS0prpgtjAhE796NMxTsagu27PwGBPps39VBg6in5+HxEJP5wrsPeADLioB E9W1IrsP5OAz3y9J5YU90qUHx1wq0J6bw4M1z/YKJU688e+Lty6fqc+eFMy6kJxSNyjx qWnh2PRxZKX4ZEQd7loXL2Hf5XoBqXDW27AIhJe6f8ned2lNnvIMc1wxd7T21p70lGRK xpldZcNvRrr0Yw1jOzvnTKpQqWEmu/AGXYUv+So7ojTGKZE3pp4EM2+tqt+pQCMlmXFC Sx/Mn1Drv4d+ntEReV8hsPAmdZhlCRWsf9nXbbL8VZ18331f80EXCIcSTEHqhkrXTzbx V9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781008758; x=1781613558; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8CMayqFcy6bn6oa/uOvParTwIAVjEw6ftY4OO10cCak=; b=Nyq18/EMUbu5WWIq+z47btR9Om+4/P7jDc3Spxd8stx94voyLiAmPHpmJbjjmMuH0E Ypm8aIOruODaT3jX58zqq3u0DaS7rnduU5LfCuHYz8uz8bAMF3SLRAn6IaY9eZZ1LfHF 9wt0kt1f5bJbSu2gCVq/J7jym7kBpoPELFAl6fTATpG0bqwZmtOPff9NvsuCQYEF34ZP iryxFXpfeiMESGwCzoUyBmemRW9jbh4H/UvjUqWfmd57BMCMDujXR04hYEgsHeWpTGDD MYjT/dbUE7dXh4eNScJQeryS7jfLouqcbmgXUmoARpndKcSzmMuJI4fPl6mSElvkbtRZ E95A== X-Forwarded-Encrypted: i=1; AFNElJ/CzjcaOgSJfzGJQimXP/Qi1P9GfB344f4PcxcRYAJh1ogBPFjM7DyaQKGOqoFG3vXdr03g60S+XXPb9RM=@vger.kernel.org X-Gm-Message-State: AOJu0YycS7BzdWaPhDul7RkD0EHUDqRyGOd0M5FYtd93f617FF/21/+G 3qWFL1TY/Eyg6bF/mRrrVqkoMceY44iNVd6acPUfWzcQT2u5HeE4YfmPL3waIqVRYoqkk9/X/uS 9U+SwdaPp5VUypNBLl7S3omtxuFIVvMRqeHF+s5TH5MvuvEo05v4q9U8TbMY80ZT0R14B85ZTyQ == X-Gm-Gg: Acq92OGKwto9M7pTPZlK6EGOT67e2rZuKMiQVhlBgZ3a7LeoBmDeazFtscHSa4q/wds j54KfFqAd9ODO2AX5MfhmgKoybfFTmPCJb166GvbCLYOLuY5jblcpZ0qRR/nVcgYQQCT2zLd/Me ZPBE/dSDTm44hUsW8LD+82ptQD0U1HO+eMGWbaWDzcqyOWnRPRKhk/SPFuSsSYCxuueDGVVyQru 9MuxSmnLJgxTgmM+jPWXkPjIqD27fxgYza9cej9MEf9cFlVLJ+ph493qJ48b36X7eAhHIYA9H0s OtTnuTYvWcbEpbxlkvMhChhzFcdvLsi8ph/NdFdNLvsVr6EhdazDcgMaKL48n89dVXUxgI/CgOQ iup5z8VI0Q3EhWnUNR4o81Zzgd15un9rL1jl8 X-Received: by 2002:a05:600c:528c:b0:490:cdb2:fb5e with SMTP id 5b1f17b1804b1-490cdb2fd19mr160784455e9.22.1781008758225; Tue, 09 Jun 2026 05:39:18 -0700 (PDT) X-Received: by 2002:a05:600c:528c:b0:490:cdb2:fb5e with SMTP id 5b1f17b1804b1-490cdb2fd19mr160784015e9.22.1781008757834; Tue, 09 Jun 2026 05:39:17 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f360bd6sm66272108f8f.36.2026.06.09.05.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 05:39:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 05/13] verification/rvgen: Convert __fill_setup_invariants_func() to Lark From: Gabriele Monaco To: Nam Cao Cc: Steven Rostedt , Wander Lairson Costa , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 09 Jun 2026 14:39:16 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-08 at 10:57 +0200, Nam Cao wrote: > +=C2=A0=C2=A0=C2=A0 def __parse_invariant(self, inv): > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # by default assume the timer= has ns expiration > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clock_type =3D "ns" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if inv.unit =3D=3D "j": > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clock= _type =3D "jiffy" > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 env =3D inv.env + self.enum_s= uffix > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 val =3D inv.val.replace("()",= "(ha_mon)") > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 match inv.unit: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case = "us": > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 val *=3D 10**3 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case = "ms": > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 val *=3D 10**6 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case = "s": > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 val *=3D 10**9 > + I need to add a test case for this.. You can check by using something like = 5 us in stall.dot in place of threshold_jiffies. val is a string, doing val * 1000 repeats the string 1000 times in python! We need to convert it like we do in __adjust_value(). Something like: diff --git a/tools/verification/rvgen/rvgen/dot2k.py b/tools/verification/r= vgen/rvgen/dot2k.py index a080b92334..4d39f229c9 100644 --- a/tools/verification/rvgen/rvgen/dot2k.py +++ b/tools/verification/rvgen/rvgen/dot2k.py @@ -244,7 +244,11 @@ class ha2k(dot2k): clock_type =3D "jiffy" =20 env =3D inv.env + self.enum_suffix - val =3D inv.val.replace("()", "(ha_mon)") + try: + val =3D int(inv.val) + except ValueError: + # it's a constant, a parameter or a function + val =3D inv.val.replace("()", "(ha_mon)") =20 match inv.unit: case "us": Thanks, Gabriele