From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19AC936A356 for ; Tue, 16 Jun 2026 14:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781621895; cv=none; b=dlf0qPh2uXAS6oKgd11y7//QVWhTCcevLaXLRQ9VwIEVmsuUeamJPBIw3DrIhBqkY4ok3CSHva3qHx7FrETnhsuaqC9iTSRtUVQVVT8jUH4WOpBILjcTnkOTy+8lmcqFLHxwREuigggYOBmjZwvJBr51d1MgSTcxGBgmaiU6G44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781621895; c=relaxed/simple; bh=GBbcQ+Dtt+zE/oTQ3XdqrKLWF5yDHnAfA8BhdK5uzNU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Pqps7Em4fwnxvBAiDZ4epTI9+nQCkUplcT3B7dBb5h92+eoa8IK+5aFCDYcYqixazRCkB/CaJ4KnLYb3NL6UNRG2wwv1FaSM1dF98Q+EuOk5/K75pqtqjSA38WNrYB9mAe8ffAF9E4zvCKg5/2U9NvK9tm/gU31nzDzC//qg04o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Klap4WyM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jButqoTw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Klap4WyM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jButqoTw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781621892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wY21a+SJ61/cTr41m/qL4v3KzKPZfdNGeLnZZdtyStU=; b=Klap4WyMyC4fLneH5DzXHJMvMJjcIVGeG0vlVoYz1A0z/A16FDTVGKx0yccB0PXDpktQqP I7on1JJ80kWvma42VhXY75nDbBtT4yeze6NHJcYf0C3xnqA70AlZHH78NeRtOqFRAWZsls oK+TP37WZv8vifxtrcFPMbxTLtaT3Ik= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-kooZPx6BNq65y7Wg6PWqVg-1; Tue, 16 Jun 2026 10:58:10 -0400 X-MC-Unique: kooZPx6BNq65y7Wg6PWqVg-1 X-Mimecast-MFC-AGG-ID: kooZPx6BNq65y7Wg6PWqVg_1781621890 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-46010392f89so4864488f8f.2 for ; Tue, 16 Jun 2026 07:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781621889; x=1782226689; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wY21a+SJ61/cTr41m/qL4v3KzKPZfdNGeLnZZdtyStU=; b=jButqoTwf0q7xI9fpkUUlp8PJJdjzl35xtxIF8t93WXG4L7J/XL2A8ULUxMDbDdigK oQW9sTb8xJmdCBJcYaz94SMlu1C8lx7kbCzCKB1sKxbvxkMOKkur7mZLhGxCJDuXBm5M afJoyc8dFjhJwH3HAYXHq/1Y74cOkWLrtFdP4GE3JXFuebtVXoesE5cbWnC/Mrom3OOm 3EVJ2fdKYYPIjXmoDqHcdvdF4NAcj6wa/3V/ARLMJk1Oqgt6eUaTc7scbD0tMQrVgb0u 9tQNIeMUShKeeYQscw/V4Zef3VfJbOGtzjeHJWkjB1X2qB7lf1CoHVgHp/qPIaZZIuUs YMwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781621889; x=1782226689; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wY21a+SJ61/cTr41m/qL4v3KzKPZfdNGeLnZZdtyStU=; b=BDCJkWyNU3qTOYOcRJYZp5ojNQjbuhUtSPxGfmfSsZRekLjNxmtQWY3LrNd6LlQiEe +MPKdYwCBmaHTF4LyteO6xRmGXS8fSfbFFYZU247Byd4nosBK/5DFEAvp5I0lRtIKjvt XGM5cAA5eAhadca+JdvP3L/M3i6ZWJbbvxtzjByrW+zRkqZwuB3FeAdJu63BedZ8nMxP KBM6MUGQEwx8CYNlpyZvQuYUssuiryA2rMC/JiwuNboIU8lZZvNRxsSWnvKhTc0IRgKi tSHsBphvATD1xY68K6vnxD7yqLY/iv8t+8xSFHvy4YfOKbqxnagR1eCv20wm2r0tUvA+ CHEA== X-Forwarded-Encrypted: i=1; AFNElJ9zUdRwBKpaXUGiNTxVf9ctOvOSFy3F478HAY7WjgBi6mXpfOa1FY2WNjBZBe9eQh8abGdnHBrk25NfyKI=@vger.kernel.org X-Gm-Message-State: AOJu0YwWSupPPm+dqsljjI5UZs67GhKiRp+jK6oKHRtH9vSWlDTjgMOD GrRI4pRGj0adnf7xqFOUp4Doc3DNztm9u9zUXc1Tb9Xl+/FqZJWAemH73dzdapwgd/VRITr4kTF 5YiShjAd5eqf1bc3aoYs9QVRjtwEXW5/d6oU0pXup+ilqhztxZnmALNfDQexCgt7OUwOSHZCM1w == X-Gm-Gg: Acq92OGFOdU3KHA0B3f8+I+ptLzHUb1E1HHQyaOGhhleT6K8J94dwUKy+O+Alf1jps0 8xy0b3Hhn7c1FJY6kuDqfY5INunuIYa/E7ndtO3QO4BmcivT9n9H6IhpnWUOsxobZcqODctjeex Qlld8O9ymlJIaaeiUygrHyjiMc4CyxV3B8Y+Ul1KZiBxoRhl6G45H3pO0HdefMNpDeqpwRn9Gw8 Qc4klCXrKcQOquaFiNpuQ0Qrigwu65VZnkJafIgpssJDnVN6k2I3VnUZYXuDUM4e0kMjVU+R1zp tzjMoQXMim5Jk5nhwE4/tef/wTkLGKNR+hjCYKCmuuR5gzztKzQbbsAdr+CCgKmEyC9yrjBjWCz vCje3jUURUXsHT0YBMprUxnWifA== X-Received: by 2002:a05:6000:490e:b0:45e:739b:3e3c with SMTP id ffacd0b85a97d-4606da10952mr26129817f8f.0.1781621889107; Tue, 16 Jun 2026 07:58:09 -0700 (PDT) X-Received: by 2002:a05:6000:490e:b0:45e:739b:3e3c with SMTP id ffacd0b85a97d-4606da10952mr26129573f8f.0.1781621887250; Tue, 16 Jun 2026 07:58:07 -0700 (PDT) Received: from [192.168.1.167] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2c3782sm40350946f8f.25.2026.06.16.07.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 07:58:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 9/9] selftests/verification: add tlob selftests From: Gabriele Monaco To: wen.yang@linux.dev Cc: Steven Rostedt , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 16 Jun 2026 16:58:05 +0200 In-Reply-To: <4aeb668c8446a9f6366d92e218df386bef7bc965.1780847473.git.wen.yang@linux.dev> References: <4aeb668c8446a9f6366d92e218df386bef7bc965.1780847473.git.wen.yang@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-08 at 00:13 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > Add selftest coverage for the tlob uprobe monitoring interface under > tools/testing/selftests/verification/. >=20 > test.d/tlob/ contains both the helper sources (tlob_target, tlob_sym) > and the seven test scripts so the test suite is self-contained. > tlob_target provides busy-spin, sleep, and preempt workloads; > tlob_sym > resolves ELF symbol offsets for uprobe registration. >=20 > Seven test scripts exercise uprobe binding management, budget > violation > detection, and per-state time accounting (running_ns, waiting_ns, > sleeping_ns). >=20 > Signed-off-by: Wen Yang > --- > =C2=A0.../testing/selftests/verification/.gitignore |=C2=A0=C2=A0 2 + > =C2=A0tools/testing/selftests/verification/Makefile |=C2=A0 19 +- > =C2=A0.../verification/test.d/tlob/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 20 ++ > =C2=A0.../verification/test.d/tlob/test.d/functions |=C2=A0=C2=A0 1 + Tests seems to work fine, thanks. I think I'm getting what you're trying to do and probably defining a dummy functions for tlob isn't the right thing to do. ftracetest --rv doesn't quite work with different folders as you'd pick the ftrace functions. We shouldn't be adding a dummy functions script every time but rather fix ftracetest directly. Try the attached patch, it seems to work on my side. Then you'd be able to use ftracetest --rv as you please (folder is mandatory, I don't think we need a version inside selftests/verification, verificationtest-ktap is only meant for the makefile just like ftracetest-ktap). Thanks, Gabriele --- >From 32242f83af8214a51c47167a1904d3663aa43870 Mon Sep 17 00:00:00 2001 From: Gabriele Monaco Date: Tue, 16 Jun 2026 16:26:53 +0200 Subject: [PATCH] selftests/tracing: support flexible helper functions Target directory or file arguments passed to ftracetest had to contain their own nested test.d/functions files to properly override the top-level directory (TOP_DIR). This works for standard ftrace tests that would fall back to ftrace's functions, but doesn't for rv tests. Introduce find_functions() to recursively check parent and grandparent directories of the target test directory/file to dynamically locate the appropriate root functions config. This allows to define additional directories for rv selftests and run them with the appropriate rv functions: ftracetest --rv tools/testing/selftests/verification/test.d/ Signed-off-by: Gabriele Monaco --- tools/testing/selftests/ftrace/ftracetest | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/self= tests/ftrace/ftracetest index 0a56bf209f..5d1b1f9380 100755 --- a/tools/testing/selftests/ftrace/ftracetest +++ b/tools/testing/selftests/ftrace/ftracetest @@ -80,6 +80,23 @@ find_testcases() { #directory echo `find $1 -name \*.tc | sort` } =20 +find_functions() { # [directory] [test_cases] + local BASE_DIR=3D"$1" + if [ -f "$1" ]; then + BASE_DIR=3D"`absdir $1`" + elif [ ! -d "$1" ]; then + return + fi + + if [ -f "$BASE_DIR"/test.d/functions ]; then + echo "$BASE_DIR" + elif [ -f "$BASE_DIR"/../test.d/functions ]; then + abspath "$BASE_DIR"/.. + elif [ -f "$BASE_DIR"/../../test.d/functions ]; then + abspath "$BASE_DIR"/../.. + fi +} + parse_opts() { # opts local OPT_TEST_CASES=3D local OPT_TEST_DIR=3D @@ -159,7 +176,8 @@ parse_opts() { # opts if [ -n "$OPT_TEST_CASES" ]; then TEST_CASES=3D$OPT_TEST_CASES fi - if [ -n "$OPT_TEST_DIR" -a -f "$OPT_TEST_DIR"/test.d/functions ]; then + OPT_TEST_DIR=3D"`find_functions $OPT_TEST_DIR $OPT_TEST_CASES`" + if [ -n "$OPT_TEST_DIR" ]; then TOP_DIR=3D$OPT_TEST_DIR TEST_DIR=3D$TOP_DIR/test.d fi --=20 2.54.0