From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751073AbeAVHAc (ORCPT ); Mon, 22 Jan 2018 02:00:32 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43016 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbeAVHAa (ORCPT ); Mon, 22 Jan 2018 02:00:30 -0500 Subject: Re: [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe() To: SF Markus Elfring , linux-input@vger.kernel.org, Dmitry Torokhov , Florian Echtler , Johan Hovold , Martin Kaltenbrunner Cc: LKML , kernel-janitors@vger.kernel.org References: <122986b6-b7f2-9b34-b11d-4d63557a2b97@users.sourceforge.net> From: Martin Kepplinger Message-ID: Date: Mon, 22 Jan 2018 08:00:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <122986b6-b7f2-9b34-b11d-4d63557a2b97@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-20 22:28, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Jan 2018 22:11:24 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Martin Kepplinger > --- > drivers/input/touchscreen/sur40.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c > index f16f8358c70a..c7a0a92b2044 100644 > --- a/drivers/input/touchscreen/sur40.c > +++ b/drivers/input/touchscreen/sur40.c > @@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface, > sur40->bulk_in_epaddr = endpoint->bEndpointAddress; > sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL); > if (!sur40->bulk_in_buffer) { > - dev_err(&interface->dev, "Unable to allocate input buffer."); > error = -ENOMEM; > goto err_free_polldev; > } >