From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdCSJvE (ORCPT ); Sun, 19 Mar 2017 05:51:04 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35442 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdCSJvC (ORCPT ); Sun, 19 Mar 2017 05:51:02 -0400 Subject: Re: [PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification To: Tobias Herzog , oneukum@suse.com References: <1479118868.21146.4.camel@suse.com> <1489863159-10972-1-git-send-email-t-herzog@gmx.de> <1489863159-10972-3-git-send-email-t-herzog@gmx.de> Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Sun, 19 Mar 2017 12:50:24 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489863159-10972-3-git-send-email-t-herzog@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/2017 9:52 PM, Tobias Herzog wrote: > Notifications may only be 8 bytes so long. Accessing the 9th and s/so//. "So long and thanks for all the fish!" :-) > 10th byte of unimplemented/unknown notifications may be insecure. > Also check the length of known notifications before accessing anything > behind the 8th byte. > > Signed-off-by: Tobias Herzog [...] MBR, Sergei