From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934002AbcHaMas (ORCPT ); Wed, 31 Aug 2016 08:30:48 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:37346 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932516AbcHaMap (ORCPT ); Wed, 31 Aug 2016 08:30:45 -0400 X-AuditID: cbfec7f5-f792e6d0000013f5-ec-57c6cdf1bd71 Subject: Re: [PATCH RFC] ARM: dts: samsung: add rga-lvds panel in itop elite To: Randy Li , devicetree@vger.kernel.org References: <1472511002-9019-1-git-send-email-ayaka@soulik.info> Cc: mark.rutland@arm.com, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, krzk@kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: Date: Wed, 31 Aug 2016 14:30:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1472511002-9019-1-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xy7ofzx4LN1g3UdDi1d1fjBbzj5xj tbjy9T2bRf/j18wW589vYLc42/SG3WLT42usFpd3zWGzmHF+H5PFoal7GS2WXr/I5MDtsWbe GkaPy9cuMntsWtXJ5nG/+ziTx+Yl9R59W1YxejTfnc7q8XmTXABHFJdNSmpOZllqkb5dAlfG nKn3WQruCVT0T2xlamDs4e1i5OSQEDCRuPRgFjuELSZx4d56ti5GLg4hgaWMEn9P7mCEcJ4z Spw/eooFpEpYwEdi2rmZYLaIgI3EsyUrWEFsIQEHia0HjzOB2MwCvxklpna4gthsApoSfzff ZAOxeQXsJDoffQKrYRFQlZjbthisV1QgQuLWqo+MEDWCEj8m3wObzyngKLFjww2g6ziAZqpL TJmSCzFeXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsY IXHydQfj0mNWhxgFOBiVeHgPzDoaLsSaWFZcmXuIUYKDWUmE1x8YZUK8KYmVValF+fFFpTmp xYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgLC7pExVOELIqZHKsvvVjruDrB11G B/RKl/HWPDnw+ZC88ZPUozsmH7/cefTr6nSBnrk3DP+7n1pzwsQpK/htUsA2vj1qmifubrxv vvaosljAlubVG9WW7LbZWiEul7/atSlu+T5lvhVbr2+vO8w4IXVbzAZJB8/kV882X1S8WPbZ P6CuyWGnkRJLcUaioRZzUXEiAFoYfWmPAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/30/2016 12:50 AM, Randy Li wrote: > It is actually a lvds panel connected through a rga-lvds bridge. > But I really have no idea about what does a port mean in fimd node. > > Also how should I configure this panel size? I think the i2c found > on the panel schematic, but it more likely to be used a touch screen > touth. Also the touch screen is not supported in currently driver. > > Signed-off-by: Randy Li > --- > arch/arm/boot/dts/exynos4412-itop-elite.dts | 35 ++++++++++++++++++++++++++--- > 1 file changed, 32 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts > index e1cda54..2d67385 100644 > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts > @@ -139,6 +139,20 @@ > assigned-clocks = <&clock CLK_MOUT_CAM0>; > assigned-clock-parents = <&clock CLK_XUSBXTI>; > }; > + > + vcc_sys_lcd: sys-lcd { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; > + }; > + > + panel: panel { > + ddc-i2c-bus = <&i2c_3>; > + power-supply = <&vcc_sys_lcd>; > + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>; > + }; Panel has no compatible string, which driver will handle this node? Regards Andrzej > }; > > &pinctrl_1 { > @@ -221,9 +235,6 @@ > }; > > &pwm { > - pinctrl-0 = <&pwm1_out>; > - pinctrl-names = "default"; > - samsung,pwm-outputs = <1>; > status = "okay"; > }; > > @@ -239,3 +250,21 @@ > assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>; > assigned-clock-rates = <0>, <176000000>; > }; > + > +&i2c_3 { > + status = "okay"; > +}; > + > +&fimd { > + pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>; > + pinctrl-names = "default"; > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + rga_lvds: endpoint { > + remote-endpoint = <&panel>; > + }; > + }; > +};