From: Joe Perches <joe@perches.com>
To: Matteo Franchin <matteo.franchin@arm.com>,
dri-devel@lists.freedesktop.org
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
brian.starkey@arm.com, liviu.dudau@arm.com,
linux-kernel@vger.kernel.org, nd@arm.com
Subject: Re: [PATCH] drm/fourcc: Add AXBXGXRX106106106106 format
Date: Wed, 07 Oct 2020 15:47:57 -0700 [thread overview]
Message-ID: <dee9c91dd38f05eda86eb126cc54679408518562.camel@perches.com> (raw)
In-Reply-To: <20201007092725.13300-1-matteo.franchin@arm.com>
On Wed, 2020-10-07 at 10:27 +0100, Matteo Franchin wrote:
> Add ABGR format with 10-bit components packed in 64-bit per pixel.
> This format can be used to handle
> VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 on little-endian
> architectures.
trivial note:
> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
[]
> @@ -202,6 +202,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
> { .format = DRM_FORMAT_XBGR16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1 },
> { .format = DRM_FORMAT_ARGB16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
> { .format = DRM_FORMAT_ABGR16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
> + { .format = DRM_FORMAT_AXBXGXRX106106106106, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
My is to separate this into 2 lines so every
column including .depth on still visually aligns.
+ { .format = DRM_FORMAT_AXBXGXRX106106106106,
+ .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
next prev parent reply other threads:[~2020-10-07 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 9:27 Matteo Franchin
2020-10-07 10:06 ` Daniel Vetter
2020-10-07 11:03 ` Matteo Franchin
2020-10-07 10:35 ` Ville Syrjälä
2020-10-07 11:07 ` Matteo Franchin
2020-10-07 22:47 ` Joe Perches [this message]
2020-10-08 8:57 ` Matteo Franchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee9c91dd38f05eda86eb126cc54679408518562.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=brian.starkey@arm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matteo.franchin@arm.com \
--cc=mripard@kernel.org \
--cc=nd@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®