From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751453AbdFFSa6 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Jun 2017 14:30:58 -0400
Received: from mail-wr0-f196.google.com ([209.85.128.196]:35222 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751247AbdFFSa5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Jun 2017 14:30:57 -0400
Subject: Re: [PATCH v5 7/9] nvme: get list of namespace descriptors
To: Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>, maxg@mellanox.com,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
References: <20170606143617.32143-1-jthumshirn@suse.de>
 <20170606143617.32143-8-jthumshirn@suse.de>
From: Sagi Grimberg <sagi@grimberg.me>
Message-ID: <deea2259-e2df-189d-f299-7ec915406570@grimberg.me>
Date: Tue, 6 Jun 2017 21:30:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170606143617.32143-8-jthumshirn@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +	if (ns->ctrl->vs >= NVME_VS(1, 3, 0)) {
> +		 /* Don't treat error as fatal we potentially
> +		  * already have a NGUID or EUI-64
> +		  */
> +		if (nvme_identify_ns_descs(ns, ns->ns_id))
> +			dev_warn(ns->ctrl->dev,

ctrl->device