From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbdKMXa6 (ORCPT ); Mon, 13 Nov 2017 18:30:58 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:45054 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdKMXa5 (ORCPT ); Mon, 13 Nov 2017 18:30:57 -0500 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.184 X-Original-MAILFROM: byungchul.park@lge.com Subject: Re: [RESEND PATCH v2 2/2] sched/deadline: Initialize cp->elements[].cpu to an invalid value To: Daniel Bristot de Oliveira , peterz@infradead.org, mingo@kernel.org, rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com References: <1507617844-24348-1-git-send-email-byungchul.park@lge.com> <1507617844-24348-2-git-send-email-byungchul.park@lge.com> <20171012075727.GL3323@X58A-UD3R> <30b71aa6-4662-7056-1a09-a88f4143d1d1@redhat.com> From: Byungchul Park Message-ID: Date: Tue, 14 Nov 2017 08:30:54 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <30b71aa6-4662-7056-1a09-a88f4143d1d1@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2017 9:46 PM, Daniel Bristot de Oliveira wrote: > On 10/12/2017 09:57 AM, Byungchul Park wrote: >> On Tue, Oct 10, 2017 at 03:44:04PM +0900, Byungchul Park wrote: >>> Currently, migrating tasks to cpu0 unconditionally happens when the >>> heap is empty, since cp->elements[].cpu was initialized to 0(=cpu0). >>> We have to distinguish between the empty case and cpu0 to avoid the >>> unnecessary migrantions. Therefore, it has to return an invalid value > > s/migrantions/migrations/ ? > >>> e.i. -1 in that case. >> >> This patch does what it should obviously do. Could you check this? >> >>> Signed-off-by: Byungchul Park >>> Acked-by: Steven Rostedt (VMware) >>> --- >>> kernel/sched/cpudeadline.c | 10 +++++++++- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c >>> index 9f02035..bcf903f 100644 >>> --- a/kernel/sched/cpudeadline.c >>> +++ b/kernel/sched/cpudeadline.c >>> @@ -138,6 +138,12 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p, >>> int best_cpu = cpudl_maximum_cpu(cp); >>> WARN_ON(best_cpu != -1 && !cpu_present(best_cpu)); >>> >>> + /* >>> + * The heap tree is empry for now, just return. > > s/empry/empty/ ? Hello Daniel, Thank you very much for pointing out typos. I shall do spellcheck evetytime submiting patches from now on. -- Thanks, Byungchul