From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 791531D63EF for ; Mon, 8 Sep 2025 07:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757316660; cv=none; b=FqVnFrm7F7wP0MDJfsH8Gmd9ayvo1a4IlUrAWdaYdbHAnJA9yWGwbTa8+nqogsk0MqocIfqEbD1f173riSGWIe7HUhBRIMblyNhTcjof3tJgQ+/xQzc3kFk/3ZTM+mgEnceGUjht7cCN4UXnyNK0361ciQh0Vrttz1neVRNDKZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757316660; c=relaxed/simple; bh=Tyh1zDni5S8jgRqwErLsylux7AxcdyPvaTtJMcfwc54=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bsXiGywR6m5MILMDR5OWBemchoM68tv5eJRfdV0R2MPE6H60ZNmn936zuTYQVSFfouYpG5lb7IeUuVN+jFSOk2fvjNjZq49qhOC93dDrbjnCfXg79drKwzCGbRrq05YW6V0czXLYI1ur6enTPMOZkfY37/kzNhwtYmNUhih0qys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JFFQD70t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JFFQD70t" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 587IF1kB023525 for ; Mon, 8 Sep 2025 07:30:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0epY6YU9RGxckWtia0nPq1VOjyxmvPEuFA73sxSG2qw=; b=JFFQD70tlTc8jlEg Sp3k5BpgkCOlNEhcmzs1rMqNUgkU7gFyRJ8Qpc+hTkcHgR/s8aPJ5ALWtAnM8I1g Tm+o+itQedHkFdBZwRgyzfWXkOSYVV4G0ucrKG+ef/c4VM8l6c2QDguOGLcN7vd9 gQmrmQikeTelRsrG4kx223zNtQTuiSF23r60nrFwMyKeNLEtF3nuVdLoq+ikYZ8f /uGnKw8F8SFoZbHAdqfsYfG6VFU74mkYwY3pagXRbGWDiJZn6UWeGYM2U+QlEGMF OZzF2Uxn/5cqwnULEl3lnPOqEoKkiOure5N36MSQVvUt/g+za4UB+4v6J8IITCY+ xTWX/g== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490db8bn5w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 08 Sep 2025 07:30:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b5d58d226cso102710001cf.1 for ; Mon, 08 Sep 2025 00:30:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757316657; x=1757921457; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0epY6YU9RGxckWtia0nPq1VOjyxmvPEuFA73sxSG2qw=; b=Wnfzapmitlojk0SshRDIFtba/xLdM2Ussf71CZs4rByiZutoz1MRgbm7kLqcw/AWmO R2lU3mL0wMaI4Dk3AjdLz5G3x2fEKrJG4Hzqec8KhRjr6CDN2J4ET/zxGxdhOFupLje4 Ns5U0c+eaTrjfWWmBwFbUwM/EZRABVrNUUVT2K3qEW1ptLuFDPMa26XdLmL/C1MOfCr3 QrZ6BZSMPHjReptYPlUzAvzDRTcV0eJ7EUzasz7RBkJdEb0beDRROavixqpfZiYiLqWa 6rE/yk1GWWe99m8g6blmJd38LH7us8FJt9wnRcHwDvbuqlc1Wev4+zS/ZPsGL6Q0tQfY D1lQ== X-Forwarded-Encrypted: i=1; AJvYcCW3/OhquuhWSS2/N+EuTkaXC6H3mUqWyKVQZVMdwB2EwhaDeCKnTTWXfIblpA4ejy7NDpYp/VLpX/AjCTE=@vger.kernel.org X-Gm-Message-State: AOJu0YzDg5aZIyge6cSxov6pQ+6BpC6DQsyJBueD9u+z+BQfmP9LGAaf pRmx0LDlp3l3dg6+Xr+sYXbXE6iIZESPpjxhzsCKM5YOow0FiqTeQxC2U5kUjLq3N5AkwJug1Qm 91MjGiRfvrS84WjCszj3xr1GGsHJppPlZaSKL178x3C4wgLqHU2/gWExFG5OcLKDtDGg= X-Gm-Gg: ASbGncvgtCiBLf9CqhKKRn4qeMiHRR9ieS7guNh3M/Ru7A+EbZM07Hsdfbpjh9USV2v LdNccRkoJv/IEuTi8RjRQizjf4fPdYaA7F9dbdB+VyFbMM5xRHY9DqDQ0cF5OaHo88Ww4wHnh7r UNGtBjaE2QgUpvS3wTCmj+AVfoeZWAnzKBsosuHgklu+1Je54qgMQEGZpLZe6AilF/zJFopNgXY wPnT8mngBfPBnMGVwfGxTVXZJwVaRWvcaSvBmkNf21g6OB7nr3r9RC/hE1sQmamixYnLFR48bJj RPTN1dGTa47SLX1qplN8p85ExvfIc4WnLy569ahXnANW67NQJMYOg4HmEUbtfv+y1MQ= X-Received: by 2002:ac8:5a8b:0:b0:4b5:d739:6077 with SMTP id d75a77b69052e-4b5f8445b09mr83193991cf.41.1757316657512; Mon, 08 Sep 2025 00:30:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1JPR4PfJ/rf6grklM9vccNdBWfJgn6bV4FHqQByIM1t9B/i99IyFfm4pPOqnq+ZTAa+vitg== X-Received: by 2002:ac8:5a8b:0:b0:4b5:d739:6077 with SMTP id d75a77b69052e-4b5f8445b09mr83193511cf.41.1757316656824; Mon, 08 Sep 2025 00:30:56 -0700 (PDT) Received: from [192.168.68.119] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3e748b38be9sm3039508f8f.47.2025.09.08.00.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 00:30:56 -0700 (PDT) Message-ID: Date: Mon, 8 Sep 2025 08:30:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ALSA: compress_offload: Add 64-bit safe timestamp infrastructure To: Joris Verhaegen , Vinod Koul , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Pierre-Louis Bossart , Srinivas Kandagatla , Daniel Baluta , Orson Zhai , Baolin Wang , Chunyan Zhang , Kunihiko Hayashi , Masami Hiramatsu Cc: kernel-team@android.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-msm@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-arm-kernel@lists.infradead.org, Miller Liang References: <20250905091301.2711705-1-verhaegen@google.com> <20250905091301.2711705-2-verhaegen@google.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20250905091301.2711705-2-verhaegen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzMSBTYWx0ZWRfX4uX7mI1myMCD 4My7uaQZBbrGU5e/bmOP8RgEJ/OJ4NjuUOT26LeikI+e0HcIkQ9aKlvHlmU01coblwK2etXaYjY ZnE55WB/0Mxyq3nlOTSOCS6eZucprG+y/JHrBBjUDv3nzzUqbny9RlPKKeWJ1Mstu0LZii/vD1W JgX3pe+43kqbrLdn7ZCIFXjBiSlZcRzgAPK2PRNxccegUAqMijxqJNUV/mlnD5ydWJ6+0z1XLYC nqtPhbcmZqldWwMLopsPNwbd1W0FmTXkF/oq31CDqwJS6HAX/lUDs/5Ap1p5qaVfPD8rIU+FlY/ aRM5imBYXEyvbEozGo9mN6LRTCtqMSFvMaKEMXfVgtbQoZYGnXOov7WBSzRrHphsMDhgvjIXP01 J//ZHZs0 X-Proofpoint-ORIG-GUID: JFvc6vMW3PFgr8S7C9LDTr8nZ0zE0Jug X-Proofpoint-GUID: JFvc6vMW3PFgr8S7C9LDTr8nZ0zE0Jug X-Authority-Analysis: v=2.4 cv=VIDdn8PX c=1 sm=1 tr=0 ts=68be8632 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=1XWaLZrsAAAA:8 a=EUspDBNiAAAA:8 a=4O46WkZMOCDH73qdsaoA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-08_02,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060031 On 9/5/25 10:12 AM, Joris Verhaegen wrote: > The copied_total field in struct snd_compr_tstamp is a 32-bit > value that can overflow on long-running high-bitrate streams, > leading to incorrect calculations for buffer availablility. > > This patch adds a 64-bit safe timestamping mechanism. > A new UAPI struct, snd_compr_tstamp64, is added which uses 64-bit > types for byte counters. The relevant ops structures across the > ASoC and core compress code are updated to use this new struct. > ASoC drivers are updated to use u64 counters. > > Internal timestamps being u64 now, a compatibility function is added > to convert the 64-bit timestamp back to the 32-bit format for legacy > ioctl callers. > > Reviewed-by: Miller Liang > Tested-by: Joris Verhaegen > Signed-off-by: Joris Verhaegen > --- > include/sound/compress_driver.h | 2 +- > include/sound/soc-component.h | 4 +- > include/sound/soc-dai.h | 7 +-- > include/uapi/sound/compress_offload.h | 19 +++++++ > sound/core/compress_offload.c | 52 +++++++++++++------ > sound/soc/codecs/wm_adsp.c | 4 +- > sound/soc/codecs/wm_adsp.h | 2 +- > .../intel/atom/sst-mfld-platform-compress.c | 12 +++-- > sound/soc/intel/atom/sst-mfld-platform.h | 2 +- > sound/soc/intel/atom/sst/sst_drv_interface.c | 9 ++-- > sound/soc/intel/avs/probes.c | 2 +- > sound/soc/qcom/qdsp6/q6apm-dai.c | 26 ++++++---- > sound/soc/qcom/qdsp6/q6asm-dai.c | 26 ++++++----for qcom parts Reviewed-by: Srinivas Kandagatla --srini