From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BD3C636D4 for ; Wed, 15 Feb 2023 14:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbjBOO35 (ORCPT ); Wed, 15 Feb 2023 09:29:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbjBOO3z (ORCPT ); Wed, 15 Feb 2023 09:29:55 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C62D43431D; Wed, 15 Feb 2023 06:29:54 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6D0E966020E0; Wed, 15 Feb 2023 14:29:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676471393; bh=7q+8dNYL/2VORRV49y6U9IKXin8dzr+DqWZ4K1xflFk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d2TOQnXU3I/RFS5jqXtPVt5fMugZiiKfs0qaBwzNvTsQSRY8PiWKwVK5/1CM3R2Or 6OWLEgVcRtuIdGWOZdn0eV7qjB+h+oLs9M2KG2P/3d1HabS9hodgqbDDMCUkOvXpwi /z8ROm7vcXhjhJyh/Poj9AFABj2f9OsZCfF4ctrtOqCP4PID8jGbEAD2o4uYtwGlIr yqpS5hZLOrVIuQpIQ++j+TrcJSaoNnX7GLFvHfWJCPt8xkPWWT6v92jLCIKzPM5C/N HimyhpY4TqA3qNNZZRa762rqfRtExa+ktT2o/L0JcXYFIkUe+QITjG5XHvk8Y3DpOr tfRlQvxukAtFA== Message-ID: Date: Wed, 15 Feb 2023 15:29:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin References: <20230213041535.12083-1-rdunlap@infradead.org> <20230213041535.12083-4-rdunlap@infradead.org> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20230213041535.12083-4-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 13/02/23 05:15, Randy Dunlap ha scritto: > IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set > it directly thru "make *config", so drivers should select it instead > of depending on it if they need it. > Relying on it being set for a dependency is risky. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on" for IRQ_DOMAIN to > "select" for RTC_DRV_MT6397. > > Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") > Signed-off-by: Randy Dunlap Reviewed-by: AngeloGioacchino Del Regno > Cc: Arnd Bergmann > Cc: Eddie Huang > Cc: Sean Wang > Cc: Matthias Brugger > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: linux-rtc@vger.kernel.org > Cc: Marc Zyngier > Cc: Philipp Zabel > Cc: Peter Rosin > --- > I have a similar patch (should be a series) for REGMAP. > > drivers/rtc/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)