From: Vijayanand Jitta <vijayanand.jitta@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
robh@kernel.org, konrad.dybcio@oss.qualcomm.com,
bjorn.andersson@oss.qualcomm.com, bod@kernel.org,
conor+dt@kernel.org, krzk+dt@kernel.org,
prakash.gupta@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
Subject: Re: [PATCH v6 2/3] of: factor arguments passed to of_map_id() into a struct
Date: Tue, 27 Jan 2026 09:45:00 +0530 [thread overview]
Message-ID: <def02695-0c39-4a65-859d-17ddaece7d6f@oss.qualcomm.com> (raw)
In-Reply-To: <CAO9ioeU8-uQx4cJ=_nPfQ_ZJ=ZUAwwCYrehSqLw5X-YBVnFz3Q@mail.gmail.com>
On 1/21/2026 12:08 PM, Dmitry Baryshkov wrote:
> On Wed, 21 Jan 2026 at 08:38, Vijayanand Jitta
> <vijayanand.jitta@oss.qualcomm.com> wrote:
>>
>>
>>
>> On 1/21/2026 11:30 AM, Dmitry Baryshkov wrote:
>>> On Wed, 21 Jan 2026 at 07:54, Vijayanand Jitta
>>> <vijayanand.jitta@oss.qualcomm.com> wrote:
>>>>
>>>> From: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
>>>>
>>>> Introduce a new struct type where the optional arguments passed to
>>>> of_map_id() are Currently embedded as of_phandle_args struct.
>>>> Subsequent patches add additional arguments to the struct that the
>>>> caller expects to be filled of_map_id().
>>>
>>> Which additional arguments? I don't see anything being added in 3/3 of
>>> this series.
>>>
>>> Can we use of_phandle_args and switch to of_map_id_args when it's
>>> actually required.
>>>
>>
>> As mentioned in the cover letter, this change prepares the interface for a
>> follow-up series adding multi-map support, which we will be sending out
>> shortly and which extends these arguments. Keeping this in place avoids a
>> subsequent rework and keeps the overall transition incremental.
>
> Could you please point out patches adding more args.
>
Please refer to the below patch series, it extends the args:
https://lore.kernel.org/linux-media/20260126-kaanapali-iris-v1-0-e2646246bfc1@oss.qualcomm.com/
Thanks,
Vijay
>>
>>
>> Thanks,
>> Vijay
>>
>>>>
>>>> Suggested-by: Rob Herring (Arm) <robh@kernel.org>
>>>> Signed-off-by: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
>>>> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@oss.qualcomm.com>
>>>> ---
>>>> drivers/cdx/cdx_msi.c | 2 +-
>>>> drivers/iommu/of_iommu.c | 12 ++++++---
>>>> drivers/of/base.c | 37 +++++++++++++--------------
>>>> drivers/pci/controller/dwc/pci-imx6.c | 10 ++++++--
>>>> drivers/pci/controller/pcie-apple.c | 4 ++-
>>>> drivers/xen/grant-dma-ops.c | 20 +++++++++------
>>>> include/linux/of.h | 32 ++++++++++++++++++-----
>>>> 7 files changed, 75 insertions(+), 42 deletions(-)
>>>>
>>>
>>>
>>
>
>
next prev parent reply other threads:[~2026-01-27 4:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 5:53 [PATCH v6 0/3] of: parsing of multi #{iommu,msi}-cells in maps Vijayanand Jitta
2026-01-21 5:53 ` [PATCH v6 1/3] of: Add convenience wrappers for of_map_id() Vijayanand Jitta
2026-01-21 5:53 ` [PATCH v6 2/3] of: factor arguments passed to of_map_id() into a struct Vijayanand Jitta
2026-01-21 6:00 ` Dmitry Baryshkov
2026-01-21 6:36 ` Vijayanand Jitta
2026-01-21 6:38 ` Dmitry Baryshkov
2026-01-27 4:15 ` Vijayanand Jitta [this message]
2026-01-21 5:54 ` [PATCH v6 3/3] of: Respect #{iommu,msi}-cells in maps Vijayanand Jitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def02695-0c39-4a65-859d-17ddaece7d6f@oss.qualcomm.com \
--to=vijayanand.jitta@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=charan.kalla@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®