From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 961242EACF0 for ; Mon, 13 Oct 2025 08:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343014; cv=none; b=dfkiStsYb4PmzbG+wjndEeMWzzVnZSjm43FlBrfN5LADiF1ZGh66FW1F8vWXj1Aput6L09Lk0bfhBQx4USfknCTZLkbKpZTA5wIvJYolNrHqXxMGKCgMoJ8afEBz4TWwKLj7WVjMeirNdQbM4WQyZChx1jVeaYwd4GMJ7+Hi33U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343014; c=relaxed/simple; bh=5zfQCP0qqKWCIBIiMPjDnH6mBdr1zUxat+eWoBHccLs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CD33TQpCteZDgAMkxJLT0VGTFEDWaA5HcZT0btnSuR4C2AfRvnr3upKgqDqKWuda64cX+GL+Wk8bEF2DIZdLM+xbL5JQzOQVCOQTpxSV1jMBLHhG5shzk+MmqUa45tJphSS9JOXXoQE8i3QWhxj/R1FwRfKuN33Z5pSYqNea4+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aPOFmrvB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aPOFmrvB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760343010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mzBMdxq8/SEOuqGoX1j4+iaBZ0Bo8TLDfpyglTErDQc=; b=aPOFmrvBImnvWZCtjlGCXpaATsIW9J262Eu4jidEMqceMTH7kQQJ52F3Ccil3aErQJv0v1 i4w+j/2viF606m9j94xbznr9xqYzRVCpJTzqJMAa1suXBQMuWTvp55bR81t8Nw0BVnfy14 SBeNwbSdZTU0sd9P5VETuDL4fkSm2cg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-bX6TsKDGPKS4aIOx-Nl1bg-1; Mon, 13 Oct 2025 04:10:08 -0400 X-MC-Unique: bX6TsKDGPKS4aIOx-Nl1bg-1 X-Mimecast-MFC-AGG-ID: bX6TsKDGPKS4aIOx-Nl1bg_1760343007 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-46e502a37cdso24814125e9.0 for ; Mon, 13 Oct 2025 01:10:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760343007; x=1760947807; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mzBMdxq8/SEOuqGoX1j4+iaBZ0Bo8TLDfpyglTErDQc=; b=oD+GKXg/foyImkvEyqu2eyQLwb9tFRrJVZY79th8w97ouwwt8/KAUjsa1Vp3t7xpTE FU0iNjNytaTVrzz10tNCYfuC6Ig/svVXoUQOygWTT3Dln5G3TXfjcQbOlsILKOoUN5EQ /IudxaHGuH0lneOhdvKoOvzWtx/e53eR2yy85fTGiqj/i2TytJk+3rsfTFzl9ONtP32A Yd2E3nUB9N2kAZUXyiNxaDdEi+CymXljnOOCAf3uC8XLjbp5skdOUk5vXyXnsxwg4v4O TZu1vxBSbopB09UuI6iRVWlAcYRLveUvRlmrI6n6evuFKPPO5RQ6epVqJyncpSef5/Yn o5xA== X-Forwarded-Encrypted: i=1; AJvYcCW72EprEmyTCyo72ZgjIn2Khpt2IVTSnSofL/LZCBUSd3f09/06YHzWmTbzRXfF920enpjn+ZWLA7aH6OI=@vger.kernel.org X-Gm-Message-State: AOJu0YwyHTJu3xtaxL69dPaDXJE/TJpYiQvorhdJ63cAnGIfRZ7JVLlC uX6diPFYJP4LS5axEDez98fj+/6VFP7B0m+3yt63stdeqkc+h4sVr460pfIFsBiHWditygswklG wjLx7eLFrLDX20uAPM0tvHmleof3tkVKS7g0mEwPRFK5vtIDRGmCwQXAQOwJXOuvWQQ== X-Gm-Gg: ASbGncsd5S64GI1PRiOocrcGRqgeIAczdKpHMpwflsOx13WOqXGea/qm+8GOjQkkHM/ pBIfq2jDZBKBZVZT8R4LHsd3Nd22gzGFf8rUCQeIiBW1/hporBwhavlP9JWfFxqGmdypm4f5q04 pjtBTJOJtI3g/P/jZLS6oXoyI+xFgL/HCMObepmHJ5T8srRInw7WV+hlX6HHK42R7fYg+SSovxc nkfo+O3Fo7pyNmSwr1nEF6KQFSDmPGlgtshSuvuNxznp9qbgpxE94ZMBFcqtQP6IzFa+L9jESaO alor7pUmm3UrbpRwr5G/O7r3Ryx23jxaSMdTGK8i93dU7rYotBSsc7pWmRZmxJrWRJVg0cwvG28 ZRfU= X-Received: by 2002:a05:600c:8718:b0:46e:731b:db0f with SMTP id 5b1f17b1804b1-46fa9b08f09mr149383495e9.28.1760343007149; Mon, 13 Oct 2025 01:10:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIX1+LG4xUS/7ieEOK5X8J3ovtE8PkBs1+dxZ5V3XzlllfRN+mofANp3L+IWlXa9MLkMwa/A== X-Received: by 2002:a05:600c:8718:b0:46e:731b:db0f with SMTP id 5b1f17b1804b1-46fa9b08f09mr149383265e9.28.1760343006754; Mon, 13 Oct 2025 01:10:06 -0700 (PDT) Received: from [192.168.3.141] (tmo-083-189.customers.d1-online.com. [80.187.83.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb4983053sm172313925e9.8.2025.10.13.01.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 01:10:06 -0700 (PDT) Message-ID: Date: Mon, 13 Oct 2025 10:10:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] hugetlb.h: flatten logic in arch_hugetlb_migration_supported To: Gregory Price , linux-mm@kvack.org Cc: muchun.song@linux.dev, osalvador@suse.de, linux-kernel@vger.kernel.org References: <20251008212614.86495-1-gourry@gourry.net> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251008212614.86495-1-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.10.25 23:26, Gregory Price wrote: > Simplify if-true-return-true-else-false logic. > > Signed-off-by: Gregory Price > --- > include/linux/hugetlb.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 526d27e88b3b..b030850975ef 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -876,12 +876,9 @@ static inline void folio_clear_hugetlb_hwpoison(struct folio *folio) > #ifndef arch_hugetlb_migration_supported > static inline bool arch_hugetlb_migration_supported(struct hstate *h) > { > - if ((huge_page_shift(h) == PMD_SHIFT) || > + return ((huge_page_shift(h) == PMD_SHIFT) || > (huge_page_shift(h) == PUD_SHIFT) || > - (huge_page_shift(h) == PGDIR_SHIFT)) > - return true; > - else > - return false; > + (huge_page_shift(h) == PGDIR_SHIFT)); switch (huge_page_shift(h)) { case PMD_SHIFT: case PUD_SHIFT: case PGDIR_SHIFT: return true; default: return false; } -- Cheers David / dhildenb