mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: industrialio-trigger: constify device_type structures
Date: Sun, 22 Jan 2017 13:17:06 +0000	[thread overview]
Message-ID: <def5dabb-404d-f050-386a-116575fcc0e8@kernel.org> (raw)
In-Reply-To: <1485017989-22670-1-git-send-email-bhumirks@gmail.com>

On 21/01/17 16:59, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to declaration of device_type structure.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    5389	    208	     48	   5645	   160d	iio/industrialio-trigger.o
> 
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>    5453	    176	     48	   5677	   162d	iio/industrialio-trigger.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Makes sense.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/industrialio-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 978729f..3257f0e 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -487,7 +487,7 @@ static void iio_trig_release(struct device *device)
>  	kfree(trig);
>  }
>  
> -static struct device_type iio_trig_type = {
> +static const struct device_type iio_trig_type = {
>  	.release = iio_trig_release,
>  	.groups = iio_trig_dev_groups,
>  };
> 

      reply	other threads:[~2017-01-22 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 16:59 Bhumika Goyal
2017-01-22 13:17 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=def5dabb-404d-f050-386a-116575fcc0e8@kernel.org \
    --to=jic23@kernel.org \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®