From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B568C233956 for ; Fri, 22 May 2026 12:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454491; cv=none; b=XbvE2MmxL85S1/RJs+Yw5hi3FW9q3ZoZ5PaLf1W2ckTqpFVXa0W02d9HJMN2oCnSeUCOfh6Kf1MYX5361lXIHUJCl6NbYFgsnMGxDcwWmLGVe2Q3nwDPBhc/4ne5nsBfb1brITwtnC7iWd95xWJyEoZYgpwn6HDTejeX8vzjYKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454491; c=relaxed/simple; bh=VXs78MA6J6D2rEIL2rbG2HPAMQtSJMsnE8RkJzkUqFI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Co2GaDT93ei+QwtHKRu5YEv4BAyhXv+dRjUNnfV/SMJsradPrlWcgVtkc761ADTh/LPduXwWsr4jtynqoSsS+pCyLvGLXVaPvk94clKurTg4M13qqBlesIkaLR0KCDRciUA+fUlcoV85UkKXQ3r92wBZTOl/1suVWRBIqPIh3Aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eH3ezz6C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XYLAs1ea; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eH3ezz6C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XYLAs1ea" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M8aTri399102 for ; Fri, 22 May 2026 12:54:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ea0S4zQrwmtFxTVo56imyzNGzEUv3R6pf0Xv6mhSt+4=; b=eH3ezz6CCIOp99hd 5VYtElxxuxo4usmOpIB6+VfqXgWbE6fasfSd0zClgJB3qfmeDH+WUi/er3UZPkfo LIIQ4UrlIPWdr5CQRDlGqOGbmeZzbFDRfOs0wSkYIk+nqOQBlwYp2LUlDbRUjqV+ M7L4Nn0ZqW4iVZiJptSXUz92XeVZMPQ/5942ok2YqjX00IZp0dIp5XNvbko1GDzP GtjBnBHDodkjsfOSzkcNKmBDkLAJT2s4Qv3COmLpSc86SyaW9rqSAqWfDp9TfG/I EiuHemXfTQ3R88JwEgYOsInARjR8Mg8UNCOi9CaTc6DvM5it/fVFfsUfCZDOmXqp U4atBw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea5p9vbeq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 12:54:50 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c82c4772950so3659331a12.1 for ; Fri, 22 May 2026 05:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779454489; x=1780059289; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ea0S4zQrwmtFxTVo56imyzNGzEUv3R6pf0Xv6mhSt+4=; b=XYLAs1ealLlWAR4I0npoIwzt4IXtj41vYcsjs2RJ8dv8ZXTXi8iLtjwvySte4eeVAp bhMvo5rOsg/s/OXSVrNTLjqgoZZX8Bz5d4XFwXZwCn0uFqIbKH6lb1aCyAjG7e0S0W5v BPpiJS2DKfq3Uwv/Otu+BO9ZckD4zZPJ8ViNHWa5o+jvzcBw333FfQWFQK2/hFsptSwE Og5R0aJ4hjd5lfgbbrGkU33oBjbWN1mkjXjgCL2pgRF81yjYfNThQ7oTBW55+NxzGxme JC5J+pSdmwfdV7ib1f5C8ZTk3wwwLsfH58JHiMm/b3hSsr+AhHJwD21QsRDomEdCL4sq xDTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779454489; x=1780059289; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ea0S4zQrwmtFxTVo56imyzNGzEUv3R6pf0Xv6mhSt+4=; b=jTCPDju+b9xTHr0VXhp0sswF/tQ+zrxniBuJD6pubwcY6DQcuQ4eWUuR4IG/zlCdZW GrQ8BHk3hN7J032KPWj7c/DAHRfOfOdwEXvNx9B2Tb1SJEN3dEePOI0agYH1GmgzT07V 2leVFQqJmAc/YEOwHDjR9S8STVZkvHLjA5xkQRO+JheZGX5dibg734g2FXZPlUXho8RY 7hvndxJMrBGQqn7Z/4+aQjwFOdEbGV/aAKeev9elGSjE/6rILU7pGH1W7LW18QEnitDA Z+0IhiQAGCoJ3sPgKAgPqPDbeF7d3N5SvmcEL/KYePGh1Tg4jzxB4vjVVXjrbwDsCMEU Cb4g== X-Forwarded-Encrypted: i=1; AFNElJ+6dTIK/7beNiY/CyGp3/IvUqNUuP2/Yrrn/5I13yjZdMhVKrt9iBf2Xv7cT4b6LQZp0vVSrIPHmqXT9x4=@vger.kernel.org X-Gm-Message-State: AOJu0YxoMNnR1u7lojLZR5jRg4z2ZwaheoJ6ePMQ+hyOYSYcLvKwuTP8 myb0xk7hbr/r+VNfuFxw7EY8clr1w6Zktc/0FlwXadM0ePp1TLLaHY4nKopKU7S0wSL+5AmKFCf GD2a3J7N293Fz776WZdxmdjPjTpdRX1+lBzu8Np3YGjgP3OEfZp8jvWdDI/Gfon2P1Hc= X-Gm-Gg: Acq92OF+NPzASOr0GM7Wge/6m6wu1OuY/06ZhRBI1anKRR5sjDuIyMEQdOlkzVXgEwx iz+hlLFBIRdGV777wUYDgoboNC9q36WS97N3rb4jvMrM/ljMDRVZX8kE2E4w8xe6wUDD5sCuTR+ /3/ajVH89uTSLt/NxL8OKkWTeAXoxkIrodLNstK96FrgHGsoEeRJdTJqMl79qJ8sGY5yug0/8q1 UeNOigET8waCW6ILiglqdtIS9RoLiCgg/RUV4+MWGTo8Ci2eicWP3rEoIhnApIU92CpmN7VkeTA Snoncms1AqfFOHP1xdV3ZGLfvtWJmNsFqff2SEYDRouE5uDOOROwNCevex7ERT8iOK7gRlKfLaE hzBp68EvgrcHdushK+rnXiRz05aoc1T4smAXhE/6EyhEj7oniFQ== X-Received: by 2002:a05:6a21:4782:b0:3a2:c9a1:2c22 with SMTP id adf61e73a8af0-3b3294ca167mr2620210637.6.1779454489352; Fri, 22 May 2026 05:54:49 -0700 (PDT) X-Received: by 2002:a05:6a21:4782:b0:3a2:c9a1:2c22 with SMTP id adf61e73a8af0-3b3294ca167mr2620181637.6.1779454488823; Fri, 22 May 2026 05:54:48 -0700 (PDT) Received: from [10.219.49.212] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164b1af1csm1868442b3a.27.2026.05.22.05.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 05:54:48 -0700 (PDT) Message-ID: Date: Fri, 22 May 2026 18:24:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Mark Brown Cc: Srinivas Kandagatla , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260518081738.2453957-1-ajay.nandam@oss.qualcomm.com> <20260518081738.2453957-2-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DKm/JSNb c=1 sm=1 tr=0 ts=6a10521a cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=knVCPYfzRBhieiZ2OR0A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: 2USz35rF4bn05KCqM6aZ59Rnx7S5O5Ns X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDEyOCBTYWx0ZWRfX+oqiBkXvKI4b dk30a8bsjw/M/QorTjdd7Jy0fylpaFzOMLT4M4MaabUV2lukjTFJK5WxBmNPyEXYJpm7XPQOKso Eg4Ozvda7OtvbIe0Ff4w40wPa+j0A9QJPs5q/cx81/Z3ICzpVe7P1NJ2U4CaEFNgX63kZVKHvNb 1omuaJkyvmVWu1geiO0sXKkyKJr90fCbSZMgyVYnNhWA7fm9A3//JorhjKuQPrheW5naUFGvKOV KfnVo3rSA2nJ3kivyM3JmQmk60rrVO4Qsuijg7Auyzg2+ZjV+m9ULAae1yc7h20v5IlyaBtzUel gUGG52c38uug4F/ixjM2dM7eYQGlE+fVfVwW730Wg+WRtGZ5kZjNWbOtIxmdekDrPR56oOY3O/5 VYTyxApaIsSrI6DIM9Ms3jTj5vBUDOlBk4KRWWy2VGARTyLOfLJIWipIxtFFUI0P8vLlZSskn0f zfCFXKUK63apP5M4IxA== X-Proofpoint-ORIG-GUID: 2USz35rF4bn05KCqM6aZ59Rnx7S5O5Ns X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220128 On 5/19/2026 8:03 PM, Mark Brown wrote: > On Mon, May 18, 2026 at 01:47:36PM +0530, Ajay Kumar Nandam wrote: >> Convert the LPASS WSA macro codec driver to use the PM clock framework >> for runtime power management. > >> The driver now relies on pm_clk helpers and runtime PM instead of >> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >> clocks. Runtime suspend and resume handling is delegated to the PM >> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >> PM callbacks continue to manage regcache state. > >> + ret = devm_pm_clk_create(dev); > > The !PM_CLK stub for this just returns -EINVAL so if that's not enabled > then none of the clocks will be enabled, the driver needs a dependency > adding. ACK, will update in V5. Thank you for pointing this.