From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44338387363 for ; Wed, 1 Apr 2026 09:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035699; cv=none; b=OF9tByy9ZatWYkYSaOYT3xe2lhrrfmSQsGYj2spW9+oPtWDOjfKZ8+BN3jiaubdN+Lb0HXzgZLDhkf5ZGbdVNLaZJL+vNte1OpNPh/7BPPciwoMvIauOMlsMhwO2JdXkHNNC6Ju0SQX4p/QnbN5tLfmZGD07DM9KS5y5xP4Ryrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035699; c=relaxed/simple; bh=tlGyvOsQ9Q6fmk2zG00jdlVEr+FBACdo3u1quHCsNRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l6oQUFcfCNRsgS0HeY/M+gbd7lVlhn+P7FVWB2AltOFGXv+z1j3ilvHwnAuzqC6aObZqRIDUTe0lSh2BKuwMZH4Pu1rxBk3g4/sVQ+jnPrHxhhBfIFSCFkmGoiyLRB1ASMLav0thjduVi3gAXq0YK6y0OX060k7nU/Rx3TwLXaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A303t2Yn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cdhCJDxS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A303t2Yn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cdhCJDxS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6318C3EJ718617 for ; Wed, 1 Apr 2026 09:28:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hz7N9PkiX8JrIbiQeN8cLDfCplbzTBEEohid3YxCQIg=; b=A303t2YnmnedJUN3 8kxrcrVp5vKYWMkkolXJvxayCp+4xuYLZ88XcsrViQW5MV+ROQE8hEmm4F/PyQOc xIMxQ1HIPqsmMGbVI6k3tH0BEjeLvS64LKFUQ3666EE0VMOm2MnkGx6/sswIEt+d a4MDzxou9KIPMKO9SD7zT07Y2Y2igoO5Cl3kxhup4SZS/2DC/AkrZkF+JkpldKxw 5vFG83SkrHuU0be+4W8c4RS0A7dJXQd9uPpwd3+A4raYUAI1R3+Pnemw4IiZpWjU g7UeUouilno6+g4poLWjo+SRSQbra/IiyCio56wenH78uFAnFdGgqAzyKY1DsH7y iVylHQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8kcsu988-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 09:28:17 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89cd541c0edso29297746d6.1 for ; Wed, 01 Apr 2026 02:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775035697; x=1775640497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hz7N9PkiX8JrIbiQeN8cLDfCplbzTBEEohid3YxCQIg=; b=cdhCJDxSfeNgkM2sbQYbPy9HPr3N+5fHCqzbKUYyu6bCMUOnKe+jOKJQ6Mh7KBDE/f k6lKrtr5sSz6E2/uqHE4woAEhBDUVmgO7jCy/A3rIoZWMw0HsR6z6NLQ80Zx1w0Oau4K GsiOp/VtiVfsUKS6q7d05QFhSxr8TUlNn1h7hchVQxwVEuH4dV6Ei3gaK151BGhx/PCB B8UjlHKDFFlsRa5tNJxtA2CFGR+qza0mLP95R8mCyOrrVrAdu0WzCp57GSkO8gHiXgId 6X77iSrWUS4rz67/WuAWiYBIivARbFIZiDkxQy3S392LUZ/R6lyiyJuwDM9LxYN+gULK 5xIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775035697; x=1775640497; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hz7N9PkiX8JrIbiQeN8cLDfCplbzTBEEohid3YxCQIg=; b=S9n57WAdNB+zxvaEAMzeDdwS3bjpep6xLg01CuhCZJc5CCjsXDHHcUPCQ6JxwzStFd eQzH0Q4Ecbr5+t6jH7Lczzf5i7P8ltd6ZFSdrxnprYJjAuw38J82jy1M4iMr1YDauA0h tDL7JYs2nxhUoCx94ddhouQQjGp5Z2FKMxXy+qu7CWpU8W/raiJKlKwszeSHTuJzCnO0 A3qUmQa0ayARJnFIu/u7lKhnyy7aCuzetNWNsqHuOkuSkopY/jHPGITDD6QsehtsZvPt kBPzrLeIGtpBIzmzlIaK2lcqlTYMFTf8iFf28/8Bzno3teW0IYciJ51GLCC0v3s9ezIa OaUg== X-Forwarded-Encrypted: i=1; AJvYcCW2nU6jLGk8WmqIH4p5hhQ7Xb1LuGVOCSPAmc91PsBAlbrhsi4XhmaS9AvQKKMBJZ1eB1NEHYDw29/WCC8=@vger.kernel.org X-Gm-Message-State: AOJu0YzbQNt/Iq1FxjIbR9SHvOn2p5YFNi83TKegrTA+lKogoX7oMY+B nE07H/LCTlBth0GPoDjl9feXbaPQuJ+aADk50lxb5JBeaR3CRL37Y3e+byC205nANfthR9bpWAg 5X1aw0vOn+7fxc9Qi8xxh4x6QaMgsFm8QO0d6IIRG7VJvQ1kuNAf5822yvDRXqsaBfRg= X-Gm-Gg: ATEYQzxQABPsVCrHjv+5uxu25/h4O9g74UUHIWf4Toxpz4vfDrd4WtHDLwtPv9Riizf TEJvzRIxoogTVl1ErvNjiMPHgxQlomIbDqjLsrnTqzDkxTRnmCNN/9vNOgrjoOUAbJLJpNfK28g AftJdIycGG070Sv8fvxZkhhi5qp51nmIw3uhjeqY0rrzDWLmQypLqbtVOfjpiz3UEK6rYCYmQW0 CmInQ8COPdUlr8pP8O04eZyKKR9XimjQp6uuMNdpLbDZucfLjKMB3axifFwlwFF6OJ6TGqN4fgA Kf+9bS3D8OmuN4mEXC2/IFENF0Ukxbj6F8QRc1g/lmL4+qq1f2RL2QZwWhSX8KRDELGIQ2Xeeoc CdHhtWnhbOP9f3WnH/mp12/hoGIoslojUa3viKtV8Q2BSqf5cmw+iCKEyjnbO3XteUlifh1zT3e MG/78= X-Received: by 2002:a05:6214:5184:b0:89c:5285:200e with SMTP id 6a1803df08f44-8a43a55cfe7mr28850756d6.4.1775035696594; Wed, 01 Apr 2026 02:28:16 -0700 (PDT) X-Received: by 2002:a05:6214:5184:b0:89c:5285:200e with SMTP id 6a1803df08f44-8a43a55cfe7mr28850556d6.4.1775035696097; Wed, 01 Apr 2026 02:28:16 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae23f18sm490825866b.1.2026.04.01.02.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 02:28:15 -0700 (PDT) Message-ID: Date: Wed, 1 Apr 2026 11:28:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: msm8960: expressatt: Add MAX17048 fuel gauge To: guptarud@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-expressatt_fuel_guage-v2-0-947922834df1@gmail.com> <20260401-expressatt_fuel_guage-v2-3-947922834df1@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260401-expressatt_fuel_guage-v2-3-947922834df1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA4MiBTYWx0ZWRfX4CanMVZHKiC1 DUw/e123kz4MonIvjqiKItGtteXZzbZmOyld+o6jGgBQBr3tEamawrMAFmDMsYWo8MKHMAluJHu fEis2PVnINeQ/Pi5Tz7M9YS8BjniH36bhOQ1T4G2I214dDjGK6esWE7kmOqlwq0evA5qQjLokUR Hk2TarKgt5M0Y0ZMmXGD5I1XylKLaHMf/SM7HZEejcwqIBDPvTT0EvhOt54tdhGUq918dMqlOQT wc70T0aS8zItw381Ag8nFSsXKYMojR4ZXW7jHjyepduRL3npBF0QqWT2CLEajwQo+O2eVWodAiS h8Sg11Obf7VqB1+juM0+zuWL5pgtrvbAK1EXJU8M/prcMyaUp6cYxdIPlvLU5pGFrRo301r4It5 iFsoEZWPJ2D0Dub8ue5BOKm0ndoThuXJyp1xvXovyJqImHpSAe0LXrBbMDNGWHT5I8k9QpGkTvb LKS5yj3wj+NIM48PnpA== X-Authority-Analysis: v=2.4 cv=KNlXzVFo c=1 sm=1 tr=0 ts=69cce531 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=fMfskPNpDUH_GILrBU8A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: xa40gsqZddIHHL7IRtwzo-6Z6KUk1QvE X-Proofpoint-GUID: xa40gsqZddIHHL7IRtwzo-6Z6KUk1QvE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010082 On 4/1/26 10:28 AM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > Add MAX17048 fuel gauge support. > > Tested by comparing battery capacity readings between upstream (mainline > max17040 driver) and downstream (Samsung max17048_fuelgauge driver) > across a full discharge cycle. Upstream reads ~3% lower throughout. Both > track the discharge curve correctly: > > Upstream: 95 92 88 87 86 87 83 82 80 68 60 55 50 45 40 35 30 20 16 10 10 5 5 1 > Downstream: 95 94 92 91 91 89 87 86 84 73 64 59 51 48 43 38 33 23 17 14 12 8 6 3 > > Each pair of readings was collected by checking the upstream capacity > first, then moving the battery to a second expressatt running downstream > Android to check its capacity. The battery was then moved back to the > upstream device for the next reading. This swap occasionally caused the > upstream capacity to read slightly higher than the previous value > (e.g. 86 -> 87). When this happened, the reading was retaken after the > value settled. Ha, nice procedure! Older phones used to chew through batteries on bootup, so perhaps that could have had measurable impact as well.. [...] > +&gsbi5_i2c { > + status = "okay"; > + > + fuel-gauge@36 { > + compatible = "maxim,max17048"; > + reg = <0x36>; > + maxim,double-soc; > + maxim,rcomp = /bits/ 8 <0x62>; > + maxim,alert-low-soc-level = <2>; > + interrupt-parent = <&tlmm>; > + interrupts = <67 IRQ_TYPE_EDGE_FALLING>; interrupts-extended = <&tlmm 67 IRQ...> Reviewed-by: Konrad Dybcio Konrad