From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5E8640B6E2 for ; Tue, 30 Jun 2026 12:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782822524; cv=none; b=ufg9F/6Fv51bVdHxK0ps1QAVlFUFJVBE2CiENCiiXhMgs/Eh1Fq+qi9Oc+NzI6xvDY/FLF1XimxvqUwSV9/NhVEDB15RGtosR+A9QG5pg9nLsyqn2KKuhFAOXLJQ4DaYecJa+u35Nw0TcH1n0v+81cWvsWFjbLVLxnTsXy2WLu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782822524; c=relaxed/simple; bh=mW/QBS1QWFhNlkYNGp/xwFvmKH1UJjEnbQ981I2SMO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iPFCwCs8ihjBf7BFShdNlkB7Jkg01jd4o0p2S0Zimvh+SwT62m5mhU2UvnGY82JYjoVPsjkg2Y6mJqCXNDIFECehRJx4jUbuAIn/yJxK6ewmqlt4O5wF07u9TnqpUcB+eR3HrogA7JZHG/+dGFwSTpbyvKWUj0K7Qq375dSwjvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wr5Hj7rr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PR/Filmw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wr5Hj7rr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PR/Filmw" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n9N41605923 for ; Tue, 30 Jun 2026 12:28:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gPAZDw/mw6Phn9P0hIFKkIjfUsEicHNe79M3BF/BUVk=; b=Wr5Hj7rrdJTXAmmo nYB+chQjtFAaB7mbMqICgO98BtLMp/uQNO7tLOPh1TZ69E5DzSxxkePejzSnDbJf Iew5fPMqAAofarVozWUTykTZOZH/ZyDEUSg7r0iIN2rWbnETFhXpGP3wqYCgqXdc cXhh5iATitbl2hGRycTgAJ+5xseUTcSWR61sGtjReORlu+sop8JC3efunstQia/O TwJTw0tK9gSvIv4sb1ZU6SrH7H/uAILxlGtVZw7p9+Xx2nlRdS0Oo74OQN6mCCQC nDp2my+b5GN9GChtd1/YETIdddfrobnRYigZG+8ra/qr10Zta42jXf2YnKG5thWy wTYMIQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f45k5tb15-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:28:41 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-37fe5d16d15so3602019a91.0 for ; Tue, 30 Jun 2026 05:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782822521; x=1783427321; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gPAZDw/mw6Phn9P0hIFKkIjfUsEicHNe79M3BF/BUVk=; b=PR/FilmwyTvWjSPlvbhGNAjgrZy0W+Eo1dHV+7VI49M/yXyWo6eBWelWRS+EMPRlTL JPHRwFi6IcjA0YdGmv6CtZlgmEBxRCHF1jCyw0GBXF0+Cn2uFlimfOfRFg2IvyOTixPo a+mb/eHUTTi7kDRRR6lHMxWgdvNd84F57/Cdz8lP9xYFQgSC1tuJMs8BQqi1nlmYni6H 7pOEi0w/tpLYVCjM64ef6boEadk7F4z6v9Ohq5jnO+1hS4Wn3oJ1Ui0nIoBo0P3nbCkn JSydvHWlkWipgVfWiko5tS0MkZNVqDIljY+7cnsp8ycY5FROpL9N3C/x8Ul7dKCHX8GC cFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782822521; x=1783427321; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gPAZDw/mw6Phn9P0hIFKkIjfUsEicHNe79M3BF/BUVk=; b=Q9l1BX4lKM7u8iEl826cZkphaZdjfjvvJW841fwOqZEHHkLtUbvg68+q96kF4ZRteM +xYdhOu73Pw/u76okYN5FPF05V45N+0SXHw6ZB+iRewaj7HSjpa1M4Gtmm4S6HBs64sP uplvKICKdWgAfnj3z+/KJAUpCSxqaJW01PXLiTB+TfXHwwiCV4jlrU7DErwx+AsQ5QpG uW0xv7+0b1CmgBNOlF84bJNAMk7h4Qv7wV4Hp27kB1FZNAm7rZYyola21JEifyqn0pN/ Ng5ZZ6WUS6GpqN32Vptk6t2XPX0ohcuIiqRru1dnr3ZEKOGfyqrsrgqhB0tQc636mJH/ ofsA== X-Forwarded-Encrypted: i=1; AHgh+Rr1dWFxy508C8iU/8iL66+w60daYrnA/lsaxgBmGWnUxWLvSt4Vq2euXYpHZr+Gt3bvLOYbusyTWgvXSZA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6eoNcSj3TScox9QMQVRprQiw/8qSn7cIhXDvZuvly3tdSzBSy PvOiwfdHewfrNy2FcXyd3gRj9LRwVOk1PWgeIJSR9dBh6sMcQitvgp+KPi2+PPNF6aF+TNmkzDX Gep553pH9vp7JpwIhGKaWUkvXfEmJjCWydZ1JafFosC6/Fr7Dob3d30fn0qIQ3LmByCQ= X-Gm-Gg: AfdE7cl2lnV/Qhhyb2+aogO6/J6EZICFlzvb1h0cZIy2eMUeVWWAxDSFRbsbGE7yxsy YAOW9SjgPlH+gWWSR4v2daRtNWOItvcnppoKzjppbE9zooWe6O/mooQOBqonswTNW0b/fftUuST yGIuutI+b4qkEpmmzgfC/QbhduUu8G3y0+bIuK1aGdBUmifQ9l35sD4ERlUVjkfB5IYzFaezd8J eBQMuerSXFCa8IT9CoVVES1vTPQqQqRVjbbkwqavAk0C9elkgMPtYaKHF+8PPnpAhPwDMp2G1BI fpDYHcd4JQagdLw9h9xMSLEfLW6XywLwNQqXcQvPHIGofPXtXY4BLDi3yMvZI5id0PnBDlk3AP+ mga44uBf9FFQzePx2lyIPF7ARQLOK0Z7XeGsNxXRD4sY0 X-Received: by 2002:a17:90b:1d02:b0:37f:9ce1:cda9 with SMTP id 98e67ed59e1d1-380527daa2dmr2610353a91.31.1782822520637; Tue, 30 Jun 2026 05:28:40 -0700 (PDT) X-Received: by 2002:a17:90b:1d02:b0:37f:9ce1:cda9 with SMTP id 98e67ed59e1d1-380527daa2dmr2610330a91.31.1782822520175; Tue, 30 Jun 2026 05:28:40 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38052f32869sm1649903a91.11.2026.06.30.05.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:28:39 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 17:58:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode To: Pengyu Luo Cc: Dmitry Baryshkov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> <99eaf1d1-fbf9-4336-a13c-ae8ab789cc99@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=AqDeGu9P c=1 sm=1 tr=0 ts=6a43b679 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=vMSz-Zg_tl80unGds0wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: Awu5R4b72l44TrLjx_4BwVRsRC7i1ONZ X-Proofpoint-ORIG-GUID: Awu5R4b72l44TrLjx_4BwVRsRC7i1ONZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExNSBTYWx0ZWRfX38SfNJQv/mt+ I7IEbabOG+wLgBWVllA2RLrL7GW/FlYSJzc14D+oKBPLXjRuAT5vvS3ez5a+C/30hLhOG6qV4CR 1G1JIIguouWyl0LHOAoNXRfzxUpBdIdPLy+c/BrN913TqWIPWJ+6/RIS9tc3h0xoXbQMzppra7S ksbFIePpK1eM/Me8fwUIduPmW9n1zD7KckqbxqGpGd1XXy/RNGOZQdkBGe4BH+56cjrD9Tdt+GL Qfu3z+MGSDV35COItkZIqUiUvbzR0i2rU5STq1h0RIn4C91oGtr03tL4UXL0V7wPapegg83LixE W5yZEfaxZyh9swE8UCi9NlZjo0bP7DxwjnUwsg8eihfwVwIumyHgsQeiaP+x/WFRPcnGxzpPyCQ JwdeuTujEGzN5mel04QhWAUELdIo/sj/t3VJaCqJEWTFpSBwdUBdWWEE8MObzM4l+K94EbcVGgS uRkTdjIPynXhJKMEKGA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExNSBTYWx0ZWRfX3+ZLMtT4O5sC VRP2SgAbjIidT/LMHgEV2hU4Q4gsejleZlXwZn9J+h/aItj9InlKckdUnyutRg3z1ymuFaHh7Op M+9/HU9Qtj9R91J8fcXuHWjT/+JWHFc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300115 On 6/30/2026 3:36 PM, Pengyu Luo wrote: > On Tue, Jun 30, 2026 at 5:52 PM Mukesh Savaliya > wrote: >> >> >> >> On 6/29/2026 1:33 PM, Pengyu Luo wrote: >>> On Mon, Jun 29, 2026 at 1:36 PM Mukesh Savaliya >>> wrote: >>>> >>>> Hi Pengyu, >>>> >>>> On 6/15/2026 2:48 AM, Dmitry Baryshkov wrote: >>>>> On Sun, Jun 14, 2026 at 04:34:24PM +0800, Pengyu Luo wrote: >>>>>> Some devices (such as gaokun3) do not disable FIFO mode, causing the >>>>>> driver to fallback to FIFO mode by default. However, these platforms >>>>>> also support GSI mode, which is highly preferred for certain >>>>>> peripherals like SPI touchscreens to improve performance. >>>>>> >>>>>> Introduce the "qcom,force-gsi-mode" device property to hint and force >>>>>> the controller into GSI mode during initialization. >>>> Why to force ? You can directly configure in GSI mode. Note there are >>>> some configuration done prior to Linux bootup too. >>> >>> Sorry, I don't get it. how? I know there may be a qupfw, but it is >>> impossible for a normal user like me to generate one with GSI >>> preferred. >>> >> If firmware doesn't program in GSI, you can't have this working in GSI >> mode, its going to fail (and work with fallback). if it's programmed in >> GSI, anyway this will run in GSI mode. So why to add extra things >> without any usage ? >> > > What I can confirm is that fifo is not disabled on my device, and gsi > is definitely enabled (under windows, check the register > SE_GENI_DMA_MODE_EN), forcing the device to enable GSI mode on linux > works well. > Thanks ! if GSI is already enabled, then why do you need forced gsi ? My point here - SW should only decide mode based on register read, not enforce by DT flag. As such it's not a SOC exposed, can't be overridden by user. >>> >>>>> >>>>> Ideally, this should be decided by the SPI controller based on the >>>>> requirements. Another option would be to prefer GSI for all transfers if >>>>> it is available, ignoring the FIFO even if it is not disabled. >>>>> >>>> Yes, it should be decided in advance and configured accordingly for GSI >>>> vs non GSI mode. Because there would be limited set of GSI pipes, which >>>> will actually make must have GSI mode device run with FIFO mode. >>>> >>>> Why don't you decide prior and configure for GSI mode ? We don't need to >>>> change the current logic of deciding FIFO vs GSI. >>>>>> >>>>>> Signed-off-by: Pengyu Luo >>>>>> --- >>>>>> drivers/spi/spi-geni-qcom.c | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>> >>>> >>