From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82818344D82 for ; Wed, 25 Mar 2026 11:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436470; cv=none; b=rmCjwA0KzQliVnrN9W4M2RNUvOS0U55STfepZ6ajwEwV++a/Eu3WxwFm1hmj9ynRkI5LawhEvy2/NqKflIlnWOaram0CgRZrPtQDzfAvA3F4+N1JIZJ1ZLC7k+n9LCUOAxbp28sDmsDeBSVtKOW1vmq/maC9mACWdeF3d1mtKo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436470; c=relaxed/simple; bh=rqGnXxoqdAugxHvA6CzEp0CYwxmp8z2ymbpkYHo4E4U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nhYE+azN4w/PbDbOvtT9D6vXtwlYO9ZddWIjGD9vhI5BM5jxR2ToC4U3RBnvSyvAy7vRdtwbn/Dlb31JYUIi5HCxYc2tpkI4YJ0Jid7KzEFVSWVKdViInkVRuRV2j2TR9jpKA7znwVWHdL226VQhCDb/j00xGXGuD0dlJBuq6cU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LipQJGIy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N8xUJWar; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LipQJGIy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N8xUJWar" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62P5WdDL2075395 for ; Wed, 25 Mar 2026 11:01:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hGtV6zDVSwgBPYnSRKOHJUG196PP0EnvE8OiixR/6hc=; b=LipQJGIyEmtS1R07 LHh+c2e4syDdNrMrv2NvjiCjcAF2MONhFi5dc3hgYPYo5/C8RrBaWe2r1zMQtRhm 4pD0w3WG0/bEtJNQp4s2DkER6XXXfQQUrd1vBHHytJs12hzbNBTuSQnE5Qizc7K0 VVVx/8qC578XCEhe/G1c/MqORtVpNddgv/S7ZSAQDgljZ/aCzaIJLArBRMgmiOpn xSh8nfQstCmJvwqH2mitLpKbYGzCQi4zoO4OXop+O3BRtP6ggzIPq13GmXSUK0+W Ca4xqIrKbkGxTg48/xbiwoIshr4qGEJBGRjoOpM9rivOdk97LhD0cev78qAARyuv uAw3kA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d41412tfy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:01:07 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-60274569cf9so836462137.0 for ; Wed, 25 Mar 2026 04:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774436467; x=1775041267; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hGtV6zDVSwgBPYnSRKOHJUG196PP0EnvE8OiixR/6hc=; b=N8xUJWarQLBFlDFzzXErOrDpvB60X8LO189DcsW7qIapemhOcdXylTRPjdtwU7vL8b XT++fn+g0vArKMWsad26OIJg8W/DnrGpfWFcGrDfaGvbM6z4yt4r3TLciPRQHCDxXSap 6N0tdVrGLYUcGRhEweAfPhKyIs0nGnug09gFwS6FrVGK8sjtPFFolltUhERXtBXD2c12 v1K3BGd4Iq8pBkIcqKPaAtiOB1rqiO8ZNnQywoMlw+tg/CqpIyLbOGDP8tNHX9EfD/Ah pWlhOmiNyYc0X9ls1QnaQ+ruKveRjiZz05spzxuJhL6otDlE+Z+z3jxPN8ZbmfYyaeyh 7nOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774436467; x=1775041267; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hGtV6zDVSwgBPYnSRKOHJUG196PP0EnvE8OiixR/6hc=; b=ogcO5FHuWTJdCWQVV3E3RK1Ob5pbLDD3o0wkkx/PEN4lkiUhmO7JzT2HVILIDpHyh7 iaECfpyAvLl9CMMsbpbqcictKBItDy2VM11wvic9xOkywAS4A0FsGekh/B4EU36tvECe Dsr27xap6qxYc2usKqHTYcR3Juim91EJPk0+/O0HRS+uPSx8L3iICIXWigKP7F+3MS1T MKfwku/YyN+EmogWFiKIwFacdK/Bb85Mp5cKTcJ+ltBM0EbqcWyIlWZtv7j2bPYeI1qy beAHIA6+hn48T9kGzqhD92NOIvSU0GUgid9Nr17cjOGFvHEmN5LkkwCyR6iSiMm+tqEi ygGQ== X-Forwarded-Encrypted: i=1; AJvYcCVB5QUmpyYdk0whtO73ZQT/Hq7Rcf69OVg6Tnn/W5r6DYTGU1vwQ+91HXCkAFeHolfHdciLMqeJmM6YQ3E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8V/pwQJ+PhTbKO8h2W9jBFM6a1xjoRdV10VPEO6jn660yDjg/ 6o4Pc9yB1GobXoCHyTYGS6tr/0C+//wfUPbCLg/8xgIC6HwqYesRSWogNtJw7AeuqhJ2Gay605h RLS30CoJWhiXo++UCdrtPVTGKb28Euj3x9+sO8+qNn3EdJuw0N8rwNFZ1io7FqXTclb8= X-Gm-Gg: ATEYQzzEomQux6R1SY0zQyIJgOe68GNa9ydcQfKyxPahC1WtKYAdhyuKq+/HIu+dHsj SMcezFro5bgt2XZHl0oaTTjVlNYEKhvpz20KsvDPCWbVurqcpgNRRHNQsAO+TJ+m/oNvuNR7FHf ERX74J43Oo/3Ym1WfBqvjC+BPE53IYfeXVPsBOTdbIJU507KrskM/j6OUI0qIPLzwf9fzdJ4bnO 6aje31unh/4N6N1AD/WZB+EMhpHGWc3/5H/FUADAPJ/JWK9Bu8rQmwtu4zEhHgJN+1K552m/o/J vBV7Jdh8kZHopy1kfdm7gZTX3u8/KmaXD9hqDRJ8lYMX8mY7JCGuDATtUnPKZefjBDiC8JMABVC SHsvnEln7huvlCdJl7kkS8c/Tt2QO7G07boTHGflX40mP825H66DMD4Ybl8kJiVp0tp5CrtST2g rgvoI= X-Received: by 2002:a05:6102:3106:b0:5ff:9d74:9677 with SMTP id ada2fe7eead31-60387269985mr490673137.3.1774436466790; Wed, 25 Mar 2026 04:01:06 -0700 (PDT) X-Received: by 2002:a05:6102:3106:b0:5ff:9d74:9677 with SMTP id ada2fe7eead31-60387269985mr490634137.3.1774436466209; Wed, 25 Mar 2026 04:01:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9833871003sm785427466b.54.2026.03.25.04.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 04:01:05 -0700 (PDT) Message-ID: Date: Wed, 25 Mar 2026 12:01:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] interconnect: qcom: drop unused is_on flag To: Dmitry Baryshkov Cc: Georgi Djakov , Konrad Dybcio , Bjorn Andersson , Luca Weiss , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Brian Masney , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260323-msm8974-icc-v1-0-7892b8d5f2ea@oss.qualcomm.com> <20260323-msm8974-icc-v1-3-7892b8d5f2ea@oss.qualcomm.com> <3d75f9fa-f744-4437-8c68-16ca751193ae@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fOk0HJae c=1 sm=1 tr=0 ts=69c3c073 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=14PZQ2iapyptJwwRuREA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-GUID: x20quDrwzomRVOnhXjBDW6lTZY3zMjPS X-Proofpoint-ORIG-GUID: x20quDrwzomRVOnhXjBDW6lTZY3zMjPS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA3OCBTYWx0ZWRfX7fFRDaTRQpfY AT6425T93FEUUSnErAUiw3tULzCovMwf+v1XAjx4sAVreaWxA50U99D8doQKatQa5wUJNQnCZ1i QF7p+2r8zNHTrtM85sBXzlDZRsihSLyZIONpruatavdkAOG6P8krghOK7o0b4k6aryarTNBPEth t8/2f6EizKv08Y1BAZI67g24ez0i1EKtTRUa3qCv10cegQMhtXO4Vl5voFJOTehRTRCgWViqC8y Mz7axT29l77z4gSmYpivXg+5JaPKIiVw49uZJt18I4kKrur9fvXcWAFOehh4mo2jOHquyyCjrRc taKA8EXsQDY/p5DqjOTfUk0rNftOKHwIKBA01TdQ2mJQBRmAOtiOdxzJXxMsNA4au5H37GpF0ul Zzijy5umeM2HWb9MdYrAWpBu5Qj0iqdnzKqHwY1X4B8jNuYHwnqk0men0NQNmLaPKueu6EcANaW sol/XWJ7jNGkRo3woCA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250078 On 3/24/26 12:12 AM, Dmitry Baryshkov wrote: > On Mon, Mar 23, 2026 at 11:26:47AM +0100, Konrad Dybcio wrote: >> On 3/23/26 2:17 AM, Dmitry Baryshkov wrote: >>> The commit 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface >>> clocks") has added the is_on flag to the qcom_icc_provider, but failed >>> to actually utilize it. Drop the flag. >>> >>> Fixes: 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface clocks") >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/interconnect/qcom/icc-rpm.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/interconnect/qcom/icc-rpm.h b/drivers/interconnect/qcom/icc-rpm.h >>> index f4883d43eae4..3366531f66fc 100644 >>> --- a/drivers/interconnect/qcom/icc-rpm.h >>> +++ b/drivers/interconnect/qcom/icc-rpm.h >>> @@ -51,7 +51,6 @@ struct rpm_clk_resource { >>> * @bus_clk: a pointer to a HLOS-owned bus clock >>> * @intf_clks: a clk_bulk_data array of interface clocks >>> * @keep_alive: whether to always keep a minimum vote on the bus clocks >>> - * @is_on: whether the bus is powered on >>> */ >>> struct qcom_icc_provider { >>> struct icc_provider provider; >>> @@ -66,7 +65,6 @@ struct qcom_icc_provider { >>> struct clk *bus_clk; >>> struct clk_bulk_data *intf_clks; >>> bool keep_alive; >>> - bool is_on; >> >> Hm, looks like the clock vote is kept all the way from .probe() >> to .remove(). I wonder if that's really what should happen.. > > Well, it's probably up to you to decide. I've a bit lost my way in the > vendor's adhoc / bus / etc. code. > >> >> That's what drivers/interconnect/qcom/holi.c does on msm-5.10 >> >> Maybe "iface clocks" are only needed to execute a ->set() on a node? > > Hmm, I don't know. AXI clocks seems to describe the clocking between the > NoC and a particular device. So maybe it's required for as long as there > is something using the NoC. I'll keep this on my infinite todolist Konrad