From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DAE83B2FC1 for ; Mon, 23 Mar 2026 14:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277384; cv=none; b=h3PGJm+AEvJND7asBC7dCrCkxXOBMFE+7xsUj5KovcWYcRlJ58v+N9V1YUar8wbeRf57Ll5KiHpYQQ2RahGheUWx9N+0x6nt6YCLpJyJZugfAHxF8oKDkQpt9Dz1TOQSrY329kssxOhvJpOtXhGZiE6S2pw9GUiyyA8HCl/1dD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277384; c=relaxed/simple; bh=0/r/G+0z4yh01mKu1u+OVKk1NLi9FxpmQdTT7aSQh/o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NRC75X3pPlIqkmAD1AP3UNUaf5vpZAuj+Ndg6tnFmcY0xlbSPqXZpfre9x9v9+066WgPb598V5LGf7WASZmGQijwYBwsy0FCm5Kw91fuhqrG+qq6UY69vQ/7/MSfiOQ2hpf/OJ16HI2Rw73gBRQOsZ8LGblgRKQ62uGr294wOns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ezOkwpGR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ACNrOpHu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ezOkwpGR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ACNrOpHu" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ND6VEg1627050 for ; Mon, 23 Mar 2026 14:49:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XFD/0D7t3HkahIJrCp8Wcg2mwyN5dY4QTfenxFKZJog=; b=ezOkwpGRKkMa0jJQ o0RGNwdMo4ZjWPRwhMGTRwDkbKdetlyG3pRb4OwKYDar+Wm5YlhoZHsb8rXH2w7z CwC86ZOqIPd3Qd0uo2giPyrmXoOmhb7v9pJFLu0Ja5cu4C/23LaZtu8AvMGVQs0v Oa0/UFVX0rUGJEtDeCJ7AMOekaJBFSCX5aSH76DqPvHEA/TVjBX+7KquWaW1CVbr 4zsyRdOKinY9FncviMcfLlQIvhBlPYzj7v/kSTYzFJHZTRxj/4cmneZq8UqFfq7n WJVnUBhudJv3mtGfKfoUhKe1GE65soFR4xeGc/bXDWdKgURnpuxAXCqdnJZo4cmP ze/VQg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc1g2s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 14:49:42 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b32feb719so27926371cf.2 for ; Mon, 23 Mar 2026 07:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774277382; x=1774882182; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XFD/0D7t3HkahIJrCp8Wcg2mwyN5dY4QTfenxFKZJog=; b=ACNrOpHunII8fKwpfxUvbKe6EdZnsJqmbuMzs67IK55vhGUpaXKZRULxMykusshk6K 53RUyPKN3mz9S2jZ/QU7HHhGzIgeAdbE0Je/QtalZ8gJavaNaZsZIEkwvGI5qe88BWAF BqbIc1LMx5M/0yHO9N+7Z1Z12Nkd68rZ0/bJiS+Z61DGoqs27jBjNezAqR4XjAY4RNta zW6TzSJ8533c6h3baF9+hhYyWkwDNeTuXOdFts5ebQeP8F2STXmMnGfAyZlbV2ovZ0M1 RSt8Z5UwAkAO25UjDKUz25fJ8kc2kvSXVIlpGwn3gHXYrMjiFiOwi3me9JhQyyNegGdg y0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774277382; x=1774882182; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XFD/0D7t3HkahIJrCp8Wcg2mwyN5dY4QTfenxFKZJog=; b=nH8vnPCPW9XNkGdT7kdzb4HmZpGeVpy4Nlk1RhW1IWulna4ftvnYgZ03GEiTlBRs/r AyMFFq/LsrpLE+5hmb3f8KJaOk9i7FRP3cXrwBd6rPyxQu5qyLQJOBkjhCykHuz5/Nw1 MY8kxhpI3QUnB8YjGVnxsOCc8c7vFYroX8vJr7q3uJIaKtl0Uv6+hRyPIhJYeDTdfRsG 7upjzkxkWiSbp+SiN29X3Lie6xl6/005buK27gLQl97KoK3wnQ/+lNKKiiaH8eByxekl 67Tj1AFrMpft+R/GCJmeKR9o3tjU5+HPlS6+39t9Wpmvq/ASfTpqZhi2hQDNPQeIewQ3 Sldg== X-Forwarded-Encrypted: i=1; AJvYcCWT6z12FcfYWPjONYdUmXq2xnOqosPvTJksUhMiZdd4OFcgww94LaUaMDnnMkzX9oopx/Y5qt6Pazg/Foc=@vger.kernel.org X-Gm-Message-State: AOJu0YwAwd5Z9etbCw9Ua91pTbvuyRWuFPklgzlfChoDz+SOTfEhg7fV skVAszE3hhpfDL7ygRjYlU7fhQEluUcCsxeTtmjO4wR5aS9jNRqulEk7t0swtAze5vKYGg88gUs HEE3/QO7iYYkcL4lmlf4GEiPpTVBbuJGfxvbYaqOrOVviXKFzuRYiwmOfOxDkEU8DqxI= X-Gm-Gg: ATEYQzy5vtCldR0cvOWsYzS1atznR2GFzQXeiHC+gfjZ8inzkhLIhRyl3N5q4LcR9Gr u4rrWTpnRFrT0dsirle2ybP9Yy3E1wLY8Pe5kT2R0hS8lpEUpN4au9SMU2odQRCFytpc1Nc5eHz tsk78eyiXIA9AyqpFG5xx0HyW14cqImuPA0HfutpzW5Mld5kVvb/yuXhrv5uiHneki3YCL8Rlc7 BKOJjj4JBb1IKZd4OmqlkZnHc9q8z7Ptgg2iLafH1BGFQMhXgesxHWwiiBTH3xtoARTlo8wKKAZ s1xwbdCyVYcpCHcfzaFm9K3R08fPue9E58aQFSGf0XJDFDzJXHN8TLa4Xp8YaGEPd1fQJlrkndf +nW5sgm5hqmNgof+7sb2Yc1puX8n+g2QpzSWJlT8Ch1+nDJHbjdonUdN+yfpjC94Rw2ZEQr+mbC AEMEQ= X-Received: by 2002:a05:622a:4647:b0:50b:6b21:2a80 with SMTP id d75a77b69052e-50b6b213658mr10112961cf.1.1774277381544; Mon, 23 Mar 2026 07:49:41 -0700 (PDT) X-Received: by 2002:a05:622a:4647:b0:50b:6b21:2a80 with SMTP id d75a77b69052e-50b6b213658mr10112421cf.1.1774277380803; Mon, 23 Mar 2026 07:49:40 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f42f0dsm505750466b.12.2026.03.23.07.49.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 07:49:39 -0700 (PDT) Message-ID: Date: Mon, 23 Mar 2026 15:49:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Add glymur BWMONs To: Bjorn Andersson , Pragnesh Papaniya Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com, pankaj.patil@oss.qualcomm.com, rajendra.nayak@oss.qualcomm.com References: <20260302-glymur_bwmon_dt-v1-1-f4939d75bd47@oss.qualcomm.com> <2d6d813b-b2e7-408c-bf58-86d25859bb40@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c15306 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=T3UWdygilXLZWxFm05IA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: PhVmIhpijrZDVHToC0Ty7IQT5HpPSyum X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDExNCBTYWx0ZWRfX1LORbI+/h4Hj TLdENky6KzbggS9nbgf/kVKfqHuPFbvITZCirQI14rDeF5YHRbOTTlkpki+L77FaxHrJT3PYP6D NoGSdOPPx32uVNw5ca4tdeEkkqAG9uKMr8XwskX2m72EaJ9Pz9/prgHIFLi8h8qk+hEEgFyBEh9 tV+FUhBW0ZGbgDysZ9F5YZpNjIIVUcporV25AvCafG0Q8huOpGTH2/qVf7NC+VS2/gwNFK+LQ7l LCC4C6UG9z5lhIjkdy51ghynW05qNKVD67/ayRWS4aVA6700CFJWAb9xWnwvrYuch1cwPuMEAgz NhQp9pNwt9G0J8e2TMgW2GhF3T+3w59DGMwTUP4VKq7SjpVq7aWvRbMJA5sapUd6s0GfeaXgnxH /IYOxL07proSyqx2kA+2OekBcvAJEqIIx4v2BssVEJmkO7ANthSflFod5Lu4bV5nVajpAYZYFm6 vBzGIVuednlsurW0Jsw== X-Proofpoint-ORIG-GUID: PhVmIhpijrZDVHToC0Ty7IQT5HpPSyum X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230114 On 3/23/26 3:21 PM, Bjorn Andersson wrote: > On Tue, Mar 03, 2026 at 05:52:53PM +0530, Pragnesh Papaniya wrote: >> >> >> On 3/2/2026 6:27 PM, Konrad Dybcio wrote: >>> On 3/2/26 12:46 PM, Pragnesh Papaniya wrote: >>>> Add the CPU BWMON nodes for glymur SoCs. >>>> >>>> Co-developed-by: Sibi Sankar >>>> Signed-off-by: Sibi Sankar >>>> Signed-off-by: Pragnesh Papaniya >>>> --- >>>> arch/arm64/boot/dts/qcom/glymur.dtsi | 87 ++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 87 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >>>> index e269cec7942c..fd947b1a17dd 100644 >>>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >>>> @@ -2264,6 +2264,93 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ALWAYS>, >>>> }; >>>> }; >>>> >>>> + /* cluster0 */ >>>> + bwmon_cluster0: pmu@100c400 { >>>> + compatible = "qcom,glymur-cpu-bwmon", "qcom,sdm845-bwmon"; >>>> + reg = <0x0 0x0100c400 0x0 0x600>; >>>> + >>>> + interrupts = ; >>>> + >>>> + interconnects = <&hsc_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY >>>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>; >>>> + >>>> + operating-points-v2 = <&cpu_bwmon_opp_table>; >>>> + >>>> + cpu_bwmon_opp_table: opp-table { >>>> + compatible = "operating-points-v2"; >>>> + >>>> + opp-0 { >>>> + opp-peak-kBps = <800000>; >>>> + }; >>> >>> Can these values remain unchanged vs hamoa? Glymur has more memory >>> channels (as reflected in the icc driver) so the values send to rpmh >>> will be a third lower >>> >>> Similarly, hamoa has roughly the same values as kona, which has half >>> the channels >>> >>> Konrad >> opp-peak-kBps is proportional to bus_width and is calculated as follows: >> >> opp-peak-kBps = (Hz * node_bus_width)/ 1000 >> >> All the existing targets do the same, since bcm_aggregate() in >> bcm-voter.c divides max_peak with buswidth. >> > > So if we make the bus 100x wider, we still have/want/get the same MB/s > throughput? Right, that was the question I tried to ask originally.. glymur ebi node has 12channels, 4-wide hamoa has 8c 4w sm8x50 has 4c 4w bcm-voter.c then does: temp = bcm_div(node->sum_avg[bucket] * bcm->aux_data.width, node->buswidth * node->channels); agg_avg[bucket] = max(agg_avg[bucket], temp); temp = bcm_div(node->max_peak[bucket] * bcm->aux_data.width, node->buswidth); agg_peak[bucket] = max(agg_peak[bucket], temp); Most notably, the channel # is only taken into account for avg votes (whereas the BWMON OPP table only has peak votes) Perhaps the question worth actually asking is, whether the code above is correct, and if so, why that's the case. Somewhat frustratingly, all downstream kernels that I can find seem to corroborate that. As for the immediate, this patch is indeed correct in that it creates the expected behavior. Konrad