From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62118C352A1 for ; Wed, 7 Dec 2022 17:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbiLGREB (ORCPT ); Wed, 7 Dec 2022 12:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbiLGRD7 (ORCPT ); Wed, 7 Dec 2022 12:03:59 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC095654DA for ; Wed, 7 Dec 2022 09:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670432585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOQIidfQ3sbnFLjha2rLDG/XELirqixmyLKRkZZW63g=; b=PjIL3S5WAw2nrg0ZVHtfyvf/COeQBHlF2fxQ67vpsQIFJUhLmkw/WRG87qO9ENoIDRg01M 14BiseAQEY0rQe1Byia7jBhof+QVqs4kMljzcKHknFTf06I36EHigQCw7h7QQvitV5KJUa JtmumD5Kw0fDOJzQXOgQhXT9OzS/6Gs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-mGiSbEM7NoeOdPuV-rm_ww-1; Wed, 07 Dec 2022 12:03:04 -0500 X-MC-Unique: mGiSbEM7NoeOdPuV-rm_ww-1 Received: by mail-ed1-f69.google.com with SMTP id h8-20020a056402280800b0046af59e0986so10606563ede.22 for ; Wed, 07 Dec 2022 09:03:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jOQIidfQ3sbnFLjha2rLDG/XELirqixmyLKRkZZW63g=; b=hHrv5B9LrbmRXYjeDTyP2vWBqTcYwjuRFv/Xuwlh9UDtlvvV0vFElGy3ygykIP5zW1 MW+6sB6e/J6/DO9/4eK1khaa/aEt1OtonjQYwKSc+BurzoHSPcd/1dQHfaAU+ytJdi2w p0eynCezT6h8e92K5vo+pSNXedEtIC5sYO/BxbK9TggwzvgNs3qa1DiOnUs6L55mkN2Q FdkN/SIZ6Rbw0rEOXuwLYfRVsoZ3ohUaGqwBQqeYyFjJkzfagJP0pIEgFEbDAlsM9KqW oDnysALd5mOweD6QZ8fuxR0RryY9LaMmnVaeZmzOzbavGK/pWqZt518IYUSyeugV9f6K 1Hsw== X-Gm-Message-State: ANoB5pkZKYip8w/MbLT2fjvu4Jz8g85QbCfNugoENq/xX3RfrsnNbpJC vDbcJNbU5GalRslRcOAeGQPX1McYFoPewGfvN9bSu+ddGjXBjb3+DEEeDSXIELk/6n3usr1x/fK wdrqmHWR21zspoTuF11hzBuK1 X-Received: by 2002:a17:906:d782:b0:7bc:9d14:a2db with SMTP id pj2-20020a170906d78200b007bc9d14a2dbmr45551820ejb.770.1670432583348; Wed, 07 Dec 2022 09:03:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf4hY1hd3kXz3CHOlo4t5MTSfkJs8W9NDntOh8GHLT7DUWqJ7CgOGM7kz24jRb0n5QnPy2AAQQ== X-Received: by 2002:a17:906:d782:b0:7bc:9d14:a2db with SMTP id pj2-20020a170906d78200b007bc9d14a2dbmr45551810ejb.770.1670432583144; Wed, 07 Dec 2022 09:03:03 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id vs19-20020a170907139300b007bee745759bsm8712515ejb.20.2022.12.07.09.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 09:03:02 -0800 (PST) Message-ID: Date: Wed, 7 Dec 2022 18:03:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] drm: Add orientation quirk for DynaBook K50 Content-Language: en-US, nl To: Allen Ballway , LKML Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Maxime Ripard , David Airlie , Maarten Lankhorst , Thomas Zimmermann , David Airlie References: <20221130170811.1.Iee9a494547541dade9eeee9521cc8b811e76a8a0@changeid> From: Hans de Goede In-Reply-To: <20221130170811.1.Iee9a494547541dade9eeee9521cc8b811e76a8a0@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/30/22 18:08, Allen Ballway wrote: > Like the ASUS T100HAN for which there is already a quirk, > the DynaBook K50 has a 800x1280 portrait screen mounted > in the tablet part of a landscape oriented 2-in-1. > Update the quirk to be more generic and apply to this device. > > Signed-off-by: Allen Ballway Thanks, patch looks good to me: Reviewed-by: Hans de Goede I've pushed this to drm-misc-next now. Regards, Hans > --- > > .../gpu/drm/drm_panel_orientation_quirks.c | 20 ++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > index 52d8800a8ab86..14f870fb2db04 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -30,12 +30,6 @@ struct drm_dmi_panel_orientation_data { > int orientation; > }; > > -static const struct drm_dmi_panel_orientation_data asus_t100ha = { > - .width = 800, > - .height = 1280, > - .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP, > -}; > - > static const struct drm_dmi_panel_orientation_data gpd_micropc = { > .width = 720, > .height = 1280, > @@ -121,6 +115,12 @@ static const struct drm_dmi_panel_orientation_data lcd1280x1920_rightside_up = { > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > }; > > +static const struct drm_dmi_panel_orientation_data lcd800x1280_leftside_up = { > + .width = 800, > + .height = 1280, > + .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP, > +}; > + > static const struct drm_dmi_panel_orientation_data lcd1600x2560_leftside_up = { > .width = 1600, > .height = 2560, > @@ -151,7 +151,7 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"), > }, > - .driver_data = (void *)&asus_t100ha, > + .driver_data = (void *)&lcd800x1280_leftside_up, > }, { /* Asus T101HA */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > @@ -196,6 +196,12 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Hi10 pro tablet"), > }, > .driver_data = (void *)&lcd1200x1920_rightside_up, > + }, { /* Dynabook K50 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dynabook Inc."), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "dynabook K50/FR"), > + }, > + .driver_data = (void *)&lcd800x1280_leftside_up, > }, { /* GPD MicroPC (generic strings, also match on bios date) */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"), > -- > 2.38.1.584.g0f3c55d4c2-goog >