From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607B2C433F5 for ; Mon, 27 Sep 2021 16:00:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A7C261041 for ; Mon, 27 Sep 2021 16:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235410AbhI0QB7 (ORCPT ); Mon, 27 Sep 2021 12:01:59 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33967 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235344AbhI0QBq (ORCPT ); Mon, 27 Sep 2021 12:01:46 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 294B35C00CA; Mon, 27 Sep 2021 12:00:03 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute1.internal (MEProxy); Mon, 27 Sep 2021 12:00:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm2; bh=eh67QKmwClsy9IbTfPVdRQKHeIBl iV9TgpWJWy117KM=; b=K5CtSsMuBalnM6897s2eWHVH9+hZcDmaCXhYWOHPxRRG hG5CybuXTAIOPbaWS+Jryw1bah/jpa9UUPzGp5Vnu56I948lGsZn/zYUFT9ppky2 K656rntCxEuGqbl+4affBOynqoM/rhxpdvue8LXAouC3/TH6keZ3Mp/8umTE6mfy LP0kDYweLMUomZFliYQRPSkIbTvWNHq7Kyt7kLpBU7Usq/DYC9pjvUR9zs8g+rfB 39+Y4PfNT9VuJxCNq9M+Nxb85faJKbL59yWr1bmJ1yVDAeiKmCN3t1S4X5TPSOTg EmzRk54G5XvIc0CV0FwyTfQ2rzhIwJXiebpl2I7Hug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=eh67QK mwClsy9IbTfPVdRQKHeIBliV9TgpWJWy117KM=; b=kyA9yX+AEkSljXFw9pRcxE UHbrB1t6fKm/QXy2Poa4DXkGxuAOB0jIjEIfqlvJQZZpC5mMPTHSBpB6oQ8LDdkL UZT4eVVCUYXk0vDp9nt75y73E44g7kcBXECJB4yw0Inyc3TUeR8WB27S0hdeIgnk dRyM6nU26lFwNeKnaxjbjO3BAE+RBsu2+uNeNcsxAsu1EbisnOSozc/7BE1HNQZf xLnwLDqPU812yrbwoZ1BZuaNd4eTsRda83bS1zK0KizunOxNXJOR3gQPnaASa+2I kqq+oE2X4+gsaIvcocs0QmebB4lcFflMsRwATDrSq8cSwWs8RgInEqa3QejC8cig == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejkedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpeevvdegveduvdevvdfgleefgeeivdegheeiuedtleevvdeiveevleejfeev tdelheenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshhvvghnsehsvhgvnhhpvghtvghrrdgu vghv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id DC14651C0062; Mon, 27 Sep 2021 12:00:02 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1303-gb2406efd75-fm-20210922.002-gb2406efd Mime-Version: 1.0 Message-Id: In-Reply-To: <20210927154306.387437-1-kbusch@kernel.org> References: <20210927154306.387437-1-kbusch@kernel.org> Date: Mon, 27 Sep 2021 17:59:40 +0200 From: "Sven Peter" To: "Keith Busch" , linux-nvme@lists.infradead.org, "sagi@grimberg.me" , "hch@lst.de" Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, "Orlando Chamberlain" , "Aditya Garg" Subject: Re: [PATCHv2] nvme: add command id quirk for apple controllers Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2021, at 17:43, Keith Busch wrote: > Some apple controllers use the command id as an index to implementation > specific data structures and will fail if the value is out of bounds. > The nvme driver's recently introduced command sequence number breaks > this controller. > > Provide a quirk so these spec incompliant controllers can function as > before. The driver will not have the ability to detect bad completions > when this quirk is used, but we weren't previously checking this anyway. > > The quirk bit was selected so that it can readily apply to stable. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=214509 > Cc: Sven Peter > Reported-by: Orlando Chamberlain > Reported-by: Aditya Garg > Signed-off-by: Keith Busch > --- > v1->v2: fixed logical bug checking the quirk setting > > drivers/nvme/host/core.c | 4 +++- > drivers/nvme/host/nvme.h | 6 ++++++ > drivers/nvme/host/pci.c | 3 ++- > 3 files changed, 11 insertions(+), 2 deletions(-) Looks good to me, on the M1 with my out-of-tree driver: Tested-by: Sven Peter Thanks, Sven