From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E37C00140 for ; Fri, 19 Aug 2022 02:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242604AbiHSCh3 (ORCPT ); Thu, 18 Aug 2022 22:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230441AbiHSCh1 (ORCPT ); Thu, 18 Aug 2022 22:37:27 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F206ACC308 for ; Thu, 18 Aug 2022 19:37:25 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4M85Td3QV7zGpg4; Fri, 19 Aug 2022 10:35:49 +0800 (CST) Received: from [10.67.110.176] (10.67.110.176) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 10:37:23 +0800 Subject: Re: [PATCH -next] mtd/ftl: Fix memleak in ftl_add_mtd() To: Richard Weinberger , CC: Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , , References: <20220715071105.2321311-1-cuigaosheng1@huawei.com> <6733eee6-bfb6-7ee9-1331-2a739520fcd5@huawei.com> <1160016027.119085.1660805967979.JavaMail.zimbra@nod.at> From: cuigaosheng Message-ID: Date: Fri, 19 Aug 2022 10:37:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1160016027.119085.1660805967979.JavaMail.zimbra@nod.at> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.176] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > There seems to be a problem with your caps lock key. ;-) I wil adjust my caps lock key, Thanks for reminding. > Is this leak observable via kmemleak or such? > I always thought ->remove_dev() unconditionally do a cleanup later. When I'm working on other issues with mtd,I needed to analyze the mtd driver initialization process,during reading the code, refer to other driver implementation，I found this problem, not kmemleak. Thanks. 在 2022/8/18 14:59, Richard Weinberger 写道: > ----- Ursprüngliche Mail ----- >> Von: "cuigaosheng" >> >> PING > There seems to be a problem with your caps lock key. ;-) > >> 在 2022/7/15 15:11, Gaosheng Cui 写道: >>> When add_mtd_blktrans_dev failed, partition's memory will be freed >>> by kfree, but there are some structure members that are allocated >>> for memory independently, such as partition->VirtualBlockMap, >>> partition->EUNInfo, partition->ZferInfo, and partition->bam_cache, >>> so kfree(partition) may cause memory leaks, using ftl_freepart(partition) >>> will fix it. > Is this leak observable via kmemleak or such? > I always thought ->remove_dev() unconditionally do a cleanup later. > >>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >>> Signed-off-by: Gaosheng Cui >>> --- >>> drivers/mtd/ftl.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c >>> index f655d2905270..200271bdc7aa 100644 >>> --- a/drivers/mtd/ftl.c >>> +++ b/drivers/mtd/ftl.c >>> @@ -1031,6 +1031,7 @@ static void ftl_add_mtd(struct mtd_blktrans_ops *tr, >>> struct mtd_info *mtd) >>> partition->mbd.devnum = -1; >>> if (!add_mtd_blktrans_dev(&partition->mbd)) >>> return; >>> + ftl_freepart(partition); >>> } >>> >>> kfree(partition); > .