From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D08CC433FE for ; Fri, 21 Oct 2022 12:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbiJUMyU (ORCPT ); Fri, 21 Oct 2022 08:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbiJUMyQ (ORCPT ); Fri, 21 Oct 2022 08:54:16 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF75D267792 for ; Fri, 21 Oct 2022 05:54:13 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id fn7-20020a05600c688700b003b4fb113b86so1944523wmb.0 for ; Fri, 21 Oct 2022 05:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dcJ0BXzywjnrhti2p9MqhHIKm9sRkuR/9GbeUPAwfiI=; b=wX+jp2ux54182Z8x2Qwm/qwDyhMnic5dnmOdyq4OJf4qq+urYKyfHlPxL/in0oa5oF 4qLB2JlpciF4ApNRMDcWA7A4cyvRRbOdo0Lc3VCE9MEJ5VvAeQgBhrh7agYl9OS1dIef aj7xwk1SLPArT/0Nw7IMxsWhui2uWtgEl5krn5a38S3qeA4MPuGW1HrdF6BfPOJPQXgT sl3UZgW1GejlPA1sde8euEY8rnngkUHgXYVI88BzrsfK71/jJZq0c7XYMmlfQAwuadSM MalxMQBacmlBQDSQ7Y+5HuKVWIEb0gGqAUYGfWT0CM27tWmu1lMpCo53wxLxx3AQ0iEk fwQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dcJ0BXzywjnrhti2p9MqhHIKm9sRkuR/9GbeUPAwfiI=; b=jN1oHqBnnk03MIFymEl+TSsY7Qj44Gr1bb1xKU87Kqq9AJb67rE2/nBnyZOc6TYgAM vTf1t0NGo+Lx9bfFhGB6K1BdXU4hXHCYHFAeZWpZwagf4GHysH0hFVAzkLoFaM1g0KwP pVHq3EVxaF4aZ1ahic8p80jtIOrS5SFTnOSTMp67kZu8p3vcL6mjjRPfOGQ9RwR7r1aV 6qVvYjiRv9CGopHLFtBIpz6Y4KXQnxrmalhq9/wACszuUT2Dta1Z3zZHzsBrCU7wgmU9 KSq7Gt5dJbTQ2mK4Ya9EHcFIEMQquQya3PvhBw4bRuByJrjFhoh3oNngFlPbEyAogJUR zPPg== X-Gm-Message-State: ACrzQf2BZnGYDsqoB5lMVWYL+Yd/Edqh96rFNgKnLa54uodDUlqB+CWP V8dw+avAyRaFjtVN+feXiKgLRQ== X-Google-Smtp-Source: AMsMyM6kt3xg2Xdg1CINtQr1rmLE0ZAUwFgzhyCyK+jU6LLz4X4K28erCFd4qZOffTf1L/Q7a3BJYw== X-Received: by 2002:a05:600c:198d:b0:3b4:a62c:a085 with SMTP id t13-20020a05600c198d00b003b4a62ca085mr32345777wmq.140.1666356852156; Fri, 21 Oct 2022 05:54:12 -0700 (PDT) Received: from [192.168.0.20] (210.145.15.109.rev.sfr.net. [109.15.145.210]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003b4868eb6bbsm3033961wmc.23.2022.10.21.05.54.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 05:54:11 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 14:54:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Content-Language: en-US To: Krzysztof Kozlowski , neil.armstrong@linaro.org, Mark Brown , Krzysztof Kozlowski , Jerome Brunet , Martin Blumenstingl , Kevin Hilman , Rob Herring Cc: Da Xue , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> <20221004-up-aml-fix-spi-v3-1-89de126fd163@baylibre.com> <20c115e0-0acf-dac2-2a30-0f394fa513ab@linaro.org> From: Amjad Ouled-Ameur In-Reply-To: <20c115e0-0acf-dac2-2a30-0f394fa513ab@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 10/20/22 14:49, Krzysztof Kozlowski wrote: >>>> + properties: >>>> + pinctrl-names: >>>> + minItems: 1 >>>> + items: >>>> + - const: default >>>> + - const: idle-high >>>> + - const: idle-low >>> You should also define in such case pinctrl-0 and others. >> Ok I thought it would be covered by the pinctrl-consumer.yaml >> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: >> >> pinctrl-1: true >> pinctrl-2: true >> >> In such case, should I define pinctrl- as part of the if statement, as shown below, or before allOf ? [...]   - if:       properties:         compatible:           contains:             enum:               - amlogic,meson-gx-spicc     then:       properties:         pinctrl-0: true         pinctrl-1: true         pinctrl-2: true         pinctrl-names:           minItems: 1           items:             - const: default             - const: idle-high             - const: idle-low [...] Regards Amjad > Yes. > > Best regards, > Krzysztof >