Re: [PATCH 2/2] drm/imx: parallel-display: add the bridge before attaching it

[Louis Chauvet <louis.chauvet@bootlin.com>]

Le 14/10/2025 à 13:30, Luca Ceresoli a écrit :
> Invoking drm_bridge_add() is good practice, so add it to this driver.
> 
> Link: https://lore.kernel.org/all/DDHZ5GO9MPF0.CGYTVBI74FOZ@bootlin.com
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
> 
> Note: there is a proposal to make drm_bridge_add() mandatory before
> drm_bridge_attach():
> https://lore.kernel.org/lkml/20251003-b4-drm-bridge-alloc-add-before-attach-v1-3-92fb40d27704@bootlin.com/
> ---
>   drivers/gpu/drm/imx/ipuv3/parallel-display.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> index 3d0de9c6e925978b7532b6d13caf6909cc343dd7..7fc6af7033078eef6be0672ff0d1c7bddda88ba1 100644
> --- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> +++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> @@ -256,6 +256,8 @@ static int imx_pd_probe(struct platform_device *pdev)
>   
>   	platform_set_drvdata(pdev, imxpd);
>   
> +	devm_drm_bridge_add(dev, &imxpd->bridge);
> +
>   	return component_add(dev, &imx_pd_ops);
>   }
>   
> 

-- 
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com