From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932664AbcLSMPF (ORCPT ); Mon, 19 Dec 2016 07:15:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:57643 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310AbcLSMO7 (ORCPT ); Mon, 19 Dec 2016 07:14:59 -0500 Subject: Re: [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call To: Jiandi An , boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1482116198-28940-1-git-send-email-anjiandi@codeaurora.org> Cc: julien.grall@arm.com, sstabellini@kernel.org, shankerd@codeaurora.org, shannon.zhao@linaro.org From: Juergen Gross Message-ID: Date: Mon, 19 Dec 2016 13:14:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482116198-28940-1-git-send-email-anjiandi@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/16 03:56, Jiandi An wrote: > Ensure all reserved fields of xatp are zero before making hypervisor > call to XEN in xen_map_device_mmio(). xenmem_add_to_physmap_one() in > XEN fails the mapping request if extra.res reserved field in xatp is > not zero for XENMAPSPACE_dev_mmio request. > > Signed-off-by: Jiandi An > --- > drivers/xen/arm-device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/xen/arm-device.c b/drivers/xen/arm-device.c > index 778acf8..208273b 100644 > --- a/drivers/xen/arm-device.c > +++ b/drivers/xen/arm-device.c > @@ -87,6 +87,9 @@ static int xen_map_device_mmio(const struct resource *resources, > idxs[j] = XEN_PFN_DOWN(r->start) + j; > } > > + /* Ensure reserved fields are set to zero */ > + memset(&xatp, 0, sizeof(xatp)); > + > xatp.domid = DOMID_SELF; > xatp.size = nr; > xatp.space = XENMAPSPACE_dev_mmio; Instead of setting xatp to 0 in each iteration I'd prefer a static initialization of .domid and .space: struct xen_add_to_physmap_range xatp = { .domid = DOMID_SELF, .space = XENMAPSPACE_dev_mmio }; Juergen