From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725613B9D9E for ; Thu, 2 Apr 2026 21:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775165515; cv=none; b=LpmXbwIgP1wiUPfgR4LkfnqW2JsSQAOJdmZN1I7raKl7XwoGDtLxvIZ4SxcO88tdA6j32zYiMAbWVmdVQemvOzJ/fgyw9kiKGD77C5o9hH/L9LCIxJbwL2v4TIY3B+obkEPHF5IwLueQToHdflfOMoPno/OrEvQ9EGxFmLmTVyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775165515; c=relaxed/simple; bh=jT5N5puUXD0Mrt65ONYcgDH7TNm3QJ6jxgMZJyRwxew=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=NIfJNENU5r7xW5aq/CdErh5T+r04H2ms3y5vhYELjOn4mqq6797mtEOX1ctQ/OA1E8b4kDbiycB/dzdYlGgBeM3QRpjgd/dNTGNrvgw/5nN6kL8otvaI/6PDT97e7MCxCf4937DfTv9SBH65n6bGa/yk28+lxnyHfc93Q+XQpLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sHv8PvHq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sHv8PvHq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FB0DC116C6; Thu, 2 Apr 2026 21:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775165514; bh=jT5N5puUXD0Mrt65ONYcgDH7TNm3QJ6jxgMZJyRwxew=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sHv8PvHqqSh4BiskHrgktglKwp8MJBaWmkufhHJbTJhgjogmhjEG4QAVyAllgUnhY GrKYChFOS+bD4G8ls//2JsxxmZ1QDMuTVeK1yADuDKGO8ax8lGAy9vpWMzbYQ5j0rx 2i9efUkcQqgyiEt7IJ1btK9W1Pv/M7atufr6JnUlh2wejfJQD8HQmpziatdhmWl26c J1LfVKnk9xoUzF1ueu3DDoERR6MWaPSuR4aup4su7WUdvEgZjivrXvjHLjgPkIVndB u381/NGJcgBaxxzbsXCb2HAWVxnm5jjgvYdgdCis4woZtjm26IGbEnQJMIvt7dE/CN eDurMJ23g/RBQ== Date: Thu, 2 Apr 2026 15:31:51 -0600 (MDT) From: Paul Walmsley To: Ben Dooks cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com, pjw@kernel.org, linux-kernel@vger.kernel.org, alex@ghiti.fr Subject: Re: [PATCH] RISC-V: ACPI: fix two __iomem cast warnings In-Reply-To: <20260311102217.409376-1-ben.dooks@codethink.co.uk> Message-ID: References: <20260311102217.409376-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Ben, On Wed, 11 Mar 2026, Ben Dooks wrote: > The __acpi_map_table() and __acpi_unmap_table() return and > take __iomem tagged pointers. Add a cast to fix the sparse > warnings: > > arch/riscv/kernel/acpi.c:216:30: warning: incorrect type in return expression (different address spaces) > arch/riscv/kernel/acpi.c:216:30: expected void [noderef] __iomem * > arch/riscv/kernel/acpi.c:216:30: got void * > arch/riscv/kernel/acpi.c:224:24: warning: incorrect type in argument 1 (different address spaces) > arch/riscv/kernel/acpi.c:224:24: expected void *addr > arch/riscv/kernel/acpi.c:224:24: got void [noderef] __iomem *map > > Signed-off-by: Ben Dooks Thanks for taking a look at this. It appears that some of the other architectures have the same issue. Could you come up with a series that addresses the others as well? You might need to get the ACPI folks involved; it's not really clear to me why __acpi_map_table() needs to return an __iomem *. - Paul