From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758898AbdELSwA (ORCPT ); Fri, 12 May 2017 14:52:00 -0400 Received: from mout.web.de ([212.227.15.3]:63527 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274AbdELSv7 (ORCPT ); Fri, 12 May 2017 14:51:59 -0400 Subject: [PATCH 1/3] coresight: etb10: Delete an error message for a failed memory allocation in etb_probe() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Mathieu Poirier , "Suzuki K. Poulose" Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <5d5cd752-f2f2-b511-6b1e-daf5bf1bc522@users.sourceforge.net> Message-ID: Date: Fri, 12 May 2017 20:51:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <5d5cd752-f2f2-b511-6b1e-daf5bf1bc522@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:N22aC8HQZmzcaEdbj1fB6nwALFTo8gWDrBydhp+bDFwbMqcNX7m KnFV5F/5EhCro1I+aIuwooPNrA6hnVeM0PzqdBWEULd0Knk3lHh8odpIw1S5qfARR76dAv6 P8dLGueRpJHnyXbeUTQZQBGpKPqn82rUzRB1Fq3bb/CpA91L0pLTaqj4tWfT/AYmNNTvtTa gngvVegxay6sqha+37NAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:krqxoHKJKt4=:mkRRFKgYXtnazz4t6Kti1J utpFfA1HuaVJOjOzDOUnkpcqAwwk5Deg6Su2s5zKqF70pWMlrh/M3kLlwxBGhF6ZwDizOiU6N BGn59xTi8f03tonTnSt8kjHME4C5Bg0wPUPq8umYt5sPwzRIt2fIruwJkVo8D8pb5NUgHaXWv 8gO0UhZRFn0ddaqEFd8ZUdg3j20gsIkYSfwzj2LGnrvy+Ip33orANvcR7+RhsEZqaEYzioMbZ M0m9RikUxKN3SzpIU8y0JzRVfytZ5Lr2ppStmbSp5YnJNrE/iLMHUxJ4aNw2sr5UObhFLYAHh xwtS6tPUf6yXi0km8EDGjLdU61J3hiCIYMlM2uPsy7XXIO9lVhhR5BLqPrOvt7fOvVTeW2H/d Ib0ufk931GpNaNLTFe+VhhB1WYkgGMt+FTjHFKP2rw1np8ZwR2VQYJ4lEVL8e2yOJSKl4wije ao0pzrbyb6JlU0mwAVTYaJ0xnG4l6kmWVtc5dn2lccVaMWEALy5BKcIG6DCF+oVIzkT3jfXAz lDdGpaQMQ1jB0vakYUj3o+Pm8ImlLTJh1936jI4/iNGcD9Vvilst/Lm+/KCI41xuezwtadef7 e0+2Jas5qFxbsNJ5KKdm0nNJzDBQOBm6cdPEH7n+L2QAZ0Ll4r0OlKaqjhY/SUFlMB9d1ibh2 6IM/iSF089aV6bWwk04ZOm4Qn1P/qmo+xpoFGUSOvzIDGwixN1asvtQBxzl4o35VTsqK2e5c+ pNtzvX+Xbk47CgvaTB85+3TIAIeD76NJrm8JmBo6I5SsJIb3VqfxxgAxmuGaP1G3CFgkceTps 0Gb7qtw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 12 May 2017 20:23:43 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/hwtracing/coresight/coresight-etb10.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 979ea6ec7902..837aebf22c45 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -675,11 +675,8 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) drvdata->buf = devm_kzalloc(dev, drvdata->buffer_depth * 4, GFP_KERNEL); - if (!drvdata->buf) { - dev_err(dev, "Failed to allocate %u bytes for buffer data\n", - drvdata->buffer_depth * 4); + if (!drvdata->buf) return -ENOMEM; - } desc.type = CORESIGHT_DEV_TYPE_SINK; desc.subtype.sink_subtype = CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; -- 2.12.3