From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932463AbbD0JAj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Apr 2015 05:00:39 -0400
Received: from rev33.vpn.fdn.fr ([80.67.179.33]:33217 "EHLO
	marvin.crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751252AbbD0JAf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Apr 2015 05:00:35 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Mon, 27 Apr 2015 11:00:26 +0200
From: paul <paul@crapouillou.net>
To: Bastien Nocera <hadess@hadess.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: goodix: Check the 'data ready' bit before
 reading data
In-Reply-To: <1429966457.2525.54.camel@hadess.net>
References: <1429958890-10366-1-git-send-email-paul@crapouillou.net>
 <1429966457.2525.54.camel@hadess.net>
Message-ID: <df24297181d7b061f4c31f7fe118bdf6@mail.crapouillou.net>
User-Agent: Roundcube Webmail/0.9.5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bastien,

Ok, I will send a V2 with a better commit message then.

-Paul

Le 2015-04-25 14:54, Bastien Nocera a écrit :
> On Sat, 2015-04-25 at 12:48 +0200, Paul Cercueil wrote:
>> The MSB of the first byte read via I2C seems to indicate whether the
>> data is valid (or ready) when an interrupt is raised. Previously,
>> this
>> bit was ignored, which resulted in a lot of incorrect detections of
>> "finger removed" events.
> 
> This seems correct, but the wording doesn't match the language used in
> the Goodix docs that were posted here some time ago[1].
> 
> I would have written:
> The MSB of the first byte read via I2C at the coordinates address
> indicate whether the data is valid or ready (called "buffer status" in
> the datasheets) when an interrupt is raised. Previously, this bit was
> ignored, which resulted in a lot of incorrect detections of "finger
> removed" events.
> 
> And for the commit subject:
> input: goodix: Check the 'buffer status' bit before reading data
> 
> This seems correct otherwise.
> 
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> 
> with the fixed commit message/subject
> 
> [1]: Linked from the device tree support patch:
> https://patchwork.ozlabs.org/patch/446838/
> Page 16, table c, 0x814E is what we read for coordinates
> 
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>>  drivers/input/touchscreen/goodix.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/input/touchscreen/goodix.c
>> b/drivers/input/touchscreen/goodix.c
>> index ca19668..9fa6c5f 100644
>> --- a/drivers/input/touchscreen/goodix.c
>> +++ b/drivers/input/touchscreen/goodix.c
>> @@ -98,6 +98,9 @@ static int goodix_ts_read_input_report(struct
>> goodix_ts_data *ts, u8 *data)
>>               return error;
>>       }
>> 
>> +     if (!(data[0] & 0x80))
>> +             return -EAGAIN;
>> +
>>       touch_num = data[0] & 0x0f;
>>       if (touch_num > GOODIX_MAX_CONTACTS)
>>               return -EPROTO;