From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB3BC433F5 for ; Tue, 21 Sep 2021 13:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6FD3611C5 for ; Tue, 21 Sep 2021 13:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233013AbhIUNPY (ORCPT ); Tue, 21 Sep 2021 09:15:24 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:52625 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbhIUNPW (ORCPT ); Tue, 21 Sep 2021 09:15:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632230034; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qruw8g+PWJV0WRCjaAI8RXGWWjmuKapoRvx8jO4ZMmo=; b=s2tFVMjBFuMZfEd6Do/rGFX75Lwe89PNWGevUeEUYyafvrcd6M28R9vt6enTlWOQF6WoUj5H qe86cEuDOJhS/hnrqiy07MbK8luqfxenh/+dbVhDbT0z3hn7nKYKAdvmAIp2ppSggKS41EO4 heYeLWFmuqc/MOusuKC5J488jL8= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6149da8965c3cc8c633c0e21 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 21 Sep 2021 13:13:45 GMT Sender: jeyr=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4FA0FC43616; Tue, 21 Sep 2021 13:13:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jeyr) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72DFDC4338F; Tue, 21 Sep 2021 13:13:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 21 Sep 2021 18:43:44 +0530 From: jeyr@codeaurora.org To: Greg KH Cc: linux-arm-msm@vger.kernel.org, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com Subject: Re: [PATCH v3] misc: fastrpc: fix improper packet size calculation In-Reply-To: References: <1632224895-32661-1-git-send-email-jeyr@codeaurora.org> <9c5c13a393b64a4527f7be7ca42734d2@codeaurora.org> Message-ID: X-Sender: jeyr@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-09-21 18:10, Greg KH wrote: > On Tue, Sep 21, 2021 at 06:03:42PM +0530, jeyr@codeaurora.org wrote: >> On 2021-09-21 17:22, Greg KH wrote: >> > On Tue, Sep 21, 2021 at 05:18:15PM +0530, Jeya R wrote: >> > > The buffer list is sorted and this is not being considered while >> > > calculating packet size. This would lead to improper copy length >> > > calculation for non-dmaheap buffers which would eventually cause >> > > sending improper buffers to DSP. >> > > >> > > Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke >> > > method") >> > > Signed-off-by: Jeya R >> > > Reviewed-by: Srinivas Kandagatla >> > >> > Does this also need to go to the stable kernels? >> Yes, this needs to go to stable kernels also as this fixes a potential >> issue >> which is easily reproducible. > > > >> >> > >> > > --- >> > > Changes in v3: >> > > - relocate patch change list >> > > >> > > Changes in v2: >> > > - updated commit message to proper format >> > > - added fixes tag to commit message >> > > - removed unnecessary variable initialization >> > > - removed length check during payload calculation >> > > >> > > drivers/misc/fastrpc.c | 10 ++++++---- >> > > 1 file changed, 6 insertions(+), 4 deletions(-) >> > > >> > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> > > index beda610..69d45c4 100644 >> > > --- a/drivers/misc/fastrpc.c >> > > +++ b/drivers/misc/fastrpc.c >> > > @@ -719,16 +719,18 @@ static int fastrpc_get_meta_size(struct >> > > fastrpc_invoke_ctx *ctx) >> > > static u64 fastrpc_get_payload_size(struct fastrpc_invoke_ctx *ctx, >> > > int metalen) >> > > { >> > > u64 size = 0; >> > > - int i; >> > > + int oix; >> > >> > What does "oix" stand for? What was wrong with i? >> It is just a general convention we use. "oix" is used to iterate >> through >> sorted overlap buffer list and use "i" to get corresponding unsorted >> list >> index. We follow the same convention at other places also, for >> example: >> fastrpc_get_args function. > > That is the only place it is used in all of the whole kernel tree. It > is not a normal variable for a loop, so who is "we" here? The convention was followed for the same file(fastrpc.c). As part of fastrpc_get_args function, while iterating through sorted buffer list, oix is used as index and to get unsorted index "raix", it is using "i". Just following the same way here to have better understanding. Please let me know if this is a concern, it can be updated to "i", "j" etc. -- Thanks > > thanks, > > greg k-h